From: Stefan Kangas <stefan@marxist.se>
To: Lars Ingebrigtsen <larsi@gnus.org>,
Manuel Uberti <manuel.uberti@inventati.org>
Cc: 50621@debbugs.gnu.org
Subject: bug#50621: 28.0.50; Flymake wrong message about y-or-n-p
Date: Thu, 16 Sep 2021 08:05:50 -0700 [thread overview]
Message-ID: <CADwFkmnRGHfd8RzMiOj38-OfYm+7T76JU9oT4tJa_sdpX8njCQ@mail.gmail.com> (raw)
In-Reply-To: <87v930zji8.fsf@gnus.org>
Lars Ingebrigtsen <larsi@gnus.org> writes:
>> M-x checkdoc complains about this as well, so I guess it is more a
>> checkdoc than a Flymake problem here.
>
> Yeah, I guess all of the y-or-n-p stuff should be removed from
> checkdoc.el? Or should it still verify that the string ends with a
> question mark? I've added Stefan to the CCs; perhaps he has an opinion
> here.
As the NEWS item points out, the behavior was changed [IMO for the
better] already in 2014 (commit 298520dfb7f6). The question now is what
to do with Flymake/checkdoc, and I see three ways forward:
A) We remove this check.
B) We change it to only warn about a missing question mark.
C) We change it as in B, but also warn about a spurious space.
Alternative A is the easiest one, but loses functionality.
Alternative B is better, but leaves a spurious space where it's not
needed.
Alternative C will cause some code-churn, but is also formally the most
correct one. It might also save someones sanity if they are trying to
fit a line into a 80 or 100 character limit.
My preference is for, in order: C > B > A.
next prev parent reply other threads:[~2021-09-16 15:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 12:38 bug#50621: 28.0.50; Flymake wrong message about y-or-n-p Manuel Uberti
2021-09-16 12:53 ` Manuel Uberti
2021-09-16 14:23 ` Lars Ingebrigtsen
2021-09-16 15:05 ` Stefan Kangas [this message]
2021-09-16 15:17 ` Lars Ingebrigtsen
2021-09-16 20:05 ` Stefan Kangas
2021-09-17 13:55 ` Lars Ingebrigtsen
2021-09-17 20:41 ` Stefan Kangas
2021-09-18 5:57 ` Manuel Uberti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmnRGHfd8RzMiOj38-OfYm+7T76JU9oT4tJa_sdpX8njCQ@mail.gmail.com \
--to=stefan@marxist.se \
--cc=50621@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=manuel.uberti@inventati.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).