From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#50621: 28.0.50; Flymake wrong message about y-or-n-p Date: Thu, 16 Sep 2021 08:05:50 -0700 Message-ID: References: <87v930zji8.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18969"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50621@debbugs.gnu.org To: Lars Ingebrigtsen , Manuel Uberti Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 16 17:14:01 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQt5M-0004hu-Ue for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Sep 2021 17:14:00 +0200 Original-Received: from localhost ([::1]:57642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQt5L-0003qv-7A for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Sep 2021 11:13:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQsyc-0003re-RX for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 11:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44661) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQsyc-0007tx-Ir for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 11:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQsyc-00030R-BQ for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 11:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Sep 2021 15:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50621 X-GNU-PR-Package: emacs Original-Received: via spool by 50621-submit@debbugs.gnu.org id=B50621.163180477111497 (code B ref 50621); Thu, 16 Sep 2021 15:07:02 +0000 Original-Received: (at 50621) by debbugs.gnu.org; 16 Sep 2021 15:06:11 +0000 Original-Received: from localhost ([127.0.0.1]:56207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQsxn-0002zN-KA for submit@debbugs.gnu.org; Thu, 16 Sep 2021 11:06:11 -0400 Original-Received: from mail-pg1-f178.google.com ([209.85.215.178]:40525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQsxY-0002yg-Tl for 50621@debbugs.gnu.org; Thu, 16 Sep 2021 11:06:10 -0400 Original-Received: by mail-pg1-f178.google.com with SMTP id h3so6408703pgb.7 for <50621@debbugs.gnu.org>; Thu, 16 Sep 2021 08:05:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=eIphIA4xI90I8KMun+wvaVTrooh8aAaK5SVt+CrEqiQ=; b=as7iMfMP0WtGKuIy6BPyy+r1QRZzrIT8j/60lRLUxWtbpfXyGzlaoMx1RP3SlWHPjZ OkPmbACLwwxpWGnrcwlLlcHmQjOes8yvStxKO+w0xT2S7Kt+XvaiyMCuBiBMFIbk2Jlf WaHJpBR7ar278V0Oy/eOmaD0+2QTcVfUB9jMUEt6rpWrXc0h4LRdrt5JJnqCSEF2Z+9r Cn8PvEDLjZXcsGz8oRFXPF0+MymjPdVB9CCqmT0F8g8TvpR0Oc1MJdfvdvSp8cJ7Qdr9 oINzRjp6JA/GTOONiLS1dEEO6K4jgxO9NjurVR0NswR/JApqsDCQHksxucFxfIjrRUpA wVkg== X-Gm-Message-State: AOAM531wWvP9Z2zxjtF1IMypOoxWUkxos0kh3/1+j9CdjDT3B3Kt5aLX /IOdHaG4Be7yA6AYnrCgU0Obw/E9fCOhON4w3oY= X-Google-Smtp-Source: ABdhPJxGmf3KB4c3YGScv59WBgRcHNWhU2gk2FK6SEQQTE2YyykNkGOtMHEOwqSRk7q0WcWrCXm3YKAAzajoXtEZdSc= X-Received: by 2002:a62:ea06:0:b0:3e1:62a6:95b8 with SMTP id t6-20020a62ea06000000b003e162a695b8mr5695527pfh.70.1631804751162; Thu, 16 Sep 2021 08:05:51 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 16 Sep 2021 08:05:50 -0700 In-Reply-To: <87v930zji8.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214472 Archived-At: Lars Ingebrigtsen writes: >> M-x checkdoc complains about this as well, so I guess it is more a >> checkdoc than a Flymake problem here. > > Yeah, I guess all of the y-or-n-p stuff should be removed from > checkdoc.el? Or should it still verify that the string ends with a > question mark? I've added Stefan to the CCs; perhaps he has an opinion > here. As the NEWS item points out, the behavior was changed [IMO for the better] already in 2014 (commit 298520dfb7f6). The question now is what to do with Flymake/checkdoc, and I see three ways forward: A) We remove this check. B) We change it to only warn about a missing question mark. C) We change it as in B, but also warn about a spurious space. Alternative A is the easiest one, but loses functionality. Alternative B is better, but leaves a spurious space where it's not needed. Alternative C will cause some code-churn, but is also formally the most correct one. It might also save someones sanity if they are trying to fit a line into a 80 or 100 character limit. My preference is for, in order: C > B > A.