unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Damien Cassou <damien@cassou.me>, 65790-done@debbugs.gnu.org
Subject: bug#65790: 29.1; "docstring wider than 80 characters" when there is no docstring
Date: Wed, 13 Sep 2023 07:38:31 -0700	[thread overview]
Message-ID: <CADwFkmnH6Ek-L3MSk3PHzt5+35PraHCd8QgMuSuxAz-vsNeWMA@mail.gmail.com> (raw)
In-Reply-To: <87bke7nqml.fsf@cassou.me>

Version: 30.1

Damien Cassou <damien@cassou.me> writes:

> I've added tests to bytecomp-tests.el as suggested. (why not
> cl-macs-tests.el instead?)

Good question.  Perhaps we should move all of those tests to more
relevant locations.  OTOH, the macro for this is in bytecomp-tests.el
currently, so I guess we'd have to move that.  Maybe it would fit in
ert-x.el.  It seems outside the scope of this bug report though.

>> Could we keep the old format when possible, and use the new one only
>> when needed?
>
> I tried to do that, is that what you want? I feel the added complexity
> isn't worth it so I'm fine changing it back to the simpler version if
> you change your mind.

The code is less nice obviously, but I think not changing the
autogenerated docstrings in the typical cases is also important.
Therefore, I think the complexity is ultimately worth it.  Perhaps
someone should do a round over all of this to see if it can be cleaned
up a bit, though...

I've now installed your patches on master.  Feel free to post followups
if you want to fix any of the above, or if you spot anything else that
could be improved in relation to this.

Thanks again for your efforts.





      reply	other threads:[~2023-09-13 14:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-06 19:08 bug#65790: 29.1; "docstring wider than 80 characters" when there is no docstring Damien Cassou
2023-09-07  5:04 ` Eli Zaretskii
2023-09-07  9:30   ` Damien Cassou
2023-09-07  8:52 ` Stefan Kangas
2023-09-07  9:33   ` Damien Cassou
2023-09-07  9:47     ` Stefan Kangas
2023-09-10  6:47       ` Damien Cassou
2023-09-10  9:55         ` Stefan Kangas
2023-09-12 19:22           ` Damien Cassou
2023-09-13 14:38             ` Stefan Kangas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmnH6Ek-L3MSk3PHzt5+35PraHCd8QgMuSuxAz-vsNeWMA@mail.gmail.com \
    --to=stefankangas@gmail.com \
    --cc=65790-done@debbugs.gnu.org \
    --cc=damien@cassou.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).