From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#65790: 29.1; "docstring wider than 80 characters" when there is no docstring Date: Wed, 13 Sep 2023 07:38:31 -0700 Message-ID: References: <87edjbp1aq.fsf@cassou.me> <87fs3qwcoi.fsf@cassou.me> <87o7iaikxd.fsf@cassou.me> <87bke7nqml.fsf@cassou.me> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10592"; mail-complaints-to="usenet@ciao.gmane.io" To: Damien Cassou , 65790-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 13 16:39:07 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qgR1G-0002YO-Va for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 Sep 2023 16:39:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgR19-0002yo-4B; Wed, 13 Sep 2023 10:38:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgR17-0002xx-8x for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 10:38:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgR16-0003bw-Mt for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 10:38:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qgR1B-0001ic-Ui for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 10:39:01 -0400 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Sep 2023 14:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 65790 X-GNU-PR-Package: emacs Mail-Followup-To: 65790@debbugs.gnu.org, stefankangas@gmail.com, damien@cassou.me Original-Received: via spool by 65790-done@debbugs.gnu.org id=D65790.16946159286580 (code D ref 65790); Wed, 13 Sep 2023 14:39:01 +0000 Original-Received: (at 65790-done) by debbugs.gnu.org; 13 Sep 2023 14:38:48 +0000 Original-Received: from localhost ([127.0.0.1]:35563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgR0x-0001i4-Ms for submit@debbugs.gnu.org; Wed, 13 Sep 2023 10:38:47 -0400 Original-Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]:58729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgR0s-0001hn-V6 for 65790-done@debbugs.gnu.org; Wed, 13 Sep 2023 10:38:46 -0400 Original-Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2bfbd7d49e7so9835751fa.1 for <65790-done@debbugs.gnu.org>; Wed, 13 Sep 2023 07:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694615911; x=1695220711; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=3CFRO+4g3TxW+fkbl78ZjfQYgvuZ1OpqdcvgowaAgD4=; b=lVxAp1MxTKEWDtvYy5aDM8kr+g0jPSCbnXJF5tIa8EuI5KSd2BrKc0Jfg+aVz5p89F fNu7CWWX0/WM8y7u2JhnDY5SyD7MLx7Dd4dioCjRAIdglG1RBFUcRlDxI6kQobHn/BEB H7VYd46RJf00P1ZWTY+qjAH3dw0L41LoYB/jN5wfqU8BxQTvyBlAVFtb7zTD2KY7lxRa TlENBFWUIOHyrOfJQK4FD6fxznTI2iFZp6ZsMKnWodOam/B0JJL1q4OKz/Qgi2nULRnG hLdGaPHztCbydgm1sD9ZTitwGYGmWlvGV+zNk8MTxRpuj5d9FdLMsVEoRzTlwK0vhIbi NW7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694615911; x=1695220711; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3CFRO+4g3TxW+fkbl78ZjfQYgvuZ1OpqdcvgowaAgD4=; b=oGHY5A5xMzHVYyBuUh6dBdbwGVRhk6cl2SH66mCcN+WQUxTHWUEBoLzNPCipO9X2F6 iwzkSiiEUXcUIRD7X5utzHZiKgCXHLqFTGPhFdFdRMZiLLtrdlyEljv3INZkxHkeHGvu 6wSwtSxTxWsiN+a67WfE5wzuTORjkLaTI3ys78MN8lsTuyM1VeDP1Or41ksM0AXp8m8F hXK8717TVdGs4za13aUuTsU5GFWOQ6LvhfUgMZJNIOybEmUbV+L1FRTDws0V5uFAKj1v eOilWQWLiqVZwc95TGXWlDD0ZR57cLMlr+0qcG0//U7O9abuzIsMoQIKrfjwSBNDaNqs yKcQ== X-Gm-Message-State: AOJu0YylUYmF4kNKp3vHKFP3AYs2VJX8d/xEUCwWY9k+QID13y+eWpSN SXq41p6701d45RUZpEcZNCnzgxoBEOZCdEExz4M= X-Google-Smtp-Source: AGHT+IH+FaePh2zftAmgPs92bgQ0eFsPnYmXVyQuUPoz3IeABTLUFSbTDK8yp9zA7cYMML2EJbDixAd9wZqY6IgaI2w= X-Received: by 2002:a2e:9dc5:0:b0:2bc:b557:cee9 with SMTP id x5-20020a2e9dc5000000b002bcb557cee9mr2684106ljj.43.1694615911438; Wed, 13 Sep 2023 07:38:31 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 13 Sep 2023 07:38:31 -0700 In-Reply-To: <87bke7nqml.fsf@cassou.me> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270299 Archived-At: Version: 30.1 Damien Cassou writes: > I've added tests to bytecomp-tests.el as suggested. (why not > cl-macs-tests.el instead?) Good question. Perhaps we should move all of those tests to more relevant locations. OTOH, the macro for this is in bytecomp-tests.el currently, so I guess we'd have to move that. Maybe it would fit in ert-x.el. It seems outside the scope of this bug report though. >> Could we keep the old format when possible, and use the new one only >> when needed? > > I tried to do that, is that what you want? I feel the added complexity > isn't worth it so I'm fine changing it back to the simpler version if > you change your mind. The code is less nice obviously, but I think not changing the autogenerated docstrings in the typical cases is also important. Therefore, I think the complexity is ultimately worth it. Perhaps someone should do a round over all of this to see if it can be cleaned up a bit, though... I've now installed your patches on master. Feel free to post followups if you want to fix any of the above, or if you spot anything else that could be improved in relation to this. Thanks again for your efforts.