unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 44854@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#44854: [PATCH] Add lexical-binding cookie to autoload files
Date: Wed, 25 Nov 2020 15:53:57 -0500	[thread overview]
Message-ID: <CADwFkmnG_=4x4+Hbr5y_cwaEQVdN=DaW9vTNfDs+ecq6MnLLyA@mail.gmail.com> (raw)
In-Reply-To: <83wny9scmb.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

> See, this plan is not something that was even discussed, let alone
> decided upon.  When discussing such plans in private email, please
> consider the effect of that on people who didn't participate in those
> discussions: they see steps being taken without the goal being clearly
> announced and agreed upon.

I completely see your point Eli, and I understand your frustration.
Private plans could indeed play a negative role if they are not agreed
upon but implemented, especially when it comes to big issues such as
this one.

But the patch here was actually based on my impression that it was
generally agreed that we should convert files to use lexical-binding.
However, when you asked why I thought that these files should be
converted, even though there are few immediate practical benefits, I
felt that it deserved a full answer.

The other "plan" is not exactly (yet) worthy of that name to be honest.

Here's the story:

I have learned the hard way that a discussion on emacs-devel can
unfortunately very easily focus on exactly the wrong things.  I guess to
some extent that's just the result of the limitations of discussing via
email.  My intention was therefore to prepare something well-thought-out
that could hopefully constructively move things forward with
lexical-binding.

So I asked Stefan M privately what he thought about warning when
lexical-binding is not set to t.  He replied that it is a bad idea, and
that we should probably warn if it is not set to t or nil.  I agreed,
and that's pretty much it.

So the only "plan" that can be said to have existed was my personal
intention to bring it emacs-devel.  But I hadn't yet done so: I was
still mulling over the timing (before/after the relase of Emacs 28?) and
more importantly its content (i.e. I was planning to write up a patch).

I hope that clarifies things.  It was never my intention to surprise
anyone, least of all any of the maintainers.  Sorry for not being more
clear in my previous emails and having created confusion.

> I think before we make steps in this direction (as opposed to just
> switching more and more Lisp files to lexical-binding, where there's
> code that could benefit from that), we should actually discuss on
> emacs-devel and agree that this is our practical intention in the near
> future.

OK!  It sounds good to take this to emacs-devel.  Let's do it.





  parent reply	other threads:[~2020-11-25 20:53 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-24 19:34 bug#44854: [PATCH] Add lexical-binding cookie to autoload files Stefan Kangas
2020-11-24 20:21 ` Eli Zaretskii
2020-11-24 20:46   ` Stefan Kangas
2020-11-24 20:54     ` Drew Adams
2020-11-24 21:05       ` Stefan Kangas
2020-11-24 21:22         ` Drew Adams
2020-11-24 21:57         ` Stefan Monnier
2020-11-24 22:39           ` Drew Adams
2020-11-24 21:04     ` Eli Zaretskii
2020-11-24 21:35       ` Stefan Kangas
2020-11-24 21:43         ` Drew Adams
2020-11-25  7:23         ` Lars Ingebrigtsen
2020-11-25 15:02         ` Eli Zaretskii
2020-11-25 15:08           ` Lars Ingebrigtsen
2020-11-25 16:40           ` Stefan Monnier
2020-11-25 17:30             ` Eli Zaretskii
2020-11-25 17:54               ` Stefan Monnier
2020-11-25 18:22                 ` Eli Zaretskii
2020-11-25 18:56                   ` Stefan Monnier
2020-11-25 19:01                     ` Philipp Stephani
2020-11-25 19:15                       ` Eli Zaretskii
2020-11-25 19:12                     ` Eli Zaretskii
2020-11-25 19:35                       ` Philipp Stephani
2020-11-25 20:00                         ` Eli Zaretskii
2020-11-25 20:06                       ` Stefan Monnier
2020-11-25 20:27                         ` Eli Zaretskii
2020-11-25 21:07                           ` Stefan Kangas
2020-11-26 14:02                             ` Eli Zaretskii
2020-11-27 22:39                               ` Andy Moreton
2020-11-28  7:59                                 ` Eli Zaretskii
2020-11-29 10:30                                   ` Lars Ingebrigtsen
2020-12-02 13:51                                   ` Stefan Kangas
2020-11-25 20:53           ` Stefan Kangas [this message]
2020-11-24 20:24 ` Drew Adams
2020-11-24 21:05   ` Stefan Kangas
2020-11-24 21:28     ` Drew Adams
2020-11-24 21:58 ` Stefan Monnier
2020-12-31  5:39 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmnG_=4x4+Hbr5y_cwaEQVdN=DaW9vTNfDs+ecq6MnLLyA@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=44854@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).