unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 44854@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#44854: [PATCH] Add lexical-binding cookie to autoload files
Date: Tue, 24 Nov 2020 13:35:22 -0800	[thread overview]
Message-ID: <CADwFkm=byHwST5sB1ogKHLEFH44i_DdXywUfkEXVG1sHDP_CZQ@mail.gmail.com> (raw)
In-Reply-To: <83360ytqk3.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

> I guess I'm asking how is this a step on that journey.  Can you
> elaborate?

[ In the interest of full disclosure, I had a brief private discussion
  with Stefan M about this.  I can only speak for myself, but I will
  share my clarified thinking based on his input. ]

I believe that if we want to have lexical-binding by default, we will at
some point need to begin issuing byte-compiler warnings for files that
do not explicitly say one of "-*- lexical-binding:t -*- or
"-*- lexical-binding:nil -*-".

This warning would need to be there for a period of time likely to be at
least as long as the time span we usually allow before removing any
obsolete feature.  Probably even longer.

Only after such a time period with the warning can we think about using
"lexical-binding:t" as the default.  At that point, any library that has
not yet been converted will hopefully use "lexical-binding:nil".

Now, the above idea would involve changing all of our own files to use
one of the above.  Possibly proposing this change in this manner is
putting the horse ahead of the cart.  But I was still undecided on
whether or not this was worth bringing up for general discussion on
emacs-devel for Emacs 28.

This just seemed like a small and hopefully uncontroversial step, along
the lines of: "there is no reason to not use "lexical-binding:t" in
these files, so we might as well add it now, which will make the
transition easier in the future".

I would be interested in hearing what you think about the above.





  reply	other threads:[~2020-11-24 21:35 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-24 19:34 bug#44854: [PATCH] Add lexical-binding cookie to autoload files Stefan Kangas
2020-11-24 20:21 ` Eli Zaretskii
2020-11-24 20:46   ` Stefan Kangas
2020-11-24 20:54     ` Drew Adams
2020-11-24 21:05       ` Stefan Kangas
2020-11-24 21:22         ` Drew Adams
2020-11-24 21:57         ` Stefan Monnier
2020-11-24 22:39           ` Drew Adams
2020-11-24 21:04     ` Eli Zaretskii
2020-11-24 21:35       ` Stefan Kangas [this message]
2020-11-24 21:43         ` Drew Adams
2020-11-25  7:23         ` Lars Ingebrigtsen
2020-11-25 15:02         ` Eli Zaretskii
2020-11-25 15:08           ` Lars Ingebrigtsen
2020-11-25 16:40           ` Stefan Monnier
2020-11-25 17:30             ` Eli Zaretskii
2020-11-25 17:54               ` Stefan Monnier
2020-11-25 18:22                 ` Eli Zaretskii
2020-11-25 18:56                   ` Stefan Monnier
2020-11-25 19:01                     ` Philipp Stephani
2020-11-25 19:15                       ` Eli Zaretskii
2020-11-25 19:12                     ` Eli Zaretskii
2020-11-25 19:35                       ` Philipp Stephani
2020-11-25 20:00                         ` Eli Zaretskii
2020-11-25 20:06                       ` Stefan Monnier
2020-11-25 20:27                         ` Eli Zaretskii
2020-11-25 21:07                           ` Stefan Kangas
2020-11-26 14:02                             ` Eli Zaretskii
2020-11-27 22:39                               ` Andy Moreton
2020-11-28  7:59                                 ` Eli Zaretskii
2020-11-29 10:30                                   ` Lars Ingebrigtsen
2020-12-02 13:51                                   ` Stefan Kangas
2020-11-25 20:53           ` Stefan Kangas
2020-11-24 20:24 ` Drew Adams
2020-11-24 21:05   ` Stefan Kangas
2020-11-24 21:28     ` Drew Adams
2020-11-24 21:58 ` Stefan Monnier
2020-12-31  5:39 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=byHwST5sB1ogKHLEFH44i_DdXywUfkEXVG1sHDP_CZQ@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=44854@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).