unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#65627: 28.2; erc-button-url-regexp does not recognise gophers://
@ 2023-08-30 11:03 Troels Henriksen
  2023-08-30 19:01 ` Stefan Kangas
  0 siblings, 1 reply; 2+ messages in thread
From: Troels Henriksen @ 2023-08-30 11:03 UTC (permalink / raw)
  To: 65627

The regex in

  browse-url-button-regexp

does not recognise the gophers:// protocol.  Similarly to https://,
gophers:// is an encrypted variant of the venerable Gopher protocol.
The gophers protocol is supported in curl and other programs that build
on libcurl, and while I can customize `browse-url-button-regexp` myself,
I think it would be useful for all Emacs users if Emacs recognised
gophers:// directly.

A fix is simple: just add 's?' after 'gopher' in the regexp.





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#65627: 28.2; erc-button-url-regexp does not recognise gophers://
  2023-08-30 11:03 bug#65627: 28.2; erc-button-url-regexp does not recognise gophers:// Troels Henriksen
@ 2023-08-30 19:01 ` Stefan Kangas
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Kangas @ 2023-08-30 19:01 UTC (permalink / raw)
  To: Troels Henriksen; +Cc: 65627-done

Version: 29.2

> The regex in
>
>   browse-url-button-regexp
>
> does not recognise the gophers:// protocol.  Similarly to https://,
> gophers:// is an encrypted variant of the venerable Gopher protocol.
> The gophers protocol is supported in curl and other programs that build
> on libcurl, and while I can customize `browse-url-button-regexp` myself,
> I think it would be useful for all Emacs users if Emacs recognised
> gophers:// directly.
>
> A fix is simple: just add 's?' after 'gopher' in the regexp.

Thanks for the bug report.

I see that it is supported by libcurl, here: https://curl.se/libcurl/
There is also FTPS, which we don't have in our regexp.

So I've now fixed this on the master branch (commit 9e2d5a013c9), and
I'm closing this bug.





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-30 19:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-30 11:03 bug#65627: 28.2; erc-button-url-regexp does not recognise gophers:// Troels Henriksen
2023-08-30 19:01 ` Stefan Kangas

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).