unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 15809@debbugs.gnu.org
Subject: bug#15809: 24.3.50; wrong defcustom type for `suggest-key-bindings'
Date: Sat, 25 Sep 2021 07:53:57 -0700	[thread overview]
Message-ID: <CADwFkmmakvOvK4C02x-dbeXFiDtpAMLH10fr4EhwWXmCuF1zDg@mail.gmail.com> (raw)
In-Reply-To: <E5AD627A-DDEB-4EAF-A682-A2AE152DF7B5@acm.org>

Mattias Engdegård <mattiase@acm.org> writes:

> 25 sep. 2021 kl. 15.00 skrev Stefan Kangas <stefan@marxist.se>:
>
>>>> (define-widget 'natnum 'restricted-sexp
>>>>  "A nonnegative integer."
>>>>  :tag "Integer (positive)"
>>>
>>> Sorry, but this is just wrong. 0 is not a positive integer.
>>
>> The text does not say that zero is positive.
>
> Actually the tag text does.

Well spotted, thanks!  That is completely wrong, yes.

> What about "Integer (nonnegative)", "Integer (positive or zero)", or
> something else?

Both sound good to me.  The second one doesn't just repeat what is
already said in the other text, so I slightly prefer that one.  Feel
free to install whichever you like better (or tell me to do it if that's
easier).

> And please accept my apologies about the somewhat unfriendly tone of
> my original message. I'm really very happy with the change otherwise.

No reason to apologize.  I was mostly wondering what was the reason for
all the commotion, but now I can see why.  :-)





  reply	other threads:[~2021-09-25 14:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <D0F524A8-6F43-4A73-928B-EC91FAFA2866@acm.org>
2021-09-25 10:50 ` bug#15809: 24.3.50; wrong defcustom type for `suggest-key-bindings' Mattias Engdegård
2021-09-25 10:57 ` Mattias Engdegård
2021-09-25 13:00 ` Stefan Kangas
2021-09-25 13:07   ` Mattias Engdegård
2021-09-25 14:53     ` Stefan Kangas [this message]
2021-09-25 18:32       ` Mattias Engdegård
2021-09-25 15:31   ` bug#15809: [External] : " Drew Adams
2021-09-25 15:24 ` Drew Adams
2013-11-05 15:30 Drew Adams
2014-02-08  3:36 ` Lars Ingebrigtsen
2014-02-09  2:14   ` Drew Adams
2014-02-11 11:47     ` Lars Ingebrigtsen
2020-10-28  7:50   ` Stefan Kangas
2020-10-28  8:00     ` Lars Ingebrigtsen
2020-10-28 14:25       ` Drew Adams
2021-09-24 23:32         ` Stefan Kangas
2021-09-24 23:34       ` Stefan Kangas
2021-09-25  1:09         ` Lars Ingebrigtsen
2021-09-25  1:54           ` Stefan Kangas
2021-09-25  2:06             ` Lars Ingebrigtsen
2021-09-25  2:43               ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmmakvOvK4C02x-dbeXFiDtpAMLH10fr4EhwWXmCuF1zDg@mail.gmail.com \
    --to=stefan@marxist.se \
    --cc=15809@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).