bug#22451: 24.5; `customize-apropos-options': wrong message

[Stefan Kangas <stefan@marxist.se>]

[-- Attachment #1: Type: text/plain, Size: 1395 bytes --]

tags 22451 + patch
thanks

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Drew Adams <drew.adams@oracle.com> writes:
>
>> emacs -Q
>> M-x customize-apropos-options .* RET
>>
>> You see the message "Resetting customization items...", which is quite
>> wrong.  Nothing is being reset.  Users will be confused and certainly
>> hope/pray that that no option is actually being "reset".
>
> Richard added those messages in 2005...  I'm not quite sure what the
> logic is here, but there does seem to be something...  reset...  here...
>
>    (message "Creating customization items ...done")
> +  (message "Resetting customization items...")
>    (unless (eq custom-buffer-style 'tree)
>      (mapc 'custom-magic-reset custom-options))
> +  (message "Resetting customization items...done")
>    (message "Creating customization setup...")
>
> Oh, it's just a redrawing thing:
>
> ----------
> custom-magic-reset is a compiled Lisp function in ‘cus-edit.el’.
>
> (custom-magic-reset WIDGET)
>
> Redraw the :custom-magic property of WIDGET.
> ----------
>
> In that case I agree that the message is misleading, and I think it
> should just be removed.  That part doesn't seem to take that much time,
> anyway.  Richard?

That was three years ago.

I think it's time to get rid of them.  See the attached patch, which
does just that.

Thanks,
Stefan Kangas

[-- Attachment #2: 0001-Remove-misleading-message-in-customize.patch --]
[-- Type: application/octet-stream, Size: 994 bytes --]

From 54586c90552ce4d072150a1bf69b0937b78c174b Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Thu, 11 Jul 2019 05:48:02 +0200
Subject: [PATCH] Remove misleading message in customize

* lisp/cus-edit.el (custom-buffer-create-internal): Remove misleading
message about "Resetting customization items".  (Bug#22451)
---
 lisp/cus-edit.el | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
index 0b9fb27a73..8a8bad9113 100644
--- a/lisp/cus-edit.el
+++ b/lisp/cus-edit.el
@@ -1726,10 +1726,8 @@ custom-buffer-create-internal
   (unless (eq (preceding-char) ?\n)
     (widget-insert "\n"))
   (message "Creating customization items ...done")
-  (message "Resetting customization items...")
   (unless (eq custom-buffer-style 'tree)
     (mapc 'custom-magic-reset custom-options))
-  (message "Resetting customization items...done")
   (message "Creating customization setup...")
   (widget-setup)
   (buffer-enable-undo)
-- 
2.21.0