From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#22451: 24.5; `customize-apropos-options': wrong message Date: Thu, 11 Jul 2019 06:17:44 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000000b5784058d601477" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="114521"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 22451@debbugs.gnu.org, Richard Stallman To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 11 06:19:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlQY7-000Tbk-Kp for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Jul 2019 06:19:15 +0200 Original-Received: from localhost ([::1]:38430 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlQY0-0007kb-Kd for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Jul 2019 00:19:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60269) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlQXv-0007kO-Gp for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 00:19:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlQXu-0006XW-Hn for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 00:19:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56319) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hlQXu-0006XI-DL for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 00:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hlQXu-0008GS-5R for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 00:19:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jul 2019 04:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22451 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 22451-submit@debbugs.gnu.org id=B22451.156281868731705 (code B ref 22451); Thu, 11 Jul 2019 04:19:02 +0000 Original-Received: (at 22451) by debbugs.gnu.org; 11 Jul 2019 04:18:07 +0000 Original-Received: from localhost ([127.0.0.1]:36907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlQX0-0008FJ-Kn for submit@debbugs.gnu.org; Thu, 11 Jul 2019 00:18:06 -0400 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:39842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlQWw-0008Eb-NA for 22451@debbugs.gnu.org; Thu, 11 Jul 2019 00:18:03 -0400 Original-Received: by mail-wm1-f50.google.com with SMTP id z23so25386wma.4 for <22451@debbugs.gnu.org>; Wed, 10 Jul 2019 21:18:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=RPBzc4zMdRSizEchXvIf96OI1sGq/GOtjGqMTihtC14=; b=Gpz+EcY6+CclBWBmwbUwBXbKwaNCy/PUCAq/kgJucs4vzlPtY4lJBieU+GkfBTS1f8 JzAoIT2FHgxzRO31Q2xCwK9avmIk7EUQ2au4QUis2l0tkzW3eXGf4PXR9tCikGOO8kCP cn8E2ac+CMyS6qX0a+UCkivfxOQzu09PIjCCc7GCdCIX7mZ4HRnF9vu3vq8HWrBX8aCa UbbwAQkLQMwmZYgHfnjb+6FYQZZLJ1eF2O+U3cvBvdvV/R9phk23F8KknHm0HDUGlIwU Gh8QUImxS5yHCw/K3loDP0nCURzovkCxpp1fuvINu0kiLWWddIigCYkWNAGHoJ8elJ+P 0S3Q== X-Gm-Message-State: APjAAAX8VwHVg4jHtL3bJbK2ofx/bj69BZenNmbzh7WDI+zoqHTgHl+e 4g2DgkaVGK6bZ37nw7kJY7zeKGjQEdOHTVoJdT0= X-Google-Smtp-Source: APXvYqwC362Lcczs7WlyLW4NZDFce83oP3wj13YetQXlF9/JM9uIQQKMliTmFkeNK7YMkQQqFybKblZf4TPWF3/TdPw= X-Received: by 2002:a1c:7c08:: with SMTP id x8mr1312252wmc.19.1562818676203; Wed, 10 Jul 2019 21:17:56 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162679 Archived-At: --0000000000000b5784058d601477 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable tags 22451 + patch thanks Lars Ingebrigtsen writes: > Drew Adams writes: > >> emacs -Q >> M-x customize-apropos-options .* RET >> >> You see the message "Resetting customization items...", which is quite >> wrong. Nothing is being reset. Users will be confused and certainly >> hope/pray that that no option is actually being "reset". > > Richard added those messages in 2005... I'm not quite sure what the > logic is here, but there does seem to be something... reset... here... > > (message "Creating customization items ...done") > + (message "Resetting customization items...") > (unless (eq custom-buffer-style 'tree) > (mapc 'custom-magic-reset custom-options)) > + (message "Resetting customization items...done") > (message "Creating customization setup...") > > Oh, it's just a redrawing thing: > > ---------- > custom-magic-reset is a compiled Lisp function in =E2=80=98cus-edit.el=E2= =80=99. > > (custom-magic-reset WIDGET) > > Redraw the :custom-magic property of WIDGET. > ---------- > > In that case I agree that the message is misleading, and I think it > should just be removed. That part doesn't seem to take that much time, > anyway. Richard? That was three years ago. I think it's time to get rid of them. See the attached patch, which does just that. Thanks, Stefan Kangas --0000000000000b5784058d601477 Content-Type: application/octet-stream; name="0001-Remove-misleading-message-in-customize.patch" Content-Disposition: attachment; filename="0001-Remove-misleading-message-in-customize.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxy5ttse0 RnJvbSA1NDU4NmM5MDU1MmNlNGQwNzIxNTBhMWJmNjliMDkzN2I3OGMxNzRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUaHUsIDExIEp1bCAyMDE5IDA1OjQ4OjAyICswMjAwClN1YmplY3Q6IFtQQVRDSF0g UmVtb3ZlIG1pc2xlYWRpbmcgbWVzc2FnZSBpbiBjdXN0b21pemUKCiogbGlzcC9jdXMtZWRpdC5l bCAoY3VzdG9tLWJ1ZmZlci1jcmVhdGUtaW50ZXJuYWwpOiBSZW1vdmUgbWlzbGVhZGluZwptZXNz YWdlIGFib3V0ICJSZXNldHRpbmcgY3VzdG9taXphdGlvbiBpdGVtcyIuICAoQnVnIzIyNDUxKQot LS0KIGxpc3AvY3VzLWVkaXQuZWwgfCAyIC0tCiAxIGZpbGUgY2hhbmdlZCwgMiBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9saXNwL2N1cy1lZGl0LmVsIGIvbGlzcC9jdXMtZWRpdC5lbAppbmRl eCAwYjlmYjI3YTczLi44YThiYWQ5MTEzIDEwMDY0NAotLS0gYS9saXNwL2N1cy1lZGl0LmVsCisr KyBiL2xpc3AvY3VzLWVkaXQuZWwKQEAgLTE3MjYsMTAgKzE3MjYsOCBAQCBjdXN0b20tYnVmZmVy LWNyZWF0ZS1pbnRlcm5hbAogICAodW5sZXNzIChlcSAocHJlY2VkaW5nLWNoYXIpID9cbikKICAg ICAod2lkZ2V0LWluc2VydCAiXG4iKSkKICAgKG1lc3NhZ2UgIkNyZWF0aW5nIGN1c3RvbWl6YXRp b24gaXRlbXMgLi4uZG9uZSIpCi0gIChtZXNzYWdlICJSZXNldHRpbmcgY3VzdG9taXphdGlvbiBp dGVtcy4uLiIpCiAgICh1bmxlc3MgKGVxIGN1c3RvbS1idWZmZXItc3R5bGUgJ3RyZWUpCiAgICAg KG1hcGMgJ2N1c3RvbS1tYWdpYy1yZXNldCBjdXN0b20tb3B0aW9ucykpCi0gIChtZXNzYWdlICJS ZXNldHRpbmcgY3VzdG9taXphdGlvbiBpdGVtcy4uLmRvbmUiKQogICAobWVzc2FnZSAiQ3JlYXRp bmcgY3VzdG9taXphdGlvbiBzZXR1cC4uLiIpCiAgICh3aWRnZXQtc2V0dXApCiAgIChidWZmZXIt ZW5hYmxlLXVuZG8pCi0tIAoyLjIxLjAKCg== --0000000000000b5784058d601477--