* bug#52669: 29.0.50; build failure: ‘Qsqlitep’ undeclared
@ 2021-12-19 21:18 Sam Steingold
2021-12-19 21:27 ` Lars Ingebrigtsen
0 siblings, 1 reply; 13+ messages in thread
From: Sam Steingold @ 2021-12-19 21:18 UTC (permalink / raw)
To: 52669
just did `git pull`.
Build failure:
--8<---------------cut here---------------start------------->8---
CC dispnew.o
In file included from ../../src/dispnew.c:27:
../../src/lisp.h: In function ‘CHECK_SQLITE’:
../../src/lisp.h:2677:27: error: ‘Qsqlitep’ undeclared (first use in this function); did you mean ‘Qslice’?
2677 | CHECK_TYPE (SQLITE (x), Qsqlitep, x);
| ^~~~~~~~
| Qslice
../../src/lisp.h:2677:27: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [Makefile:411: dispnew.o] Error 1
make[1]: Leaving directory '/home/sds/src/emacs/trunk/build/src'
make: *** [Makefile:463: src] Error 2
--8<---------------cut here---------------end--------------->8---
config summary:
--8<---------------cut here---------------start------------->8---
Configured for 'x86_64-pc-linux-gnu'.
Where should the build process find the source code? ..
What compiler should emacs be built with? gcc -g3 -O2
Should Emacs use the GNU version of malloc? no
(The GNU allocators don't work with this system configuration.)
Should Emacs use a relocating allocator for buffers? no
Should Emacs use mmap(2) for buffer allocation? no
What window system should Emacs use? x11
What toolkit should Emacs use? GTK3
Where do we find X Windows header files? Standard dirs
Where do we find X Windows libraries? Standard dirs
Does Emacs use -lXaw3d? no
Does Emacs use -lXpm? yes
Does Emacs use -ljpeg? yes
Does Emacs use -ltiff? yes
Does Emacs use a gif library? yes -lgif
Does Emacs use a png library? yes -lpng16 -lz
Does Emacs use -lrsvg-2? yes
Does Emacs use -lwebp? no
Does Emacs use -lsqlite3? yes
Does Emacs use cairo? yes
Does Emacs use -llcms2? yes
Does Emacs use imagemagick? yes
Does Emacs use native APIs for images? no
Does Emacs support sound? yes
Does Emacs use -lgpm? no
Does Emacs use -ldbus? yes
Does Emacs use -lgconf? no
Does Emacs use GSettings? yes
Does Emacs use a file notification library? yes -lglibc (inotify)
Does Emacs use access control lists? no
Does Emacs use -lselinux? yes
Does Emacs use -lgnutls? yes
Does Emacs use -lxml2? yes
Does Emacs use -lfreetype? yes
Does Emacs use HarfBuzz? yes
Does Emacs use -lm17n-flt? no
Does Emacs use -lotf? no
Does Emacs use -lxft? no
Does Emacs use -lsystemd? no
Does Emacs use -ljansson? yes
Does Emacs use the GMP library? yes
Does Emacs directly use zlib? yes
Does Emacs have dynamic modules support? yes
Does Emacs use toolkit scroll bars? yes
Does Emacs support Xwidgets? no
Does Emacs have threading support in lisp? yes
Does Emacs support the portable dumper? yes
Does Emacs support legacy unexec dumping? no
Which dumping strategy does Emacs use? pdumper
Does Emacs have native lisp compiler? yes
Does Emacs use version 2 of the the X Input Extension? no
--8<---------------cut here---------------end--------------->8---
In GNU Emacs 29.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.25, cairo version 1.16.0)
of 2021-12-07 built on darter
Repository revision: beed398eb5e49680b731aeacd553d357759043c1
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12013000
System Description: Pop!_OS 21.10
Configured using:
'configure --with-imagemagick --with-mailutils'
Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ IMAGEMAGICK
JPEG JSON LCMS2 LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG
RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM
GTK3 ZLIB
Important settings:
value of $LC_COLLATE: C
value of $LANG: C
value of $XMODIFIERS: @im=ibus
locale-coding-system: utf-8-unix
--
Sam Steingold (http://sds.podval.org/) on Pop 21.04 (hirsute) X 11.0.12013000
http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com
https://ij.org/ http://think-israel.org https://honestreporting.com
The plural of "anecdote" is not "data".
^ permalink raw reply [flat|nested] 13+ messages in thread* bug#52669: 29.0.50; build failure: ‘Qsqlitep’ undeclared
2021-12-19 21:18 bug#52669: 29.0.50; build failure: ‘Qsqlitep’ undeclared Sam Steingold
@ 2021-12-19 21:27 ` Lars Ingebrigtsen
2021-12-20 3:31 ` Sam Steingold
0 siblings, 1 reply; 13+ messages in thread
From: Lars Ingebrigtsen @ 2021-12-19 21:27 UTC (permalink / raw)
To: Sam Steingold; +Cc: 52669
Sam Steingold <sds@gnu.org> writes:
> just did `git pull`.
> Build failure:
>
> CC dispnew.o
> In file included from ../../src/dispnew.c:27:
> ../../src/lisp.h: In function ‘CHECK_SQLITE’:
> ../../src/lisp.h:2677:27: error: ‘Qsqlitep’ undeclared (first use in this function); did you mean ‘Qslice’?
> 2677 | CHECK_TYPE (SQLITE (x), Qsqlitep, x);
> | ^~~~~~~~
> | Qslice
> ../../src/lisp.h:2677:27: note: each undeclared identifier is reported only once for each function it appears in
> make[1]: *** [Makefile:411: dispnew.o] Error 1
> make[1]: Leaving directory '/home/sds/src/emacs/trunk/build/src'
> make: *** [Makefile:463: src] Error 2
>
> config summary:
>
> Configured for 'x86_64-pc-linux-gnu'.
I can't reproduce this. Does it happen after a "make bootstrap", too?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#52669: 29.0.50; build failure: ‘Qsqlitep’ undeclared
2021-12-19 21:27 ` Lars Ingebrigtsen
@ 2021-12-20 3:31 ` Sam Steingold
2021-12-20 6:59 ` Stefan Kangas
0 siblings, 1 reply; 13+ messages in thread
From: Sam Steingold @ 2021-12-20 3:31 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 52669
Yes, it does.
today the configure was regenerated (because configure.in changed) and
I got the same error.
On Sun, 19 Dec 2021 at 16:27, Lars Ingebrigtsen <larsi@gnus.org> wrote:
>
> Sam Steingold <sds@gnu.org> writes:
>
> > just did `git pull`.
> > Build failure:
> >
> > CC dispnew.o
> > In file included from ../../src/dispnew.c:27:
> > ../../src/lisp.h: In function ‘CHECK_SQLITE’:
> > ../../src/lisp.h:2677:27: error: ‘Qsqlitep’ undeclared (first use in this function); did you mean ‘Qslice’?
> > 2677 | CHECK_TYPE (SQLITE (x), Qsqlitep, x);
> > | ^~~~~~~~
> > | Qslice
> > ../../src/lisp.h:2677:27: note: each undeclared identifier is reported only once for each function it appears in
> > make[1]: *** [Makefile:411: dispnew.o] Error 1
> > make[1]: Leaving directory '/home/sds/src/emacs/trunk/build/src'
> > make: *** [Makefile:463: src] Error 2
> >
> > config summary:
> >
> > Configured for 'x86_64-pc-linux-gnu'.
>
> I can't reproduce this. Does it happen after a "make bootstrap", too?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
> bloggy blog: http://lars.ingebrigtsen.no
--
Sam Steingold <http://sds.podval.org> <http://www.childpsy.net>
<http://steingoldpsychology.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#52669: 29.0.50; build failure: ‘Qsqlitep’ undeclared
2021-12-20 3:31 ` Sam Steingold
@ 2021-12-20 6:59 ` Stefan Kangas
2021-12-20 14:53 ` Sam Steingold
0 siblings, 1 reply; 13+ messages in thread
From: Stefan Kangas @ 2021-12-20 6:59 UTC (permalink / raw)
To: Sam Steingold; +Cc: 52669, Lars Ingebrigtsen
Sam Steingold <sds@gnu.org> writes:
> Yes, it does.
> today the configure was regenerated (because configure.in changed) and
> I got the same error.
How about "make distclean && make bootstrap"?
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#52669: 29.0.50; build failure: ‘Qsqlitep’ undeclared
2021-12-20 6:59 ` Stefan Kangas
@ 2021-12-20 14:53 ` Sam Steingold
2021-12-20 16:45 ` Eli Zaretskii
0 siblings, 1 reply; 13+ messages in thread
From: Sam Steingold @ 2021-12-20 14:53 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 52669, Lars Ingebrigtsen
I build in a separate directory.
I just did
rm -rf build
mkdir build
cd build
../configure --with-imagemagick --with-mailutils --with-native-compilation
make bootstrap
and got
make[2]: Entering directory '/home/sds/src/emacs/trunk/build/src'
GEN globals.h
CC dispnew.o
In file included from ../../src/dispnew.c:27:
../../src/lisp.h: In function ‘CHECK_SQLITE’:
../../src/lisp.h:2677:27: error: ‘Qsqlitep’ undeclared (first use in
this function); did you mean ‘Qslice’?
2677 | CHECK_TYPE (SQLITE (x), Qsqlitep, x);
| ^~~~~~~~
| Qslice
../../src/lisp.h:2677:27: note: each undeclared identifier is reported
only once for each function it appears in
make[2]: *** [Makefile:411: dispnew.o] Error 1
make[2]: Leaving directory '/home/sds/src/emacs/trunk/build/src'
make[1]: *** [Makefile:463: src] Error 2
make[1]: Leaving directory '/home/sds/src/emacs/trunk/build'
make: *** [Makefile:1173: bootstrap] Error 2
On Mon, 20 Dec 2021 at 01:59, Stefan Kangas <stefan@marxist.se> wrote:
>
> Sam Steingold <sds@gnu.org> writes:
>
> > Yes, it does.
> > today the configure was regenerated (because configure.in changed) and
> > I got the same error.
>
> How about "make distclean && make bootstrap"?
--
Sam Steingold <http://sds.podval.org> <http://www.childpsy.net>
<http://steingoldpsychology.com>
^ permalink raw reply [flat|nested] 13+ messages in thread* bug#52669: 29.0.50; build failure: ‘Qsqlitep’ undeclared
2021-12-20 14:53 ` Sam Steingold
@ 2021-12-20 16:45 ` Eli Zaretskii
2021-12-20 17:36 ` Sam Steingold
0 siblings, 1 reply; 13+ messages in thread
From: Eli Zaretskii @ 2021-12-20 16:45 UTC (permalink / raw)
To: Sam Steingold; +Cc: 52669, larsi, stefan
> From: Sam Steingold <sds@gnu.org>
> Date: Mon, 20 Dec 2021 09:53:42 -0500
> Cc: 52669@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
>
> I build in a separate directory.
> I just did
>
> rm -rf build
> mkdir build
> cd build
> ../configure --with-imagemagick --with-mailutils --with-native-compilation
> make bootstrap
>
> and got
>
> make[2]: Entering directory '/home/sds/src/emacs/trunk/build/src'
> GEN globals.h
> CC dispnew.o
> In file included from ../../src/dispnew.c:27:
> ../../src/lisp.h: In function ‘CHECK_SQLITE’:
> ../../src/lisp.h:2677:27: error: ‘Qsqlitep’ undeclared (first use in
> this function); did you mean ‘Qslice’?
> 2677 | CHECK_TYPE (SQLITE (x), Qsqlitep, x);
> | ^~~~~~~~
> | Qslice
Qsqlitep is defined in globals.h, and lisp.h includes globals.h on
line 957, way before line 2677. So I don't think I understand how
this could happen. Does your globals.h include the #define for
Qsqlitep? If not, I think maybe make-docfile produces a corrupt
globals.h or something?
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#52669: 29.0.50; build failure: ‘Qsqlitep’ undeclared
2021-12-20 16:45 ` Eli Zaretskii
@ 2021-12-20 17:36 ` Sam Steingold
2021-12-20 18:46 ` Ken Brown
0 siblings, 1 reply; 13+ messages in thread
From: Sam Steingold @ 2021-12-20 17:36 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 52669, larsi, stefan
> * Eli Zaretskii <ryvm@tah.bet> [2021-12-20 18:45:42 +0200]:
>
>> From: Sam Steingold <sds@gnu.org>
>> Date: Mon, 20 Dec 2021 09:53:42 -0500
>> Cc: 52669@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
>>
>> I build in a separate directory.
>> I just did
>>
>> rm -rf build
>> mkdir build
>> cd build
>> ../configure --with-imagemagick --with-mailutils --with-native-compilation
>> make bootstrap
>>
>> and got
>>
>> make[2]: Entering directory '/home/sds/src/emacs/trunk/build/src'
>> GEN globals.h
>> CC dispnew.o
>> In file included from ../../src/dispnew.c:27:
>> ../../src/lisp.h: In function ‘CHECK_SQLITE’:
>> ../../src/lisp.h:2677:27: error: ‘Qsqlitep’ undeclared (first use in
>> this function); did you mean ‘Qslice’?
>> 2677 | CHECK_TYPE (SQLITE (x), Qsqlitep, x);
>> | ^~~~~~~~
>> | Qslice
>
> Qsqlitep is defined in globals.h, and lisp.h includes globals.h on
> line 957, way before line 2677.
Indeed.
> Does your globals.h include the #define for Qsqlitep?
--8<---------------cut here---------------start------------->8---
3 matches for "Qsqlitep" in buffer: globals.h
3618:#define iQsqlitep 1180
3619:DEFINE_LISP_SYMBOL (Qsqlitep)
8109:# define Qsqlitep builtin_lisp_symbol (1180)
--8<---------------cut here---------------end--------------->8---
> So I don't think I understand how this could happen.
me neither.
I tried to investigate this before submitting the bug...
However, I think I know what the problem is!
There are *TWO* `global.h` files:
--8<---------------cut here---------------start------------->8---
/home/sds/src/emacs/trunk/:
find . \( -name globals.h \) -ls
6816176 288 -rw-rw-r-- 1 sds sds 293174 Dec 20 09:47 build/src/globals.h
1323655 288 -rw-rw-r-- 1 sds sds 291248 Dec 7 14:25 src/globals.h
find finished at Mon Dec 20 12:30:42
--8<---------------cut here---------------end--------------->8---
and since lisp.h includes "globals.h" instead of <globals.h>, it finds
the *SECOND* one, not the *FIRST* one.
I will push the fix shortly.
Thank you!
--
Sam Steingold (http://sds.podval.org/) on Pop 21.04 (hirsute) X 11.0.12013000
http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com
http://think-israel.org https://mideasttruth.com https://memri.org
Democracy is when the Public elects its Servants, not Masters.
^ permalink raw reply [flat|nested] 13+ messages in thread* bug#52669: 29.0.50; build failure: ‘Qsqlitep’ undeclared
2021-12-20 17:36 ` Sam Steingold
@ 2021-12-20 18:46 ` Ken Brown
2021-12-20 22:21 ` Glenn Morris
0 siblings, 1 reply; 13+ messages in thread
From: Ken Brown @ 2021-12-20 18:46 UTC (permalink / raw)
To: sds, Eli Zaretskii; +Cc: 52669, larsi, stefan
On 12/20/2021 12:36 PM, Sam Steingold wrote:
> However, I think I know what the problem is!
>
> There are *TWO* `global.h` files:
>
> --8<---------------cut here---------------start------------->8---
> /home/sds/src/emacs/trunk/:
> find . \( -name globals.h \) -ls
> 6816176 288 -rw-rw-r-- 1 sds sds 293174 Dec 20 09:47 build/src/globals.h
> 1323655 288 -rw-rw-r-- 1 sds sds 291248 Dec 7 14:25 src/globals.h
The second one doesn't exist in a clean source tree.
Ken
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#52669: 29.0.50; build failure: ‘Qsqlitep’ undeclared
2021-12-20 18:46 ` Ken Brown
@ 2021-12-20 22:21 ` Glenn Morris
2021-12-20 22:42 ` Sam Steingold
0 siblings, 1 reply; 13+ messages in thread
From: Glenn Morris @ 2021-12-20 22:21 UTC (permalink / raw)
To: Ken Brown; +Cc: 52669, sds, stefan, larsi
Ken Brown wrote:
> The second one doesn't exist in a clean source tree.
Indeed. I think attempting an out-of-tree build without first
(dist)cleaning up any previous in-tree build is a user-error.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#52669: 29.0.50; build failure: ‘Qsqlitep’ undeclared
2021-12-20 22:21 ` Glenn Morris
@ 2021-12-20 22:42 ` Sam Steingold
2021-12-20 23:07 ` Ken Brown
0 siblings, 1 reply; 13+ messages in thread
From: Sam Steingold @ 2021-12-20 22:42 UTC (permalink / raw)
To: Glenn Morris; +Cc: 52669, stefan, larsi
> * Glenn Morris <etz@tah.bet> [2021-12-20 17:21:43 -0500]:
>
> Ken Brown wrote:
>
>> The second one doesn't exist in a clean source tree.
>
> Indeed. I think attempting an out-of-tree build without first
> (dist)cleaning up any previous in-tree build is a user-error.
I am not sure I agree with this.
While I never build in-tree (except accidentally), I see no reason why
in-tree and out-of-tree builds should not be able to co-exist.
--
Sam Steingold (http://sds.podval.org/) on Pop 21.10 (impish) X 11.0.12013000
http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com
https://camera.org https://mideasttruth.com https://thereligionofpeace.com
Trespassers will be shot. Survivors will be SHOT AGAIN!
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#52669: 29.0.50; build failure: ‘Qsqlitep’ undeclared
2021-12-20 22:42 ` Sam Steingold
@ 2021-12-20 23:07 ` Ken Brown
2021-12-21 10:33 ` Stefan Kangas
0 siblings, 1 reply; 13+ messages in thread
From: Ken Brown @ 2021-12-20 23:07 UTC (permalink / raw)
To: sds, Glenn Morris; +Cc: 52669, stefan, larsi
On 12/20/2021 5:42 PM, Sam Steingold wrote:
>> * Glenn Morris <etz@tah.bet> [2021-12-20 17:21:43 -0500]:
>>
>> Ken Brown wrote:
>>
>>> The second one doesn't exist in a clean source tree.
>>
>> Indeed. I think attempting an out-of-tree build without first
>> (dist)cleaning up any previous in-tree build is a user-error.
>
> I am not sure I agree with this.
> While I never build in-tree (except accidentally), I see no reason why
> in-tree and out-of-tree builds should not be able to co-exist.
They should be able to co-exist only if the build system is designed to allow
it. This strikes me as an unnecessary maintenance burden. I think it's more
reasonable to expect people to make sure they're building from a clean source
tree when they get unexpected build errors.
Ken
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#52669: 29.0.50; build failure: ‘Qsqlitep’ undeclared
2021-12-20 23:07 ` Ken Brown
@ 2021-12-21 10:33 ` Stefan Kangas
2021-12-23 21:23 ` Ken Brown
0 siblings, 1 reply; 13+ messages in thread
From: Stefan Kangas @ 2021-12-21 10:33 UTC (permalink / raw)
To: Ken Brown; +Cc: Glenn Morris, sds, larsi, 52669
Ken Brown <kbrown@cornell.edu> writes:
> They should be able to co-exist only if the build system is designed to allow
> it. This strikes me as an unnecessary maintenance burden. I think it's more
> reasonable to expect people to make sure they're building from a clean source
> tree when they get unexpected build errors.
Indeed. So I guess this bug can be closed?
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#52669: 29.0.50; build failure: ‘Qsqlitep’ undeclared
2021-12-21 10:33 ` Stefan Kangas
@ 2021-12-23 21:23 ` Ken Brown
0 siblings, 0 replies; 13+ messages in thread
From: Ken Brown @ 2021-12-23 21:23 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Glenn Morris, 52669-done, larsi, sds
On 12/21/2021 5:33 AM, Stefan Kangas wrote:
> Ken Brown <kbrown@cornell.edu> writes:
>
>> They should be able to co-exist only if the build system is designed to allow
>> it. This strikes me as an unnecessary maintenance burden. I think it's more
>> reasonable to expect people to make sure they're building from a clean source
>> tree when they get unexpected build errors.
>
> Indeed. So I guess this bug can be closed?
Closing.
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2021-12-23 21:23 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-19 21:18 bug#52669: 29.0.50; build failure: ‘Qsqlitep’ undeclared Sam Steingold
2021-12-19 21:27 ` Lars Ingebrigtsen
2021-12-20 3:31 ` Sam Steingold
2021-12-20 6:59 ` Stefan Kangas
2021-12-20 14:53 ` Sam Steingold
2021-12-20 16:45 ` Eli Zaretskii
2021-12-20 17:36 ` Sam Steingold
2021-12-20 18:46 ` Ken Brown
2021-12-20 22:21 ` Glenn Morris
2021-12-20 22:42 ` Sam Steingold
2021-12-20 23:07 ` Ken Brown
2021-12-21 10:33 ` Stefan Kangas
2021-12-23 21:23 ` Ken Brown
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).