* bug#23063: 24.5; Multi-line sql statements are not saved correctly
@ 2016-03-19 15:10 Nikolay Kudryavtsev
2020-05-03 1:17 ` Stefan Kangas
0 siblings, 1 reply; 3+ messages in thread
From: Nikolay Kudryavtsev @ 2016-03-19 15:10 UTC (permalink / raw)
To: 23063
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
Currently comint.el does not respect local values of
comint-input-ring-separator. Sql mode on the other hand sets it locally.
This prevents multi-line sql history from working.
Sql history is stored using comint-write-input-ring. When it saves the
history file, it uses with-current-buffer, thus ignoring previous local
value. When read comint-read-input-ring uses with-temp-buffer with
similar results.
This seems to have been caused by the fix for this bug
<http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16814>.
--
Best Regards,
Nikolay Kudryavtsev
[-- Attachment #2: Type: text/html, Size: 837 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#23063: 24.5; Multi-line sql statements are not saved correctly
2016-03-19 15:10 bug#23063: 24.5; Multi-line sql statements are not saved correctly Nikolay Kudryavtsev
@ 2020-05-03 1:17 ` Stefan Kangas
2020-08-12 3:23 ` Stefan Kangas
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Kangas @ 2020-05-03 1:17 UTC (permalink / raw)
To: Michael Mauger; +Cc: 23063, Nikolay Kudryavtsev
Hi Michael,
Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com> writes:
> Currently comint.el does not respect local values of comint-input-ring-separator. Sql mode on the other hand sets it locally. This prevents multi-line sql history from working.
>
> Sql history is stored using comint-write-input-ring. When it saves the history file, it uses with-current-buffer, thus ignoring previous local value. When read comint-read-input-ring uses with-temp-buffer with similar results.
>
> This seems to have been caused by the fix for this bug.
This bug was tagged as "unreproducible moreinfo" in a message to
control@debbugs called "Close bugs" sent on 21 Apr 2019, but the bug
itself was never closed.
Should the bug be closed as well?
Thanks in advance.
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#23063: 24.5; Multi-line sql statements are not saved correctly
2020-05-03 1:17 ` Stefan Kangas
@ 2020-08-12 3:23 ` Stefan Kangas
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Kangas @ 2020-08-12 3:23 UTC (permalink / raw)
To: Michael Mauger; +Cc: Nikolay Kudryavtsev, 23063-done
Stefan Kangas <stefan@marxist.se> writes:
> Hi Michael,
>
> Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com> writes:
>
>> Currently comint.el does not respect local values of comint-input-ring-separator. Sql mode on the other hand sets it locally. This prevents multi-line sql history from working.
>>
>> Sql history is stored using comint-write-input-ring. When it saves the history file, it uses with-current-buffer, thus ignoring previous local value. When read comint-read-input-ring uses with-temp-buffer with similar results.
>>
>> This seems to have been caused by the fix for this bug.
>
> This bug was tagged as "unreproducible moreinfo" in a message to
> control@debbugs called "Close bugs" sent on 21 Apr 2019, but the bug
> itself was never closed.
>
> Should the bug be closed as well?
No reply here within 14 weeks. I'm going to assume the intention here
was to close this bug, so I'm doing that now.
If this conclusion is incorrect, please reply to this email (use "Reply
to all" in your email client) and we can reopen the bug report.
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-12 3:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-19 15:10 bug#23063: 24.5; Multi-line sql statements are not saved correctly Nikolay Kudryavtsev
2020-05-03 1:17 ` Stefan Kangas
2020-08-12 3:23 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).