From: Stefan Kangas <stefankangas@gmail.com>
To: Paul Pogonyshev <pogonyshev@gmail.com>
Cc: 41489@debbugs.gnu.org
Subject: bug#41489: `package-dir-info' fails on a directory with a non-saved file
Date: Tue, 26 May 2020 10:51:14 +0200 [thread overview]
Message-ID: <CADwFkmmLZr_-qS_SywqWd0kB=fK4Wnvd09HztufrAkJgDALZqA@mail.gmail.com> (raw)
In-Reply-To: <CAG7BpaosTeDdygKr5ibo+sVRKdo8p=TknEMxOm=K15Asyd-ftg@mail.gmail.com>
Paul Pogonyshev <pogonyshev@gmail.com> writes:
>> Do we really want to ignore *any* error from insert-file-contents here?
>
> Well, maybe that should be limited to `file-missing' instead (what actually
> happens when it tries to read a lock file).
Sounds good.
>> Should we really run package-buffer-info if inserting the file fails?
>> Won't that reach (error "Package lacks a file header") and signal an
>> error anyways, just a different and more cryptic one?
>
> `package-buffer-info' is already inside a different `ignore-errors', so it
> will signal an error, but that error will be ignored and the file skipped.
Thanks for clarifying. I didn't study this code recently.
> I'm not attached to any particular way this bug is fixed. Please adjust it
> yourself, the patch is only an example of how it could be done. This will
> be faster than if we try to negotiate the best way and recreate the patch.
I don't mean to discourage you from working on this, on the contrary.
We appreciate that you're working on a fix.
Best regards,
Stefan Kangas
next prev parent reply other threads:[~2020-05-26 8:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-23 17:50 bug#41489: `package-dir-info' fails on a directory with a non-saved file Paul Pogonyshev
2020-05-23 18:23 ` Eli Zaretskii
2020-05-23 18:37 ` Paul Pogonyshev
2020-05-25 22:55 ` Paul Pogonyshev
2020-05-26 2:07 ` Stefan Kangas
2020-05-26 6:54 ` Paul Pogonyshev
2020-05-26 8:51 ` Stefan Kangas [this message]
2021-12-05 1:13 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmmLZr_-qS_SywqWd0kB=fK4Wnvd09HztufrAkJgDALZqA@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=41489@debbugs.gnu.org \
--cc=pogonyshev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).