From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#41489: `package-dir-info' fails on a directory with a non-saved file Date: Tue, 26 May 2020 10:51:14 +0200 Message-ID: References: <83wo52y0h8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="32392"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41489@debbugs.gnu.org To: Paul Pogonyshev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 26 10:52:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jdVJl-0008Kk-0e for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 May 2020 10:52:13 +0200 Original-Received: from localhost ([::1]:42036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdVJk-00089q-3N for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 May 2020 04:52:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50850) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdVJa-00089i-Ft for bug-gnu-emacs@gnu.org; Tue, 26 May 2020 04:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60686) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdVJa-00045v-7F for bug-gnu-emacs@gnu.org; Tue, 26 May 2020 04:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jdVJa-00080x-5S for bug-gnu-emacs@gnu.org; Tue, 26 May 2020 04:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 May 2020 08:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41489 X-GNU-PR-Package: emacs Original-Received: via spool by 41489-submit@debbugs.gnu.org id=B41489.159048309330773 (code B ref 41489); Tue, 26 May 2020 08:52:02 +0000 Original-Received: (at 41489) by debbugs.gnu.org; 26 May 2020 08:51:33 +0000 Original-Received: from localhost ([127.0.0.1]:43999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdVJ7-00080H-1k for submit@debbugs.gnu.org; Tue, 26 May 2020 04:51:33 -0400 Original-Received: from mail-yb1-f173.google.com ([209.85.219.173]:33017) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdVJ5-000803-0x for 41489@debbugs.gnu.org; Tue, 26 May 2020 04:51:31 -0400 Original-Received: by mail-yb1-f173.google.com with SMTP id g79so9498442ybf.0 for <41489@debbugs.gnu.org>; Tue, 26 May 2020 01:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x8xWaiWJ4oQwDUMLP5RFosLKtV3eoqjHV6Yy83qIErY=; b=ZTboG6xM3dLl9nFgcLKXV30NZcjBiJRq3WVrlonCeI5P0lv5ssPldhe4conZTE+jEn wb6pw/EYtY/cBCSnvG/onlXu54AoEhW4kPT/Gk/itu0XEKcVYonKpaJ13K4KQz0x0m+8 WxaEyAhyGMzzwWIp9gFHuHctrRQ7AF/fP1cc0Ta3TFhfnWJUK/J3YmF3cEpOcSBAwOBi 1QcEUx1J5goTvEmhLfVK5kX+5ovsJgncQYqvtyztpTEFbxkuG/I8d4qtY8b5H2vMLQrJ hRz5rEhWllDs7Otde1A1uf1BNPMegn/iJEyQsRQhlDEPTNaw9kJTmLUG6C8KbTGPDE6z gF9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x8xWaiWJ4oQwDUMLP5RFosLKtV3eoqjHV6Yy83qIErY=; b=AwJpq8NtblU2PQjVlDqgwTwAYtxUH3JJFIIi6Tb0rSxc8rwbmdO4rcM9czg/xSxB1C sATDIJopE7hD/jLMsDQ/JdXobZAmT9vpzl3+4KM5cR+F6eJ247tWaGoLPCHd8pjorN5E kpVEB+GRS8t+hEESiaXqqksDu0SaZLkvdmtpnTHbZjzsJye3GU3UVadO+a9vZog+lYhO 3aldhc8uj1ReQxwHE2SVPgNguCFq9ryrfcN6EQj6fas65NtZ5zeGLJgPodIvvuWRy69E 57RR/oSRiipIvlPVSbe7AOCemFRc2CVhgwysODu30B9TkYcvCR3w2+tFdsCFS+jhiQ9M KW8A== X-Gm-Message-State: AOAM532t7JU4oFLvsnjVIcgO/wclo3pmCKcg3mEsvCPWSoa4YEJnbLpT lj88ZGneL7hFyQLQCGnSvjfCAY4LjzAbXMdU9AI= X-Google-Smtp-Source: ABdhPJyAQfyy0Z1Pk0dw4unZR6KxqW9cq8PevqIEWAO0Mb/crtom4kcjY6eS7gbJqPM2NgzR6dTen+aIkwEjk3psvNc= X-Received: by 2002:a25:5f52:: with SMTP id h18mr45792610ybm.231.1590483085164; Tue, 26 May 2020 01:51:25 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181027 Archived-At: Paul Pogonyshev writes: >> Do we really want to ignore *any* error from insert-file-contents here? > > Well, maybe that should be limited to `file-missing' instead (what actually > happens when it tries to read a lock file). Sounds good. >> Should we really run package-buffer-info if inserting the file fails? >> Won't that reach (error "Package lacks a file header") and signal an >> error anyways, just a different and more cryptic one? > > `package-buffer-info' is already inside a different `ignore-errors', so it > will signal an error, but that error will be ignored and the file skipped. Thanks for clarifying. I didn't study this code recently. > I'm not attached to any particular way this bug is fixed. Please adjust it > yourself, the patch is only an example of how it could be done. This will > be faster than if we try to negotiate the best way and recreate the patch. I don't mean to discourage you from working on this, on the contrary. We appreciate that you're working on a fix. Best regards, Stefan Kangas