From: Stefan Kangas <stefan@marxist.se>
To: Philip Kaludercic <philipk@posteo.net>
Cc: 47879@debbugs.gnu.org
Subject: bug#47879: [PATCH] Ignore mode hooks when analysing diffs
Date: Wed, 21 Apr 2021 09:12:45 -0500 [thread overview]
Message-ID: <CADwFkmmCKwRSpN7A377-cC2Wyq3Pe+LwO-npXc0=xkfY-Komag@mail.gmail.com> (raw)
In-Reply-To: <87o8ebz77g.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 18 Apr 2021 20:08:35 +0000")
Philip Kaludercic <philipk@posteo.net> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Philip Kaludercic <philipk@posteo.net>
>>> Date: Sun, 18 Apr 2021 19:08:01 +0000
>>>
>>> This fixes a bug related to log-edit-generate-changelog-from-diff.
>>>
>>> When I tried to invoke this command in a commit buffer, the error
>>>
>>> signal: Unmatched bracket or quote
>>>
>>> was raised. The reason was that I added paredit-mode to
>>> emacs-lisp-mode-hook, that when invoked calls check-parens. This raises
>>> an error when the diff contains a partial s-expression, which is almost
>>> always the case.
>>>
>>> The least invasive approach I could come up with was to defer the mode
>>> hooks.
>>
>> I rather think that the bug is either in the hook you added or in
>> paredit-mode, and should be solved there.
>
> Ok, I'll try that too.
So is this a notabug or a wontfix, or is there more to do here?
next prev parent reply other threads:[~2021-04-21 14:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 19:08 bug#47879: [PATCH] Ignore mode hooks when analysing diffs Philip Kaludercic
2021-04-18 19:25 ` Eli Zaretskii
2021-04-18 20:08 ` Philip Kaludercic
2021-04-21 14:12 ` Stefan Kangas [this message]
2021-04-21 14:23 ` Eli Zaretskii
2021-04-21 14:36 ` Philip Kaludercic
2021-04-21 14:45 ` Stefan Kangas
2021-04-21 14:52 ` Philip Kaludercic
2021-05-03 10:28 ` Lars Ingebrigtsen
2021-04-18 20:18 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmmCKwRSpN7A377-cC2Wyq3Pe+LwO-npXc0=xkfY-Komag@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=47879@debbugs.gnu.org \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).