From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#47879: [PATCH] Ignore mode hooks when analysing diffs Date: Wed, 21 Apr 2021 09:12:45 -0500 Message-ID: References: <878s5fpg1a.fsf@posteo.net> <837dkztmy0.fsf@gnu.org> <87o8ebz77g.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34241"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47879@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 21 16:13:40 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lZDbl-0008ol-Ur for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Apr 2021 16:13:37 +0200 Original-Received: from localhost ([::1]:48784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZDbk-0006jf-Ub for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Apr 2021 10:13:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZDbC-0006Dr-Cy for bug-gnu-emacs@gnu.org; Wed, 21 Apr 2021 10:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47762) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZDbC-0004zu-4m for bug-gnu-emacs@gnu.org; Wed, 21 Apr 2021 10:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lZDbC-0002Vm-0i for bug-gnu-emacs@gnu.org; Wed, 21 Apr 2021 10:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Apr 2021 14:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47879 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47879-submit@debbugs.gnu.org id=B47879.16190143759636 (code B ref 47879); Wed, 21 Apr 2021 14:13:01 +0000 Original-Received: (at 47879) by debbugs.gnu.org; 21 Apr 2021 14:12:55 +0000 Original-Received: from localhost ([127.0.0.1]:59307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZDb5-0002VM-JC for submit@debbugs.gnu.org; Wed, 21 Apr 2021 10:12:55 -0400 Original-Received: from mail-pf1-f174.google.com ([209.85.210.174]:36673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZDb1-0002V6-FG for 47879@debbugs.gnu.org; Wed, 21 Apr 2021 10:12:54 -0400 Original-Received: by mail-pf1-f174.google.com with SMTP id c3so10159355pfo.3 for <47879@debbugs.gnu.org>; Wed, 21 Apr 2021 07:12:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=PHaCeyenDBtJur/KXiu3lzC4uWakqttsCMPp+Bklk6Q=; b=BTg9tEwhVItL8lSMYYmAyRKisfgmil0T92E6PUFvvAUufWV6SAr13KBm8eiprJwVxj dQsErkWBXe2jImK5FALdArviXyLsLMa17jfx0Yq6WiY20iHqN0UuUPcK4F3ykIeGUKdV vdp4GE40LAb5tIoL5k382jHdyrkVv5LJkIkIp7eLZ2bbU7EwdgCC2MuivyPvC93v8A6n 9NQbuqWGoPDEBF5SGizB5Wyog6cIf/K//+sRKCIxbvS03RjDYRHh60ANklAo2R4RtGAB Lx/UF9YsvAGiyYnW2keBr9qSc1mVwyGv6wrpbgOSBLZRftQo5kkxK7qDjzR1vbH8rwLm 6s3A== X-Gm-Message-State: AOAM532NwQGmCO68nxFr/zB8I4YaB6N4rzDawo6Gny9uVjFgTagpcowL exWXY6T244n7TvtBXdNloSe5MViFNLKsq06bwHo= X-Google-Smtp-Source: ABdhPJx1voSJLBMBd86x0bp5AxcoaJGth2V3T605sIGYy82KuY4Uzv+FUIrW0FSaoSvJNJmxGw8cY1nqd3E8chiqdJM= X-Received: by 2002:a17:90b:19ca:: with SMTP id nm10mr11544835pjb.175.1619014365791; Wed, 21 Apr 2021 07:12:45 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 21 Apr 2021 09:12:45 -0500 In-Reply-To: <87o8ebz77g.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 18 Apr 2021 20:08:35 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204613 Archived-At: Philip Kaludercic writes: > Eli Zaretskii writes: > >>> From: Philip Kaludercic >>> Date: Sun, 18 Apr 2021 19:08:01 +0000 >>> >>> This fixes a bug related to log-edit-generate-changelog-from-diff. >>> >>> When I tried to invoke this command in a commit buffer, the error >>> >>> signal: Unmatched bracket or quote >>> >>> was raised. The reason was that I added paredit-mode to >>> emacs-lisp-mode-hook, that when invoked calls check-parens. This raises >>> an error when the diff contains a partial s-expression, which is almost >>> always the case. >>> >>> The least invasive approach I could come up with was to defer the mode >>> hooks. >> >> I rather think that the bug is either in the hook you added or in >> paredit-mode, and should be solved there. > > Ok, I'll try that too. So is this a notabug or a wontfix, or is there more to do here?