From: Stefan Kangas <stefankangas@gmail.com>
To: Gabriel <gabriel376@hotmail.com>
Cc: 59438@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#59438: 29.0.50; [PATCH] Make defvar's into defcustom's in tab-line
Date: Thu, 7 Sep 2023 14:07:08 -0700 [thread overview]
Message-ID: <CADwFkmm=kpLwEdQkM2SOKdjwUe0REEm83+Uet2X6ZY_FYjadWA@mail.gmail.com> (raw)
In-Reply-To: <CADwFkm=74_r2ddOw_ebexBG1PG2J_SGgDeZNfMMjyYTF5Rvxug@mail.gmail.com> (Stefan Kangas's message of "Thu, 24 Nov 2022 17:15:56 -0800")
Stefan Kangas <stefankangas@gmail.com> writes:
> Gabriel <gabriel376@hotmail.com> writes:
>
>> Please find attached a patch that proposes the following minor changes
>> to tab-line. I can refactor the patch if we decide that some change are
>> not worth or if it's better to split it into smaller patches.
>>
>> 1) Turn the following defvar's into defcustom's:
>>
>> - `tab-line-tabs-buffer-group-function'
>> - `tab-line-tabs-buffer-group-sort-function'
>> - `tab-line-tabs-buffer-groups-sort-function'
>>
>> 2) Add conditional around function call of
>> `tab-line-tabs-buffer-groups-sort-function', in
>> `tab-line-tabs-buffer-groups'. This guards against nil values, similar
>> to how `tab-line-tabs-buffer-group-sort-function is handled, making the
>> behavior more consistent across these two (similar) variables.
>>
>> Should we announce these "new" defcustom's in NEWS?
>
> Juri, thoughts?
Ping. Does anyone have any comments?
next prev parent reply other threads:[~2023-09-07 21:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 9:25 bug#59438: 29.0.50; [PATCH] Make defvar's into defcustom's in tab-line Gabriel
2022-11-25 1:15 ` Stefan Kangas
2023-09-07 21:07 ` Stefan Kangas [this message]
2023-09-08 10:43 ` Mauro Aranda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmm=kpLwEdQkM2SOKdjwUe0REEm83+Uet2X6ZY_FYjadWA@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=59438@debbugs.gnu.org \
--cc=gabriel376@hotmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).