From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59438: 29.0.50; [PATCH] Make defvar's into defcustom's in tab-line Date: Thu, 7 Sep 2023 14:07:08 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21058"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59438@debbugs.gnu.org, Juri Linkov To: Gabriel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 07 23:08:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeMEX-0005Hj-VV for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Sep 2023 23:08:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeMEL-00077h-Fg; Thu, 07 Sep 2023 17:08:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeMEK-00077Y-QT for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 17:08:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qeMEK-0004T9-IH for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 17:08:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qeMEM-0007gs-Ct for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 17:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Sep 2023 21:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59438 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59438-submit@debbugs.gnu.org id=B59438.169412083929509 (code B ref 59438); Thu, 07 Sep 2023 21:08:02 +0000 Original-Received: (at 59438) by debbugs.gnu.org; 7 Sep 2023 21:07:19 +0000 Original-Received: from localhost ([127.0.0.1]:41519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeMDf-0007ft-Ck for submit@debbugs.gnu.org; Thu, 07 Sep 2023 17:07:19 -0400 Original-Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]:58721) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeMDc-0007fd-R2 for 59438@debbugs.gnu.org; Thu, 07 Sep 2023 17:07:17 -0400 Original-Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-501bd7711e8so2433722e87.1 for <59438@debbugs.gnu.org>; Thu, 07 Sep 2023 14:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694120829; x=1694725629; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=vM0x687fy5RaKTKbRavxxrdTLuwCutn8czrcft0iu+0=; b=jJgXXF2/gyrpiy0ZCAXKT56f5eUZOdbWjUi2aad2P0abom9MnE9+sH54Hnu6XxLHll nlEYJX+ge72b4qOe/ElfeB8WvSPdIoXovY/peLMNwVknSyYq3zei0jZFCvKRJ9dGIsoB c2pNnM8TidSY8A9qt+8iikhhOe/Fkxdn21WCkyEMa1qlOrdRgFSBqf4K32wIQqpib0+h ziT2Pet0TVJ/iIbbvAvoPGTe3K84PPv8klWBDvwJrpr5m5Eu45Ruwrltydmiz18WOL9S v0qBCr8nMZqE1XzgcmdRgQfzoUBYu2ns9RPOZv+ji/phszWMxsxo9Mx3mIOi0OMcG+eG wzYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694120829; x=1694725629; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vM0x687fy5RaKTKbRavxxrdTLuwCutn8czrcft0iu+0=; b=a5pndOR58MZVcnsn4mjiXuzfr0RweiDkHAldANkjMt9uQgqFxjxz32pegR0DvG97Hv OfoufUZuwTz41O0TdDl2t+XuKib6KS4mE+HBBYgBfFeoAi9cZS/ApYOL/B7wp6psh6/H x4eM6dfW98YgcMt+VbTN2LZ5jty3BrnO0aGHAXwUZbRMUcL9kBRWnOvjzGeM6egENs+W ANRw0R7/xVj7tuWXe3B27/WSBm/8eWV5E/qG8S2FFe3OtqQ4xD1YpGV2sXLRtRpbhVSe Cvn25wS+Pm+cBGtNyJgKYoPZLOVu9MnihQK/Ch+Z1xc9sSi1JR+MoIgwB0GcmB82+07o /TCA== X-Gm-Message-State: AOJu0YwBXG/GTmA3Nf8H6IjxBQOyxRnKdYb2hCKP0f25Kd+MhHrA93sz JmzOuWKZMvnsxmIhoDTHHDuCoyonD0UAdXwJap8= X-Google-Smtp-Source: AGHT+IEHaVCtWwJ7g+f6q+OrYxpwFnBuWLbsAvr2QijYBW1JnvVvoI3Ib87huKNe/ACh6wESK3C0ANln0HYpSuYXQ70= X-Received: by 2002:a05:6512:3d8e:b0:500:8d17:1992 with SMTP id k14-20020a0565123d8e00b005008d171992mr493504lfv.22.1694120828791; Thu, 07 Sep 2023 14:07:08 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 7 Sep 2023 14:07:08 -0700 In-Reply-To: (Stefan Kangas's message of "Thu, 24 Nov 2022 17:15:56 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269699 Archived-At: Stefan Kangas writes: > Gabriel writes: > >> Please find attached a patch that proposes the following minor changes >> to tab-line. I can refactor the patch if we decide that some change are >> not worth or if it's better to split it into smaller patches. >> >> 1) Turn the following defvar's into defcustom's: >> >> - `tab-line-tabs-buffer-group-function' >> - `tab-line-tabs-buffer-group-sort-function' >> - `tab-line-tabs-buffer-groups-sort-function' >> >> 2) Add conditional around function call of >> `tab-line-tabs-buffer-groups-sort-function', in >> `tab-line-tabs-buffer-groups'. This guards against nil values, similar >> to how `tab-line-tabs-buffer-group-sort-function is handled, making the >> behavior more consistent across these two (similar) variables. >> >> Should we announce these "new" defcustom's in NEWS? > > Juri, thoughts? Ping. Does anyone have any comments?