From: Stefan Kangas <stefankangas@gmail.com>
To: Augusto Stoffel <arstoffel@gmail.com>, Eli Zaretskii <eliz@gnu.org>
Cc: 57884@debbugs.gnu.org
Subject: bug#57884: [PATCH] Flymake backend using the shellcheck program
Date: Sat, 17 Sep 2022 14:04:05 -0400 [thread overview]
Message-ID: <CADwFkmkrUWNN2TUxje6qYBjSHemFuziuDm4rcGADjzUGv91VaQ@mail.gmail.com> (raw)
In-Reply-To: <871qs9c3er.fsf@gmail.com>
Augusto Stoffel <arstoffel@gmail.com> writes:
> I could split this into two defcustoms if you feel strongly about it,
> but it seems a bit of overengineering to me. Not many people will want
> to customize the program name, and the switches would have to be
> provided as a list anyway, since we're not going to call this through a
> shell.
FWIW, I tend to agree, unless we can point to any other "shellcheck"
compatible programs out there. For now, the code assumes that's what
we're using, right?
> ++++
Should probably be "---" as you didn't add documentation for it.
> +*** New Flymake backend using the ShellCheck program
> +It is enable by default, only requiring that ShellCheck is installed.
> +See https://www.shellcheck.net/ for details.
(Typo: "enabled".)
I'd suggest:
It is enabled by default, but requires that the external "shellcheck"
command is installed.
> +;; A Flymake backend using the ShellCheck program is provided. See
> +;; https://www.shellcheck.net/ for installation instructions.
Maybe this should be "shellcheck" too? The capitalization is not
necessarily helpful for finding the correct package to install.
next prev parent reply other threads:[~2022-09-17 18:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 16:48 bug#57884: [PATCH] Flymake backend using the shellcheck program Augusto Stoffel
2022-09-17 17:05 ` Eli Zaretskii
2022-09-17 17:32 ` Augusto Stoffel
2022-09-17 17:52 ` Eli Zaretskii
2022-09-17 18:17 ` Stefan Kangas
2022-09-17 17:55 ` Eli Zaretskii
2022-09-17 18:04 ` Stefan Kangas [this message]
2022-09-18 7:52 ` Augusto Stoffel
2022-09-18 11:55 ` Philip Kaludercic
2022-09-18 12:38 ` Augusto Stoffel
2022-09-18 12:50 ` Philip Kaludercic
2022-09-18 13:30 ` Augusto Stoffel
2022-09-18 13:46 ` Philip Kaludercic
2022-09-18 19:38 ` Augusto Stoffel
2022-09-18 20:22 ` Philip Kaludercic
2022-09-18 21:18 ` Philip Kaludercic
2022-09-19 7:33 ` Augusto Stoffel
2022-09-19 8:03 ` Philip Kaludercic
2022-09-24 7:05 ` Augusto Stoffel
2022-09-24 8:01 ` Philip Kaludercic
2022-11-04 22:56 ` Philip Kaludercic
2022-09-18 11:58 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmkrUWNN2TUxje6qYBjSHemFuziuDm4rcGADjzUGv91VaQ@mail.gmail.com \
--to=stefankangas@gmail.com \
--cc=57884@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).