From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#57884: [PATCH] Flymake backend using the shellcheck program Date: Sat, 17 Sep 2022 14:04:05 -0400 Message-ID: References: <87a66yaqwc.fsf@gmail.com> <83bkre0w4m.fsf@gnu.org> <871qs9c3er.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17353"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57884@debbugs.gnu.org To: Augusto Stoffel , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 17 20:06:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZcCf-0004LF-VL for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Sep 2022 20:06:09 +0200 Original-Received: from localhost ([::1]:43200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZcCf-00025f-2Q for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Sep 2022 14:06:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZcBa-0000dP-LA for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 14:05:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48078) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZcBa-0007uE-D1 for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 14:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oZcBa-0008Qf-7e for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 14:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Sep 2022 18:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57884 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57884-submit@debbugs.gnu.org id=B57884.166343786032329 (code B ref 57884); Sat, 17 Sep 2022 18:05:02 +0000 Original-Received: (at 57884) by debbugs.gnu.org; 17 Sep 2022 18:04:20 +0000 Original-Received: from localhost ([127.0.0.1]:47152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZcAq-0008PJ-55 for submit@debbugs.gnu.org; Sat, 17 Sep 2022 14:04:20 -0400 Original-Received: from mail-oa1-f54.google.com ([209.85.160.54]:45734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZcAl-0008Oq-96 for 57884@debbugs.gnu.org; Sat, 17 Sep 2022 14:04:15 -0400 Original-Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-127dca21a7dso56486026fac.12 for <57884@debbugs.gnu.org>; Sat, 17 Sep 2022 11:04:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date; bh=+5fbzR7Iah/oElB0LftsvgwBvbgTFvgeKI4sPqH4Z64=; b=ZnTvUBlDECvtwoq3iW2yOxJqluj0PFN07QtluY75CsNpC1JS2wQY1Y6K9BKRJdcosf WiE/W+39HflUSBW+w1mNeFu3HraggUYH4ASW4Hev2OpdHM0UfvFV8qOuLZZAXQ3l/dyj w4e4Uc54DIYSyYKN33lMVndBb7PaP4VH+NCtzwM8ofXpnVrOFzieZ2ZCuYJPmLMDGJOc wodzNzoD5VR/W4jvWCKKweRdVJn12NavUkxrRb0BDOa2Cv2XOUn9wwUrs16qJrESAvm5 wn7PoHrLDP4RGjZoGvdrjfwV7kY7Z2C/fnKM8iEphFjUegjrqqlwCAVtTCOBjgkW+sa7 lyxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date; bh=+5fbzR7Iah/oElB0LftsvgwBvbgTFvgeKI4sPqH4Z64=; b=FET/jsaD2TzqgFB8LKWwNvFLjCOdMX+gqkbqclrnCsezxei0V1XrlEYkrtfgr8eB2c g4ny8xxYZnfQp75nJ3V0UlllLut652a1j6Xnqbo46KVOJtpa8kvA0sbBlxfX8bFcaxLs IQFPpbMyzED+R2FVkjBE+pMdIkSMMQK5uleMOhgMaKt7nyiyek5hd9pzb9Tb47IKPNZP P5aBDBkolhcKSnCqr2F2wibjHglrKMdcpCiGKZzXBh8Paj5UxYQOwlIEQRvQcC2RuSb+ qjg/RFEw7QzC9QYZ0kM/L42CkB5/xb7EC82rM+yaFXwn/jHZRlgVRt3gX9O+6DaNOomU apmw== X-Gm-Message-State: ACgBeo3fOwtj0gGHkmEaJKCk5r3w/oTKF+5dbEVLPCgf30zJZrcEt2p+ iOnpwL9QvXCr9Rbh0L4JvMHyhDkrshjzSlcZSy8= X-Google-Smtp-Source: AA6agR4i40HUdJC41azmeMj9jc2zNp1B80eRNQIwaFF/FqEOmTmzL2yWI52oyXI0UrHLezjCzONibz4VwYNeQs6P1vs= X-Received: by 2002:a05:6870:5581:b0:11e:300:8189 with SMTP id n1-20020a056870558100b0011e03008189mr11637645oao.199.1663437845819; Sat, 17 Sep 2022 11:04:05 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 17 Sep 2022 14:04:05 -0400 In-Reply-To: <871qs9c3er.fsf@gmail.com> X-Hashcash: 1:20:220917:57884@debbugs.gnu.org::d0SqYOp9OGzfOLmW:2fu/ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242901 Archived-At: Augusto Stoffel writes: > I could split this into two defcustoms if you feel strongly about it, > but it seems a bit of overengineering to me. Not many people will want > to customize the program name, and the switches would have to be > provided as a list anyway, since we're not going to call this through a > shell. FWIW, I tend to agree, unless we can point to any other "shellcheck" compatible programs out there. For now, the code assumes that's what we're using, right? > ++++ Should probably be "---" as you didn't add documentation for it. > +*** New Flymake backend using the ShellCheck program > +It is enable by default, only requiring that ShellCheck is installed. > +See https://www.shellcheck.net/ for details. (Typo: "enabled".) I'd suggest: It is enabled by default, but requires that the external "shellcheck" command is installed. > +;; A Flymake backend using the ShellCheck program is provided. See > +;; https://www.shellcheck.net/ for installation instructions. Maybe this should be "shellcheck" too? The capitalization is not necessarily helpful for finding the correct package to install.