* bug#66341: 30.0.50; pulse-flag :type doesn't allow never as a value
@ 2023-10-04 13:45 Mauro Aranda
2023-10-04 13:49 ` Mauro Aranda
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2023-10-04 13:45 UTC (permalink / raw)
To: 66341
Docstring of pulse-flag says the value can be the symbol never, but its
:type is just boolean.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#66341: 30.0.50; pulse-flag :type doesn't allow never as a value
2023-10-04 13:45 bug#66341: 30.0.50; pulse-flag :type doesn't allow never as a value Mauro Aranda
@ 2023-10-04 13:49 ` Mauro Aranda
2023-10-04 14:21 ` Stefan Kangas
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2023-10-04 13:49 UTC (permalink / raw)
To: 66341
[-- Attachment #1: Type: text/plain, Size: 39 bytes --]
tags 66341 patch
quit
Patch attached.
[-- Attachment #2: 0001-Fix-pulse-flag-type.patch --]
[-- Type: text/x-patch, Size: 917 bytes --]
From c1000126a21a324d7ed9ebc9b64fb7e48f9f7f03 Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Wed, 4 Oct 2023 10:47:51 -0300
Subject: [PATCH] Fix pulse-flag :type
* lisp/cedet/pulse.el (pulse-flag): Expand :type to allow 'never as
value. (Bug#66341)
---
lisp/cedet/pulse.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el
index 37b41fbe8c3..38ccf5b975f 100644
--- a/lisp/cedet/pulse.el
+++ b/lisp/cedet/pulse.el
@@ -71,7 +71,9 @@ pulse-flag
If `pulse-flag' is non-nil, but `pulse-available-p' is nil, then
this flag is ignored."
:group 'pulse
- :type 'boolean)
+ :type '(choice (const :tag "Highlight with unchanging color" nil)
+ (const :tag "No highlight" never)
+ (other :tag "Pulse" t)))
(defface pulse-highlight-start-face
'((((class color) (background dark))
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#66341: 30.0.50; pulse-flag :type doesn't allow never as a value
2023-10-04 13:49 ` Mauro Aranda
@ 2023-10-04 14:21 ` Stefan Kangas
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Kangas @ 2023-10-04 14:21 UTC (permalink / raw)
To: Mauro Aranda, 66341-done
Version: 29.2
Mauro Aranda <maurooaranda@gmail.com> writes:
> Patch attached.
Thanks, installed on emacs-29.
[1: 3216cd96952]: 2023-10-04 16:19:20 +0200
Fix pulse-flag :type
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3216cd96952c5fa0fbe665ef219210c9ebaf4e75
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-04 14:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-04 13:45 bug#66341: 30.0.50; pulse-flag :type doesn't allow never as a value Mauro Aranda
2023-10-04 13:49 ` Mauro Aranda
2023-10-04 14:21 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).