unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#44259: Most mml-sec.el tests are failing on macOS
@ 2020-10-27 18:16 Stefan Kangas
  2020-10-27 20:08 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2020-10-27 18:16 UTC (permalink / raw)
  To: 44259

Most mml-sec.el tests are failing on macOS.  Here is my analysis.

In mml-sec-tests.el, the cleanup in mml-sec-test--kill-gpg-agent
depends on the 'args key in the alist returned by process-attributes.
But evaluating following on macOS gives nil:

   (assq 'args (process-attributes (emacs-pid)))

Support for `args' seems to be not implemented on macOS.  See
src/sysdep.c, function system_process_attributes.

This was previously discussed in Bug#16579, where support for
process-attributes was first added. It seems like the API for all this
is not documented, so it's tricky to add.

    https://debbugs.gnu.org/cgi/bugreport.cgi?bug=16579#5

So I guess we either should make the tests not depend on 'args, or
figure out how to implement the above support for macOS.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#44259: Most mml-sec.el tests are failing on macOS
  2020-10-27 18:16 bug#44259: Most mml-sec.el tests are failing on macOS Stefan Kangas
@ 2020-10-27 20:08 ` Lars Ingebrigtsen
  2020-10-27 21:41   ` Stefan Kangas
  0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2020-10-27 20:08 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: 44259

Stefan Kangas <stefan@marxist.se> writes:

> So I guess we either should make the tests not depend on 'args, or
> figure out how to implement the above support for macOS.

Or we could just disable these tests on Macos...  I'm not sure these
test bring us that much of value.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#44259: Most mml-sec.el tests are failing on macOS
  2020-10-27 20:08 ` Lars Ingebrigtsen
@ 2020-10-27 21:41   ` Stefan Kangas
  2020-10-28 10:55     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2020-10-27 21:41 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 44259

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Stefan Kangas <stefan@marxist.se> writes:
>
>> So I guess we either should make the tests not depend on 'args, or
>> figure out how to implement the above support for macOS.
>
> Or we could just disable these tests on Macos...  I'm not sure these
> test bring us that much of value.

Works for me.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#44259: Most mml-sec.el tests are failing on macOS
  2020-10-27 21:41   ` Stefan Kangas
@ 2020-10-28 10:55     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2020-10-28 10:55 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: 44259

Stefan Kangas <stefan@marxist.se> writes:

>> Or we could just disable these tests on Macos...  I'm not sure these
>> test bring us that much of value.
>
> Works for me.

Done.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-10-28 10:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-27 18:16 bug#44259: Most mml-sec.el tests are failing on macOS Stefan Kangas
2020-10-27 20:08 ` Lars Ingebrigtsen
2020-10-27 21:41   ` Stefan Kangas
2020-10-28 10:55     ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).