* bug#23826: 25.1.50; Wrong fontification of parameter in c++-mode
@ 2016-06-22 15:35 Ivan Andrus
2019-10-03 4:18 ` Stefan Kangas
0 siblings, 1 reply; 5+ messages in thread
From: Ivan Andrus @ 2016-06-22 15:35 UTC (permalink / raw)
To: 23826
From `emacs -Q`, open a buffer in c++-mode and insert the following:
// X is fontified with font-lock-variable-face and x is not fontified
int foo(xml::XmlElement xml, X const& x )
{
return 0;
}
// Fontified correctly
int bar(XmlElement xml, X const& x )
{
return 1;
}
Notice that the namespace qualification of XmlElement causes the second
parameter to be incorrectly fontified (or so it appears).
-Ivan
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#23826: 25.1.50; Wrong fontification of parameter in c++-mode
2016-06-22 15:35 bug#23826: 25.1.50; Wrong fontification of parameter in c++-mode Ivan Andrus
@ 2019-10-03 4:18 ` Stefan Kangas
2019-10-04 3:02 ` Ivan Andrus
2019-10-04 3:15 ` Ivan Andrus
0 siblings, 2 replies; 5+ messages in thread
From: Stefan Kangas @ 2019-10-03 4:18 UTC (permalink / raw)
To: Ivan Andrus; +Cc: 23826
Ivan Andrus <darthandrus@gmail.com> writes:
>>From `emacs -Q`, open a buffer in c++-mode and insert the following:
>
> // X is fontified with font-lock-variable-face and x is not fontified
> int foo(xml::XmlElement xml, X const& x )
> {
> return 0;
> }
>
> // Fontified correctly
> int bar(XmlElement xml, X const& x )
> {
> return 1;
> }
>
>
> Notice that the namespace qualification of XmlElement causes the second
> parameter to be incorrectly fontified (or so it appears).
I can't reproduce this on current master: X has font-lock-type-face and
x font-lock-variable-name-face.
Are you still seeing this on a recent version of Emacs?
If I don't hear back from you within a couple of weeks, I'll just assume
that this has been fixed and close this as unreproducible.
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#23826: 25.1.50; Wrong fontification of parameter in c++-mode
2019-10-03 4:18 ` Stefan Kangas
@ 2019-10-04 3:02 ` Ivan Andrus
2019-10-04 4:54 ` Stefan Kangas
2019-10-04 3:15 ` Ivan Andrus
1 sibling, 1 reply; 5+ messages in thread
From: Ivan Andrus @ 2019-10-04 3:02 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 23826
On Oct 2, 2019, at 10:18 PM, Stefan Kangas <stefan@marxist.se> wrote:
>
> Ivan Andrus <darthandrus@gmail.com> writes:
>
>>> From `emacs -Q`, open a buffer in c++-mode and insert the following:
>>
>> // X is fontified with font-lock-variable-face and x is not fontified
>> int foo(xml::XmlElement xml, X const& x )
>> {
>> return 0;
>> }
>>
>> // Fontified correctly
>> int bar(XmlElement xml, X const& x )
>> {
>> return 1;
>> }
>>
>>
>> Notice that the namespace qualification of XmlElement causes the second
>> parameter to be incorrectly fontified (or so it appears).
>
> I can't reproduce this on current master: X has font-lock-type-face and
> x font-lock-variable-name-face.
>
> Are you still seeing this on a recent version of Emacs?
Indeed, this is working for me now.
> If I don't hear back from you within a couple of weeks, I'll just assume
> that this has been fixed and close this as unreproducible.
Thanks for following up.
-Ivan
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#23826: 25.1.50; Wrong fontification of parameter in c++-mode
2019-10-03 4:18 ` Stefan Kangas
2019-10-04 3:02 ` Ivan Andrus
@ 2019-10-04 3:15 ` Ivan Andrus
1 sibling, 0 replies; 5+ messages in thread
From: Ivan Andrus @ 2019-10-04 3:15 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 23826
On Oct 2, 2019, at 10:18 PM, Stefan Kangas <stefan@marxist.se> wrote:
>
> Ivan Andrus <darthandrus@gmail.com> writes:
>
>>> From `emacs -Q`, open a buffer in c++-mode and insert the following:
>>
>> // X is fontified with font-lock-variable-face and x is not fontified
>> int foo(xml::XmlElement xml, X const& x )
>> {
>> return 0;
>> }
>>
>> // Fontified correctly
>> int bar(XmlElement xml, X const& x )
>> {
>> return 1;
>> }
>>
>>
>> Notice that the namespace qualification of XmlElement causes the second
>> parameter to be incorrectly fontified (or so it appears).
>
> I can't reproduce this on current master: X has font-lock-type-face and
> x font-lock-variable-name-face.
>
> Are you still seeing this on a recent version of Emacs?
Indeed, this is working for me now.
> If I don't hear back from you within a couple of weeks, I'll just assume
> that this has been fixed and close this as unreproducible.
Thanks for following up.
-Ivan
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#23826: 25.1.50; Wrong fontification of parameter in c++-mode
2019-10-04 3:02 ` Ivan Andrus
@ 2019-10-04 4:54 ` Stefan Kangas
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Kangas @ 2019-10-04 4:54 UTC (permalink / raw)
To: Ivan Andrus; +Cc: 23826-done
Ivan Andrus <darthandrus@gmail.com> writes:
> > I can't reproduce this on current master: X has font-lock-type-face and
> > x font-lock-variable-name-face.
> >
> > Are you still seeing this on a recent version of Emacs?
>
> Indeed, this is working for me now.
Thanks for verifying. Closing this now.
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-04 4:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-22 15:35 bug#23826: 25.1.50; Wrong fontification of parameter in c++-mode Ivan Andrus
2019-10-03 4:18 ` Stefan Kangas
2019-10-04 3:02 ` Ivan Andrus
2019-10-04 4:54 ` Stefan Kangas
2019-10-04 3:15 ` Ivan Andrus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).