unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#56634: [PATCH] * eudc.texi: Unquote setopt option names
@ 2022-07-18 20:46 Philip Kaludercic
  2022-07-18 23:07 ` Stefan Kangas
  0 siblings, 1 reply; 3+ messages in thread
From: Philip Kaludercic @ 2022-07-18 20:46 UTC (permalink / raw)
  To: 56634

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

Tags: patch


Reading through the EUDC manual I noticed that the setopt examples
cannot be evaluated since the option names are quoted (as if passed to
`customize-set-variable').  The patch below fixes this.

From what I see this isn't been done anywhere else, so this patch should
fix the issue.

In GNU Emacs 29.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 2.24.33, cairo version 1.16.0)
 of 2022-07-14 built on icterid
Repository revision: 73054b61486b5ac6bfd96f6421a6f7dc1483fa5d
Repository branch: feature/package+vc
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux 11 (bullseye)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-eudc.texi-Unquote-setopt-option-names.patch --]
[-- Type: text/patch, Size: 1595 bytes --]

From 8cd55071e982f399079ca12cbaf35d07599ee33a Mon Sep 17 00:00:00 2001
From: Philip Kaludercic <philipk@posteo.net>
Date: Mon, 18 Jul 2022 22:44:52 +0200
Subject: [PATCH] * eudc.texi: Unquote setopt option names

---
 doc/misc/eudc.texi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/misc/eudc.texi b/doc/misc/eudc.texi
index 4c1adf3b0f..0037ba78d3 100644
--- a/doc/misc/eudc.texi
+++ b/doc/misc/eudc.texi
@@ -292,7 +292,7 @@ Emacs-only Configuration
 (setopt eudc-server-hotlist
         '(("" . bbdb)
           ("ldaps://ldap.gnu.org" . ldap)))
-(setopt 'ldap-host-parameters-alist
+(setopt ldap-host-parameters-alist
         '(("ldaps://ldap.gnu.org"
                   base "ou=people,dc=gnu,dc=org"
                   binddn "gnu\\emacsuser"
@@ -346,10 +346,10 @@ External Configuration
 @lisp
 (with-eval-after-load "message"
   (define-key message-mode-map (kbd "TAB") 'eudc-expand-try-all))
-(setopt 'eudc-server-hotlist
+(setopt eudc-server-hotlist
         '(("" . bbdb)
           ("ldaps://ldap.gnu.org" . ldap)))
-(setopt 'ldap-host-parameters-alist
+(setopt ldap-host-parameters-alist
         '(("ldaps://ldap.gnu.org"
                   auth-source t)))
 @end lisp
@@ -376,9 +376,9 @@ External Configuration
 @lisp
 (with-eval-after-load "message"
   (define-key message-mode-map (kbd "TAB") 'eudc-expand-try-all))
-(setopt 'eudc-server-hotlist
+(setopt eudc-server-hotlist
         '(("" . bbdb) ("" . ldap)))
-(setopt 'ldap-host-parameters-alist
+(setopt ldap-host-parameters-alist
         '(("" auth-source t)))
 @end lisp
 
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#56634: [PATCH] * eudc.texi: Unquote setopt option names
  2022-07-18 20:46 bug#56634: [PATCH] * eudc.texi: Unquote setopt option names Philip Kaludercic
@ 2022-07-18 23:07 ` Stefan Kangas
  2022-07-19 15:07   ` Thomas Fitzsimmons
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Kangas @ 2022-07-18 23:07 UTC (permalink / raw)
  To: Philip Kaludercic, 56634

Philip Kaludercic <philipk@posteo.net> writes:

> Reading through the EUDC manual I noticed that the setopt examples
> cannot be evaluated since the option names are quoted (as if passed to
> `customize-set-variable').  The patch below fixes this.

LGTM, please push.





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#56634: [PATCH] * eudc.texi: Unquote setopt option names
  2022-07-18 23:07 ` Stefan Kangas
@ 2022-07-19 15:07   ` Thomas Fitzsimmons
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Fitzsimmons @ 2022-07-19 15:07 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: 56634-done, Philip Kaludercic

Stefan Kangas <stefankangas@gmail.com> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>> Reading through the EUDC manual I noticed that the setopt examples
>> cannot be evaluated since the option names are quoted (as if passed to
>> `customize-set-variable').  The patch below fixes this.
>
> LGTM, please push.

Pushed, thanks.

Thomas





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-07-19 15:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-18 20:46 bug#56634: [PATCH] * eudc.texi: Unquote setopt option names Philip Kaludercic
2022-07-18 23:07 ` Stefan Kangas
2022-07-19 15:07   ` Thomas Fitzsimmons

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).