unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Protesilaos Stavrou <info@protesilaos.com>
Cc: 47810@debbugs.gnu.org, Gregory Heytings <gregory@heytings.org>
Subject: bug#47810: 28.0.50; pulse no longer accepts a face argument
Date: Tue, 20 Apr 2021 19:02:36 -0500	[thread overview]
Message-ID: <CADwFkmkTQZGGeyAVZ8e4v6HiU8RaCucozV-y8gtdFQ0W_QehZA@mail.gmail.com> (raw)
In-Reply-To: <87blae4hb2.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Fri, 16 Apr 2021 14:09:21 +0300")

Protesilaos Stavrou <info@protesilaos.com> writes:

> On 2021-04-16, 08:32 +0000, Gregory Heytings <gregory@heytings.org> wrote:
>
>>>
>>> I would expect the following two expressions to produce pulse effects
>>> that differ in colour (tried with emacs -Q):
>>>
>>>    (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'highlight)
>>>    (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'region)
>>>
>>> Instead they use the background of pulse-highlight-start-face.
>>>
>>
>> Indeed; patch attached.
>
> Thank you!  I can confirm that this works.

I guess we are still waiting for Gregory's copyright papers to come
through before this can be applied?





  reply	other threads:[~2021-04-21  0:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15 19:35 bug#47810: 28.0.50; pulse no longer accepts a face argument Protesilaos Stavrou
2021-04-16  8:32 ` Gregory Heytings
2021-04-16 11:09   ` Protesilaos Stavrou
2021-04-21  0:02     ` Stefan Kangas [this message]
2021-05-04  4:33       ` Protesilaos Stavrou
2021-05-25  4:22   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmkTQZGGeyAVZ8e4v6HiU8RaCucozV-y8gtdFQ0W_QehZA@mail.gmail.com \
    --to=stefan@marxist.se \
    --cc=47810@debbugs.gnu.org \
    --cc=gregory@heytings.org \
    --cc=info@protesilaos.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).