From: Protesilaos Stavrou <info@protesilaos.com>
To: Gregory Heytings <gregory@heytings.org>
Cc: 47810@debbugs.gnu.org, Stefan Kangas <stefan@marxist.se>
Subject: bug#47810: 28.0.50; pulse no longer accepts a face argument
Date: Tue, 04 May 2021 07:33:37 +0300 [thread overview]
Message-ID: <87v97z15jy.fsf@protesilaos.com> (raw)
In-Reply-To: <CADwFkmkTQZGGeyAVZ8e4v6HiU8RaCucozV-y8gtdFQ0W_QehZA@mail.gmail.com> (Stefan Kangas's message of "Tue, 20 Apr 2021 19:02:36 -0500")
On 2021-04-20, 19:02 -0500, Stefan Kangas <stefan@marxist.se> wrote:
> Protesilaos Stavrou <info@protesilaos.com> writes:
>
>> On 2021-04-16, 08:32 +0000, Gregory Heytings <gregory@heytings.org> wrote:
>>
>>>>
>>>> I would expect the following two expressions to produce pulse effects
>>>> that differ in colour (tried with emacs -Q):
>>>>
>>>> (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'highlight)
>>>> (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'region)
>>>>
>>>> Instead they use the background of pulse-highlight-start-face.
>>>>
>>>
>>> Indeed; patch attached.
>>
>> Thank you! I can confirm that this works.
>
> I guess we are still waiting for Gregory's copyright papers to come
> through before this can be applied?
Hello Gregory!
Has your copyright assignment process been finalised? Maybe Stefan can
help install your patches. There is this bug report as well as #47960.
All the best,
Protesilaos or "Prot"
--
Protesilaos Stavrou
https://protesilaos.com
next prev parent reply other threads:[~2021-05-04 4:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 19:35 bug#47810: 28.0.50; pulse no longer accepts a face argument Protesilaos Stavrou
2021-04-16 8:32 ` Gregory Heytings
2021-04-16 11:09 ` Protesilaos Stavrou
2021-04-21 0:02 ` Stefan Kangas
2021-05-04 4:33 ` Protesilaos Stavrou [this message]
2021-05-25 4:22 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v97z15jy.fsf@protesilaos.com \
--to=info@protesilaos.com \
--cc=47810@debbugs.gnu.org \
--cc=gregory@heytings.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).