unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Jim Blandy <jblandy@mozilla.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 58665@debbugs.gnu.org
Subject: bug#58665: Indentation in lisp/emacs-lisp/syntax.el is wrong
Date: Sun, 3 Sep 2023 03:21:33 -0700	[thread overview]
Message-ID: <CADwFkmkLVqyQTt8NJFmxMhMxCc9T8_hJqL0-xp2R2j+oTYPoBA@mail.gmail.com> (raw)
In-Reply-To: <CAMziabHvbXRjmLPf-3ufQVQTOuR0RX=O4uwDBa5u653_9ZPzxA@mail.gmail.com> (Jim Blandy's message of "Thu, 20 Oct 2022 14:18:13 -0700")

Jim Blandy <jblandy@mozilla.com> writes:

> This code changes almost never. It's been like that since 2016. It
> doesn't make sense to let it sit there with formatting that obscures
> the structure of the code.
>
> On Thu, Oct 20, 2022 at 10:57 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
>  > From: Jim Blandy <jblandy@mozilla.com>
>  > Date: Thu, 20 Oct 2022 10:23:30 -0700
>  >
>  > 2022-10-20  Jim Blandy  <jimb@red-bean.com>
>  >
>  >         * lisp/emacs-lisp/syntax.el: Fix indentation in `syntax-ppss'.
>
>  Thanks, but we don't like pure-whitespace changes.  We fix these
>  issues when we change code around the places with wrong indentation.

I agree that we should avoid making whitespace-only changes in general.
Jim makes the point that readability counts.  He also points out that
this code changes so infrequently that we do not need to be overly
worried about any annoying merge conflicts.  I think these are valid
points.

So on balance, I'd be willing to make an exception and take this patch.
If Eli is still not convinced, I think it would be better to close this
bug and move on.  I think we can all agree it's not worth spending
energy discussing it further.





  reply	other threads:[~2023-09-03 10:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20 17:23 bug#58665: Indentation in lisp/emacs-lisp/syntax.el is wrong Jim Blandy
2022-10-20 17:57 ` Eli Zaretskii
2022-10-20 21:18   ` Jim Blandy
2023-09-03 10:21     ` Stefan Kangas [this message]
2023-09-03 10:39       ` Eli Zaretskii
2023-09-03 10:45         ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmkLVqyQTt8NJFmxMhMxCc9T8_hJqL0-xp2R2j+oTYPoBA@mail.gmail.com \
    --to=stefankangas@gmail.com \
    --cc=58665@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=jblandy@mozilla.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).