From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#58665: Indentation in lisp/emacs-lisp/syntax.el is wrong Date: Sun, 3 Sep 2023 03:21:33 -0700 Message-ID: References: <83pmemwf7j.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35288"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 58665@debbugs.gnu.org To: Jim Blandy Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 03 12:22:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qckFF-0008yQ-RU for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Sep 2023 12:22:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qckEq-0006d8-Rq; Sun, 03 Sep 2023 06:21:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qckEp-0006d0-OE for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 06:21:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qckEp-0001pH-G0 for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 06:21:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qckEz-0008IY-MG for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 06:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Sep 2023 10:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58665 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58665-submit@debbugs.gnu.org id=B58665.169373651531885 (code B ref 58665); Sun, 03 Sep 2023 10:22:01 +0000 Original-Received: (at 58665) by debbugs.gnu.org; 3 Sep 2023 10:21:55 +0000 Original-Received: from localhost ([127.0.0.1]:39607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qckEt-0008IC-Ad for submit@debbugs.gnu.org; Sun, 03 Sep 2023 06:21:55 -0400 Original-Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:57488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qckEo-0008Hp-Ib for 58665@debbugs.gnu.org; Sun, 03 Sep 2023 06:21:53 -0400 Original-Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4ffa248263cso854074e87.2 for <58665@debbugs.gnu.org>; Sun, 03 Sep 2023 03:21:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693736494; x=1694341294; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=zCIw+Hf1e1XaHN3/Z0Gpu4SJc2UZ5cVoEmIALlPdAX8=; b=L02FfaGlZDj6YpUSd3XNkmdxWuTu4CyuRQkmf+tqqabzY47AXYza0M+ZMvinxrRMSA WEeG4mPkS3CkwF2zYTwbgVcShLfz7bZksB+vKtU/A9jzpLorqRI6LFJFzp3LvF2X6blW DP0gpwLM4tMfJbHLgQZ2KaeNdwinxrsUPRJlCOufQFnuUkY534wsTVMJpIMXJ28Lrgt/ TsJEfn0j7W0Te0rneqEJWWmigE2QNzNBGwLRXa2WYCYJ9KLr9uw3MIJ31PCrh4tkdcSK uSJfrUb/NrjyntL40yFRhFWXW7DrSWeDmAJt2mtYfgoFwSv/vTFp2eidG7agOWYNXdWe wetw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693736494; x=1694341294; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zCIw+Hf1e1XaHN3/Z0Gpu4SJc2UZ5cVoEmIALlPdAX8=; b=ffx2Aeir0lsqBoQpYrsHNSKPf7MH7eSwWNZNteK24pkCO5AWb4mjFs0oEic8wHEOJG JHtV+qxykLyt6JPdk7rCB3JQ9fmGCWxPw2qz3W8bnJntdyMmBKH7fdLzrqZttWBYvEoh qtQkODvFzRupmTFR73GHwUnvo2W+HxmRHYumdc2OjHbdjf6auUGCj1Q2BkMAnLhk1vfX IiNX6OJ0ezzAdcOOhCVm2x8U5y4qvqejhCJ0zsk0skdyWHqedNWE937IR6gygIsPTi9/ Q1jK6sl0MtgGilLpSyRzQ3NRzkWti91AQFiWN8YI5uoRf3X0wH8vrNMNCoXAQ9okJYHX M3qw== X-Gm-Message-State: AOJu0YyGr+BlPcvm5DBu5vTsTDJ8jB43PI/4q8JCMq0d7yvR1Ss/D7St NeF3m7mb2ZECpT1SMQrWru8vlsZhBmHTs4UJFYc= X-Google-Smtp-Source: AGHT+IFiPYZ4y0gLj1lzNOyxYDA+tX9ICQLlST76jkCi/lYLF4+rD1xoj2eB4XgHt4+dV7oXalRBoSRBNbSWP/yso4w= X-Received: by 2002:a05:6512:3b26:b0:4fb:caed:95c3 with SMTP id f38-20020a0565123b2600b004fbcaed95c3mr5255033lfv.53.1693736494246; Sun, 03 Sep 2023 03:21:34 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 3 Sep 2023 03:21:33 -0700 In-Reply-To: (Jim Blandy's message of "Thu, 20 Oct 2022 14:18:13 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269126 Archived-At: Jim Blandy writes: > This code changes almost never. It's been like that since 2016. It > doesn't make sense to let it sit there with formatting that obscures > the structure of the code. > > On Thu, Oct 20, 2022 at 10:57 AM Eli Zaretskii wrote: > > > From: Jim Blandy > > Date: Thu, 20 Oct 2022 10:23:30 -0700 > > > > 2022-10-20 Jim Blandy > > > > * lisp/emacs-lisp/syntax.el: Fix indentation in `syntax-ppss'. > > Thanks, but we don't like pure-whitespace changes. We fix these > issues when we change code around the places with wrong indentation. I agree that we should avoid making whitespace-only changes in general. Jim makes the point that readability counts. He also points out that this code changes so infrequently that we do not need to be overly worried about any annoying merge conflicts. I think these are valid points. So on balance, I'd be willing to make an exception and take this patch. If Eli is still not convinced, I think it would be better to close this bug and move on. I think we can all agree it's not worth spending energy discussing it further.