unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Glenn Morris <rgm@gnu.org>
Cc: 10758@debbugs.gnu.org
Subject: bug#10758: thumbs and image-dired to use built-in ImageMagick
Date: Fri, 22 Oct 2021 23:57:42 -0700	[thread overview]
Message-ID: <CADwFkmkDn8jKJM2tp36AoVms8MjCX=UEVk=L0NS0mUq=0CXVmw@mail.gmail.com> (raw)
In-Reply-To: <87k18jw6w0.fsf@marxist.se> (Stefan Kangas's message of "Fri, 01 Nov 2019 23:47:59 +0100")

Stefan Kangas <stefan@marxist.se> writes:

> Glenn Morris <rgm@gnu.org> writes:
>
>> Package: emacs
>> Version: 24.0.93
>> Severity: wishlist
>>
>> thumbs.el and image-dired.el both rely on using external ImageMagick
>> utilities to resize/rotate images.
>>
>> If Emacs was compiled with ImageMagick support, then images of
>> type imagemagick can be resized and rotated internally (see
>> image-transform-*). These modes should use the internal support if
>> it exists.
>
> So now that we have native image rotation and ImageMagick is on its
> way to become deprecated, I assume that this bug should be taken to
> mean that we want to use the built-in support here instead.

Hmm, looking closer at this, both thumbs.el and image-dired.el modifies
the actual image file.  This is something that our built-in support
can't do, as we only have support for reading images.

However, the ImageMagick library has these capabilities.  Given that we
no longer compile with ImageMagick by default, I don't think this
request makes any sense as it stands.  Perhaps we could implement the
in-memory rotation in addition to the modifying one that we have now,
but this is unlikely to be very useful.  If I rotate an image in an
image viewer, it is almost certainly because I want to update the file;
at least this is always the case in my use.

Jpeg images can of course be losslessly rotated by just modifying the
exif data, so implementing built-in support for rotating jpeg images
seems quite doable.  However, we would still not be able to drop the
external imagemagick dependency, because we would then also lose the
capability to rotate other image formats.

So perhaps this feature request is relevant anymore.  WDYT?





  reply	other threads:[~2021-10-23  6:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-08  4:52 bug#10758: thumbs and image-dired to use built-in ImageMagick Glenn Morris
2019-11-01 22:47 ` Stefan Kangas
2021-10-23  6:57   ` Stefan Kangas [this message]
2021-10-24  9:14     ` Stefan Kangas
2021-10-24  9:45       ` Stefan Kangas
2021-10-25 19:02         ` Mathias Dahl
2021-10-25 19:37           ` Stefan Kangas
2021-10-27 22:14             ` Stefan Kangas
2021-11-04  1:08               ` Stefan Kangas
2021-10-27 22:13     ` Stefan Kangas
2021-12-07 22:46       ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmkDn8jKJM2tp36AoVms8MjCX=UEVk=L0NS0mUq=0CXVmw@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=10758@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).