From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#10758: thumbs and image-dired to use built-in ImageMagick Date: Fri, 22 Oct 2021 23:57:42 -0700 Message-ID: References: <8xfwemx6yr.fsf@fencepost.gnu.org> <87k18jw6w0.fsf@marxist.se> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17832"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 10758@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 23 08:58:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1meAyt-0004PO-N3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Oct 2021 08:58:15 +0200 Original-Received: from localhost ([::1]:53002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1meAys-00059P-Bc for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Oct 2021 02:58:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1meAyg-000598-Az for bug-gnu-emacs@gnu.org; Sat, 23 Oct 2021 02:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50918) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1meAyg-0003o2-2s for bug-gnu-emacs@gnu.org; Sat, 23 Oct 2021 02:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1meAyf-0001dG-Mo for bug-gnu-emacs@gnu.org; Sat, 23 Oct 2021 02:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Oct 2021 06:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10758 X-GNU-PR-Package: emacs Original-Received: via spool by 10758-submit@debbugs.gnu.org id=B10758.16349722726240 (code B ref 10758); Sat, 23 Oct 2021 06:58:01 +0000 Original-Received: (at 10758) by debbugs.gnu.org; 23 Oct 2021 06:57:52 +0000 Original-Received: from localhost ([127.0.0.1]:34227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meAyW-0001ca-69 for submit@debbugs.gnu.org; Sat, 23 Oct 2021 02:57:52 -0400 Original-Received: from mail-pf1-f176.google.com ([209.85.210.176]:33785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meAyT-0001cL-HW for 10758@debbugs.gnu.org; Sat, 23 Oct 2021 02:57:50 -0400 Original-Received: by mail-pf1-f176.google.com with SMTP id t184so5669205pfd.0 for <10758@debbugs.gnu.org>; Fri, 22 Oct 2021 23:57:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=GdhXJo5Np3SvB2iD6QeaYrOo1P1ALNSN/IbVgRsDXZI=; b=r3lNPDj08c7z7LXbsQfgkvQZDJvbuQhk3E3zB9K108RXlecLf5aTZps1SnDLvqy7bk 0/wzr7e4C69/3DTBPamhajhuKAaQIAQOJlYjkGEbIfbl8CCVdWAWpcp7XUCUuOFedLGc JLFVGKqc6B9FyUrdOiBRG5PuNqNT6unZqzd/Jm18/ejD2YTRW7oIWT0H5hLSFlcC9D7g qn3GQ3WDNyghyuYMBQJM0AlSvrqyT036A55/vVSH6j0egjzk/UJYKljpJvIH6HgtVOGf XW46P72+6zKv3UfCntagCvz+YImrA2LVa58KvdvqPOXs20gmRkxelxnCsj0UmsYdmT5A AZnA== X-Gm-Message-State: AOAM531yYbJ2QHUvTs9d3f/bVgxPgn5HfL4q6OAXdxEXwBEXuSicl1yL x1tV01z4xkFvHSoUN67PeRWnwlrjmk6v2oBMKyo= X-Google-Smtp-Source: ABdhPJxMV51ssF4WNJaurFneyxeUIa/1bJ9I6iUVO4gkID7bChWjG9oAEmekBFvNlQoOdXLsrGK9fMd5AW2CuqZkMnI= X-Received: by 2002:a05:6a00:244d:b0:44d:c279:5155 with SMTP id d13-20020a056a00244d00b0044dc2795155mr4784287pfj.0.1634972263676; Fri, 22 Oct 2021 23:57:43 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 22 Oct 2021 23:57:42 -0700 In-Reply-To: <87k18jw6w0.fsf@marxist.se> (Stefan Kangas's message of "Fri, 01 Nov 2019 23:47:59 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217947 Archived-At: Stefan Kangas writes: > Glenn Morris writes: > >> Package: emacs >> Version: 24.0.93 >> Severity: wishlist >> >> thumbs.el and image-dired.el both rely on using external ImageMagick >> utilities to resize/rotate images. >> >> If Emacs was compiled with ImageMagick support, then images of >> type imagemagick can be resized and rotated internally (see >> image-transform-*). These modes should use the internal support if >> it exists. > > So now that we have native image rotation and ImageMagick is on its > way to become deprecated, I assume that this bug should be taken to > mean that we want to use the built-in support here instead. Hmm, looking closer at this, both thumbs.el and image-dired.el modifies the actual image file. This is something that our built-in support can't do, as we only have support for reading images. However, the ImageMagick library has these capabilities. Given that we no longer compile with ImageMagick by default, I don't think this request makes any sense as it stands. Perhaps we could implement the in-memory rotation in addition to the modifying one that we have now, but this is unlikely to be very useful. If I rotate an image in an image viewer, it is almost certainly because I want to update the file; at least this is always the case in my use. Jpeg images can of course be losslessly rotated by just modifying the exif data, so implementing built-in support for rotating jpeg images seems quite doable. However, we would still not be able to drop the external imagemagick dependency, because we would then also lose the capability to rotate other image formats. So perhaps this feature request is relevant anymore. WDYT?