From: Stefan Kangas <stefan@marxist.se>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: 54976@debbugs.gnu.org
Subject: bug#54976: 29.0.50; Eshell breaks when unknown entries in eshell-modules-list
Date: Sun, 19 Jun 2022 07:57:38 -0700 [thread overview]
Message-ID: <CADwFkmk4vhmpAduN6X2defhE5VMRrsuwY0sAQDQSmE-EyUMAXQ@mail.gmail.com> (raw)
In-Reply-To: <87czhgkb1c.fsf@melete.silentflame.com> (Sean Whitton's message of "Sat, 16 Apr 2022 13:50:39 -0700")
close 54976 29.1
thanks
Sean Whitton <spwhitton@spwhitton.name> writes:
> Suppose you put this in your init.el:
>
> (add-to-list 'eshell-modules-list 'eshell-elecslash)
>
> because you want to use the new em-elecslash.el module I'm working on.
>
> Then if you try to M-x eshell on an older version of Emacs which lacks
> em-elecslash, Eshell will fail to initialise at all.
>
> It is easy add a guard (when (locate-library ...)) or similar, but this
> is not possible if you have added eshell-elecslash using the customise
> interface. In that case, by enabling the module, youq just make your
> init unusable with older Emacs.
>
> It would be better to print a warning, say, rather than error.
I agree that it makes more sense to warn here instead of refusing to
start. So I have now done that in Emacs 29 (commit d6b4803850).
next prev parent reply other threads:[~2022-06-19 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-16 20:50 bug#54976: 29.0.50; Eshell breaks when unknown entries in eshell-modules-list Sean Whitton
2022-06-19 14:57 ` Stefan Kangas [this message]
2022-06-19 22:26 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmk4vhmpAduN6X2defhE5VMRrsuwY0sAQDQSmE-EyUMAXQ@mail.gmail.com \
--to=stefan@marxist.se \
--cc=54976@debbugs.gnu.org \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).