From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#54976: 29.0.50; Eshell breaks when unknown entries in eshell-modules-list Date: Sun, 19 Jun 2022 07:57:38 -0700 Message-ID: References: <87czhgkb1c.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2040"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 54976@debbugs.gnu.org To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 19 16:58:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o2wNe-0000Ij-U3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Jun 2022 16:58:26 +0200 Original-Received: from localhost ([::1]:49610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2wNe-0001Zf-1k for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Jun 2022 10:58:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2wNH-0001Wa-If for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2022 10:58:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2wNF-0006Hl-If for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2022 10:58:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o2wNF-0006cQ-IM for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2022 10:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Jun 2022 14:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54976 X-GNU-PR-Package: emacs Original-Received: via spool by 54976-submit@debbugs.gnu.org id=B54976.165565066725417 (code B ref 54976); Sun, 19 Jun 2022 14:58:01 +0000 Original-Received: (at 54976) by debbugs.gnu.org; 19 Jun 2022 14:57:47 +0000 Original-Received: from localhost ([127.0.0.1]:52843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2wN0-0006bo-JY for submit@debbugs.gnu.org; Sun, 19 Jun 2022 10:57:46 -0400 Original-Received: from mail-pj1-f49.google.com ([209.85.216.49]:33125) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2wMy-0006bT-RA for 54976@debbugs.gnu.org; Sun, 19 Jun 2022 10:57:45 -0400 Original-Received: by mail-pj1-f49.google.com with SMTP id hv24-20020a17090ae41800b001e33eebdb5dso10473229pjb.0 for <54976@debbugs.gnu.org>; Sun, 19 Jun 2022 07:57:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=I9TeUsn0ck7/+cqqmc2ctgauqhnMYDXZPkYtMwiSQGM=; b=7lFppuQPTibp7jn7doSPNlyLZoxK/gin7+k5w6oR5b8h0XAIahDq4cBR42DO+wDlnY O1OCBlw6sdN4HKlKgRxbdcNnspa62677WnJjJc26xdUsXUYzxCRVNu5MM3xgNwUF5Gg/ E2F7eLP2VsCaHAspa9UIU6gFHbH2kNn4bj5y1r9VLALZGaFO9iKLK8Ll0Yj9jOBaLZUc vlkeA/5CSaFaweqBhz9GgbpWlJL98Jr6CTPSMsaxAbRMub6Qv63O+RgQxdPwQuTuDabb 5p1kZ6yf+vzl6cv01Wr8ujSFwPtiAzr5g3EYU/KHQIN7eVY+vhFeCZ8XtYg3L/+H0YGY qDdw== X-Gm-Message-State: AJIora+tLPLoM/xU13AN+pvlFzDrn0hlbxrdVTNLS+UaW/DGYghBMKkm raQ07Y8XuNFqsmcYrAgHE1DkTEHiL3SaGhJ7G8g= X-Google-Smtp-Source: AGRyM1usg74lTpnm4UG/5ajeJoQ4L+vCYGklYlQDITSe6SCMzL5gXxwQUNXS2wC2rZQ3wwKsNp4Dhd3Zznx+nuo/N8U= X-Received: by 2002:a17:902:e8d7:b0:168:e2da:893c with SMTP id v23-20020a170902e8d700b00168e2da893cmr19782643plg.152.1655650658921; Sun, 19 Jun 2022 07:57:38 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 19 Jun 2022 07:57:38 -0700 In-Reply-To: <87czhgkb1c.fsf@melete.silentflame.com> (Sean Whitton's message of "Sat, 16 Apr 2022 13:50:39 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234798 Archived-At: close 54976 29.1 thanks Sean Whitton writes: > Suppose you put this in your init.el: > > (add-to-list 'eshell-modules-list 'eshell-elecslash) > > because you want to use the new em-elecslash.el module I'm working on. > > Then if you try to M-x eshell on an older version of Emacs which lacks > em-elecslash, Eshell will fail to initialise at all. > > It is easy add a guard (when (locate-library ...)) or similar, but this > is not possible if you have added eshell-elecslash using the customise > interface. In that case, by enabling the module, youq just make your > init unusable with older Emacs. > > It would be better to print a warning, say, rather than error. I agree that it makes more sense to warn here instead of refusing to start. So I have now done that in Emacs 29 (commit d6b4803850).