From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 20150@debbugs.gnu.org
Subject: bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED)
Date: Sat, 13 Jul 2019 15:51:57 +0200 [thread overview]
Message-ID: <CADwFkmk2mLb_nfvctTWHk7EkM9hcb0k6=ohO7+f81yVZ6ZMSmg@mail.gmail.com> (raw)
In-Reply-To: <8336ja12zb.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
> > I also don't know why I named the new variable bookmark-annotation--name, so
> > I've changed that to bookmark--annotation-name to better reflect current
> > practices.
>
> Hmm... I don't see bookmark--annotation-name in the patch. Did you
> send the correct patch?
Oops, please ignore that part. I wrote the wrong variable name, and
actually meant to say:
I also don't know why I initially named the new variable
bookmark-annotation--from-bookmark-list, so in the updated patch I've
changed that to bookmark--annotation-from-bookmark-list to better
reflect current practices. (Note the placement of dashes.)
bookmark-annotation-name is unchanged in the updated patch. I didn't
rename it nor make it obsolete. I don't think it matters too much --
it could be internal, but it might not be worth renaming.
Sorry for the confusion.
Thanks,
Stefan Kangas
next prev parent reply other threads:[~2019-07-13 13:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 7:24 bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) Boruch Baum
2015-03-20 14:28 ` Stefan Monnier
2015-03-20 16:22 ` Boruch Baum
2019-07-02 1:54 ` Stefan Kangas
2019-07-02 3:23 ` Stefan Kangas
2019-07-03 20:05 ` Stefan Kangas
2019-07-04 19:20 ` Stefan Kangas
2019-07-04 19:40 ` Stefan Kangas
2019-07-13 7:30 ` Eli Zaretskii
2019-07-13 13:09 ` Stefan Kangas
2019-07-13 13:24 ` Eli Zaretskii
2019-07-13 13:51 ` Stefan Kangas [this message]
2019-07-14 1:48 ` Glenn Morris
2019-07-14 6:04 ` Eli Zaretskii
2019-07-14 6:29 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmk2mLb_nfvctTWHk7EkM9hcb0k6=ohO7+f81yVZ6ZMSmg@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=20150@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).