From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) Date: Sat, 13 Jul 2019 15:51:57 +0200 Message-ID: References: <83r26u1jeu.fsf@gnu.org> <8336ja12zb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="161647"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 20150@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 13 15:53:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmISZ-000frd-9O for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Jul 2019 15:53:07 +0200 Original-Received: from localhost ([::1]:55420 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmISY-00077n-AU for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Jul 2019 09:53:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59706) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmISV-000776-B5 for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 09:53:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmISU-0007uP-EM for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 09:53:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32809) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hmISU-0007uB-Am for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 09:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hmISU-0003A9-7l for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 09:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jul 2019 13:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20150 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 20150-submit@debbugs.gnu.org id=B20150.156302593712059 (code B ref 20150); Sat, 13 Jul 2019 13:53:02 +0000 Original-Received: (at 20150) by debbugs.gnu.org; 13 Jul 2019 13:52:17 +0000 Original-Received: from localhost ([127.0.0.1]:41630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmIRk-00038R-Sd for submit@debbugs.gnu.org; Sat, 13 Jul 2019 09:52:17 -0400 Original-Received: from mail-wm1-f53.google.com ([209.85.128.53]:38505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmIRj-00038C-3s for 20150@debbugs.gnu.org; Sat, 13 Jul 2019 09:52:15 -0400 Original-Received: by mail-wm1-f53.google.com with SMTP id s15so11241201wmj.3 for <20150@debbugs.gnu.org>; Sat, 13 Jul 2019 06:52:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BEcOHUnE4+9l+hizPu5FoF8oc9mdk+/e+YguqMU4+nk=; b=CJc1ZcvbbhERVa/SkVyJm44CCMJENC9eSRYSJo6teIoCJ+F9hUTkThmQx73visrspe XCVmgLa9C1avAPe+i/P+YEYd9GvbORY6a4sH3FwVSZYBbXURA8friavceYQzm94+yPos NbSZYAvwpQqG++98ZsfXnQofUgIt8gdJSp6joRY4wiuvQGwzNRRJUU4HrV81NDSDNBD2 KD4gMwmtVt7haPn7BsC8MpTZuD59S+hgbDk0yQdqOW1LRL/GZFzLNIW5zhyTMkNkucmL YbTTCOeT2QGACOcsl+2y8KsF+WXSBxZsuxov1niMYYed2I6gZzq/ld3mVHUPK9EHE+x4 fefw== X-Gm-Message-State: APjAAAVOjCUFY/CW7bB4iHtMz6x3WfQiS0SsYecSK+2s/2VI2a4Dg8PQ UI0UTtv5VkAwSQdue4F8GHET/yFLtNGIkz9fU7c= X-Google-Smtp-Source: APXvYqwGWyaOIzFKHBfFfCty6dik43aVpKrqdukBl1oy6ts9ruPNkYJ/yjfDVaE6XrjdRk7noVc3+9H/QFrCH5Q3mSw= X-Received: by 2002:a1c:7c08:: with SMTP id x8mr14967978wmc.19.1563025929217; Sat, 13 Jul 2019 06:52:09 -0700 (PDT) In-Reply-To: <8336ja12zb.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162879 Archived-At: Eli Zaretskii writes: > > I also don't know why I named the new variable bookmark-annotation--name, so > > I've changed that to bookmark--annotation-name to better reflect current > > practices. > > Hmm... I don't see bookmark--annotation-name in the patch. Did you > send the correct patch? Oops, please ignore that part. I wrote the wrong variable name, and actually meant to say: I also don't know why I initially named the new variable bookmark-annotation--from-bookmark-list, so in the updated patch I've changed that to bookmark--annotation-from-bookmark-list to better reflect current practices. (Note the placement of dashes.) bookmark-annotation-name is unchanged in the updated patch. I didn't rename it nor make it obsolete. I don't think it matters too much -- it could be internal, but it might not be worth renaming. Sorry for the confusion. Thanks, Stefan Kangas