bug#65671: Eglot: add support for terraform-ls

bug#65671: Eglot: add support for terraform-ls

[me--- via Bug reports for GNU Emacs, the Swiss army knife of text editors]

From 00b2b7f5a456278325334509a1396e6b9307914d Mon Sep 17 00:00:00 2001
From: Ross Timson <me@rosstimson.com>
Date: Thu, 31 Aug 2023 20:28:22 +0100
Subject: [PATCH] Eglot: add support for terraform-ls

Adding support for the official Terraform LSP server.
---
 lisp/progmodes/eglot.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 65daa0941d5..3375e7969c2 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -257,7 +257,8 @@ chosen (interactively or automatically)."
                                  . ,(eglot-alternatives
                                      '(("marksman" "server")
                                        ("vscode-markdown-language-server" "--stdio"))))
-                                (graphviz-dot-mode . ("dot-language-server" "--stdio")))
+                                (graphviz-dot-mode . ("dot-language-server" "--stdio"))
+                                (terraform-mode . ("terraform-ls" "serve")))
   "How the command `eglot' guesses the server to start.
 An association list of (MAJOR-MODE . CONTACT) pairs.  MAJOR-MODE
 identifies the buffers that are to be managed by a specific
-- 
2.39.2 (Apple Git-143)

bug#65671: Eglot: add support for terraform-ls

[Stefan Kangas]

> From 00b2b7f5a456278325334509a1396e6b9307914d Mon Sep 17 00:00:00 2001
> From: Ross Timson <me@rosstimson.com>
> Date: Thu, 31 Aug 2023 20:28:22 +0100
> Subject: [PATCH] Eglot: add support for terraform-ls
>
> Adding support for the official Terraform LSP server.
> ---
>  lisp/progmodes/eglot.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> index 65daa0941d5..3375e7969c2 100644
> --- a/lisp/progmodes/eglot.el
> +++ b/lisp/progmodes/eglot.el
> @@ -257,7 +257,8 @@ chosen (interactively or automatically)."
>                                   . ,(eglot-alternatives
>                                       '(("marksman" "server")
>                                         ("vscode-markdown-language-server" "--stdio"))))
> -                                (graphviz-dot-mode . ("dot-language-server" "--stdio")))
> +                                (graphviz-dot-mode . ("dot-language-server" "--stdio"))
> +                                (terraform-mode . ("terraform-ls" "serve")))
>    "How the command `eglot' guesses the server to start.
>  An association list of (MAJOR-MODE . CONTACT) pairs.  MAJOR-MODE
>  identifies the buffers that are to be managed by a specific
> --
> 2.39.2 (Apple Git-143)

Makes sense to me.  João, do you have any comments?

bug#65671: Eglot: add support for terraform-ls

[João Távora]

[-- Attachment #1: Type: text/plain, Size: 1691 bytes --]

No, no comments. Push these simple contributions at will, as usual.

It would be useful, at some point, to collect these additions in the
etc/EGLOT-NEWS for (grouped in a single bullet, of course).

João

On Fri, Sep 1, 2023, 17:04 Stefan Kangas <stefankangas@gmail.com> wrote:

> > From 00b2b7f5a456278325334509a1396e6b9307914d Mon Sep 17 00:00:00 2001
> > From: Ross Timson <me@rosstimson.com>
> > Date: Thu, 31 Aug 2023 20:28:22 +0100
> > Subject: [PATCH] Eglot: add support for terraform-ls
> >
> > Adding support for the official Terraform LSP server.
> > ---
> >  lisp/progmodes/eglot.el | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> > index 65daa0941d5..3375e7969c2 100644
> > --- a/lisp/progmodes/eglot.el
> > +++ b/lisp/progmodes/eglot.el
> > @@ -257,7 +257,8 @@ chosen (interactively or automatically)."
> >                                   . ,(eglot-alternatives
> >                                       '(("marksman" "server")
> >
>  ("vscode-markdown-language-server" "--stdio"))))
> > -                                (graphviz-dot-mode .
> ("dot-language-server" "--stdio")))
> > +                                (graphviz-dot-mode .
> ("dot-language-server" "--stdio"))
> > +                                (terraform-mode . ("terraform-ls"
> "serve")))
> >    "How the command `eglot' guesses the server to start.
> >  An association list of (MAJOR-MODE . CONTACT) pairs.  MAJOR-MODE
> >  identifies the buffers that are to be managed by a specific
> > --
> > 2.39.2 (Apple Git-143)
>
> Makes sense to me.  João, do you have any comments?
>

[-- Attachment #2: Type: text/html, Size: 2508 bytes --]

bug#65671: Eglot: add support for terraform-ls

[Stefan Kangas]

Version: 29.2

João Távora <joaotavora@gmail.com> writes:

> No, no comments. Push these simple contributions at will, as usual.

Thanks.  Fixed up the commit message and pushed to emacs-29 as commit
369f2eea100.

Thank you for the patch, Ross.