* bug#65481: Replace defadvice with advice-add in Tramp manual
@ 2023-08-23 23:09 Stefan Kangas
2023-08-24 7:46 ` Michael Albinus
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Kangas @ 2023-08-23 23:09 UTC (permalink / raw)
To: 65481; +Cc: michael.albinus
Severity: wishlist
X-Debbugs-CC: michael.albinus@gmx.de
The Tramp manual recommends `defadvice', but it is now obsolete
(commit 27ed565ec6). How about changing the below examples to use
`advice-add' instead?
./misc/tramp.texi:5257:(defadvice tramp-handle-write-region
./misc/tramp.texi:5265:(defadvice tramp-handle-do-copy-or-rename-file
./misc/tramp.texi:5273:(defadvice tramp-handle-insert-file-contents
./misc/tramp.texi:5531:(defadvice minibuffer-complete
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#65481: Replace defadvice with advice-add in Tramp manual
2023-08-23 23:09 bug#65481: Replace defadvice with advice-add in Tramp manual Stefan Kangas
@ 2023-08-24 7:46 ` Michael Albinus
2023-09-06 9:39 ` Stefan Kangas
0 siblings, 1 reply; 7+ messages in thread
From: Michael Albinus @ 2023-08-24 7:46 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 65481
Stefan Kangas <stefankangas@gmail.com> writes:
Hi Stefan,
> The Tramp manual recommends `defadvice', but it is now obsolete
> (commit 27ed565ec6). How about changing the below examples to use
> `advice-add' instead?
>
> ./misc/tramp.texi:5257:(defadvice tramp-handle-write-region
> ./misc/tramp.texi:5265:(defadvice tramp-handle-do-copy-or-rename-file
> ./misc/tramp.texi:5273:(defadvice tramp-handle-insert-file-contents
> ./misc/tramp.texi:5531:(defadvice minibuffer-complete
Yes, pls do.
Best regards, Michael.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#65481: Replace defadvice with advice-add in Tramp manual
2023-08-24 7:46 ` Michael Albinus
@ 2023-09-06 9:39 ` Stefan Kangas
2023-09-06 16:21 ` Michael Albinus
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Kangas @ 2023-09-06 9:39 UTC (permalink / raw)
To: Michael Albinus; +Cc: 65481
Michael Albinus <michael.albinus@gmx.de> writes:
>> The Tramp manual recommends `defadvice', but it is now obsolete
>> (commit 27ed565ec6). How about changing the below examples to use
>> `advice-add' instead?
>>
>> ./misc/tramp.texi:5257:(defadvice tramp-handle-write-region
>> ./misc/tramp.texi:5265:(defadvice tramp-handle-do-copy-or-rename-file
>> ./misc/tramp.texi:5273:(defadvice tramp-handle-insert-file-contents
>> ./misc/tramp.texi:5531:(defadvice minibuffer-complete
>
> Yes, pls do.
I was hoping someone more familiar with Tramp could do it, wink wink.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#65481: Replace defadvice with advice-add in Tramp manual
2023-09-06 9:39 ` Stefan Kangas
@ 2023-09-06 16:21 ` Michael Albinus
2023-09-06 18:34 ` Stefan Kangas
2023-09-07 13:07 ` Michael Albinus
0 siblings, 2 replies; 7+ messages in thread
From: Michael Albinus @ 2023-09-06 16:21 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 65481
Stefan Kangas <stefankangas@gmail.com> writes:
Hi Stefan,
>>> The Tramp manual recommends `defadvice', but it is now obsolete
>>> (commit 27ed565ec6). How about changing the below examples to use
>>> `advice-add' instead?
>>>
>>> ./misc/tramp.texi:5257:(defadvice tramp-handle-write-region
>>> ./misc/tramp.texi:5265:(defadvice tramp-handle-do-copy-or-rename-file
>>> ./misc/tramp.texi:5273:(defadvice tramp-handle-insert-file-contents
>>> ./misc/tramp.texi:5531:(defadvice minibuffer-complete
>>
>> Yes, pls do.
>
> I was hoping someone more familiar with Tramp could do it, wink wink.
I'm short in time last week and this one. Will do when time permits,
likely over the weekend.
Best regards, Michael.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#65481: Replace defadvice with advice-add in Tramp manual
2023-09-06 16:21 ` Michael Albinus
@ 2023-09-06 18:34 ` Stefan Kangas
2023-09-07 13:07 ` Michael Albinus
1 sibling, 0 replies; 7+ messages in thread
From: Stefan Kangas @ 2023-09-06 18:34 UTC (permalink / raw)
To: Michael Albinus; +Cc: 65481
Michael Albinus <michael.albinus@gmx.de> writes:
> I'm short in time last week and this one. Will do when time permits,
> likely over the weekend.
Thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#65481: Replace defadvice with advice-add in Tramp manual
2023-09-06 16:21 ` Michael Albinus
2023-09-06 18:34 ` Stefan Kangas
@ 2023-09-07 13:07 ` Michael Albinus
2023-09-07 14:03 ` Stefan Kangas
1 sibling, 1 reply; 7+ messages in thread
From: Michael Albinus @ 2023-09-07 13:07 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 65481-done
Version: 29.2
Hi Stefan,
>>>> The Tramp manual recommends `defadvice', but it is now obsolete
>>>> (commit 27ed565ec6). How about changing the below examples to use
>>>> `advice-add' instead?
>>>>
>>>> ./misc/tramp.texi:5257:(defadvice tramp-handle-write-region
>>>> ./misc/tramp.texi:5265:(defadvice tramp-handle-do-copy-or-rename-file
>>>> ./misc/tramp.texi:5273:(defadvice tramp-handle-insert-file-contents
>>>> ./misc/tramp.texi:5531:(defadvice minibuffer-complete
>>>
>>> Yes, pls do.
>>
>> I was hoping someone more familiar with Tramp could do it, wink wink.
>
> I'm short in time last week and this one. Will do when time permits,
> likely over the weekend.
Surprisingly, it's a calm day. So I've adapted the Tramp manual, pushed
to the emacs-29 branch. Closing the bug.
Best regards, Michael.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-09-07 14:03 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-23 23:09 bug#65481: Replace defadvice with advice-add in Tramp manual Stefan Kangas
2023-08-24 7:46 ` Michael Albinus
2023-09-06 9:39 ` Stefan Kangas
2023-09-06 16:21 ` Michael Albinus
2023-09-06 18:34 ` Stefan Kangas
2023-09-07 13:07 ` Michael Albinus
2023-09-07 14:03 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).