unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 47424@debbugs.gnu.org, monnier@iro.umontreal.ca, mardani29@yahoo.es
Subject: bug#47424: 28.0.50; enable-theme shows an empty list
Date: Sun, 4 Apr 2021 04:05:43 -0500	[thread overview]
Message-ID: <CADwFkm=gkhHppCgmNCVFfS61uQXRKVYnuUa16BR_PFQhtBaqvQ@mail.gmail.com> (raw)
In-Reply-To: <83czvaecf5.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

>> I'm not exactly sure why we bother differentiating between loading a
>> theme and enabling it.  Technically, I understand that there is a
>> difference.  But why should a user have to fiddle around with it?
>
> For the same reason that loading a Lisp package shouldn't change the
> Emacs state, until the user explicitly activates the features in the
> package.  It's unclean to have loading activate stuff, and we've
> invested an effort during the last years to remove that uncleanliness.

I still don't see why a user should need to worry about this
distinction or the complexities involved.  It seems like a suboptimal
interface.

We are here talking about user-facing features.  I think it should be
enough to have one knob to disable themes and one knob to enable them.

> With themes, you can load several ones and then enable/disable any of
> them whenever you see fit.

I don't see why a user would want/need to load a theme if she does not
intend to use it.  If the user wants to load it for later use, why not
just defer loading it until that time?

And if a user *really* wants to load a theme for some reason, there is
always e.g. `load-file' or `load-library'.

What am I missing?

> Under your proposal, disabling a theme would be impossible without
> unloading it, and that might not be easy to do cleanly.

I'm not sure I follow; I see no need to make it symmetrical in that
sense.  In the same way, we don't bother unloading a library just
because the major-mode involved is not used in any buffer.  But we do
provide a way to autoload major modes.

BTW, why would an end-user ever need to unload a theme?  Is it not
enough to simply disable it?





  reply	other threads:[~2021-04-04  9:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 21:41 bug#47424: 28.0.50; enable-theme shows an empty list Stefan Monnier
2021-03-27  1:50 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-27  1:57   ` Stefan Monnier
2021-03-27  2:40     ` Stefan Monnier
2021-03-27  6:10     ` Eli Zaretskii
2021-04-04  0:14     ` Stefan Kangas
2021-04-04  7:28       ` Eli Zaretskii
2021-04-04  9:05         ` Stefan Kangas [this message]
2021-04-04 11:47           ` Eli Zaretskii
2021-04-04 13:17             ` Stefan Kangas
2021-04-04 13:44               ` Eli Zaretskii
2022-06-27  8:36                 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=gkhHppCgmNCVFfS61uQXRKVYnuUa16BR_PFQhtBaqvQ@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=47424@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=mardani29@yahoo.es \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).