unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 47424@debbugs.gnu.org, "Daniel Martín" <mardani29@yahoo.es>
Subject: bug#47424: 28.0.50; enable-theme shows an empty list
Date: Sat, 3 Apr 2021 19:14:29 -0500	[thread overview]
Message-ID: <CADwFkmnZZbmuzE3irWXQDLFM7seLPgaipOg7dh6iuHFxSSNziQ@mail.gmail.com> (raw)
In-Reply-To: <jwvtuoxz7ey.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 26 Mar 2021 21:57:31 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> According to the documentation, `enable-theme' enables variable and face
>> settings of already loaded themes, so I think it makes sense that it
>> doesn't offer completions in emacs -Q, because there is no loaded theme
>> yet.
>>
>> Perhaps you wanted to do M-x load-theme, which should properly complete
>> with themes from etc/themes, among other directories?
>
> I know it works as documented, but I don't think it's the behavior we
> really want.  We should autoload themes, just like we autoload pretty
> much everything else.

I'm not exactly sure why we bother differentiating between loading a
theme and enabling it.  Technically, I understand that there is a
difference.  But why should a user have to fiddle around with it?

I have themes in the Emacs distribution or installed from some ELPA
repository.  I am now interested in exactly one thing: enable this
installed theme.  Or don't.  Load as necessary.  As a user, I am almost
completely indifferent to what symbols are defined in my Emacs session.

IOW, I'd be in favour of removing one of `enable-theme' or `load-theme'
and ensure we always DTRT and DWIM (which includes autoloading when
necessary).

(If someone needs a way to reload themes (besides `load-file', I
suppose), we could have a new function `theme-reload'.)





  parent reply	other threads:[~2021-04-04  0:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 21:41 bug#47424: 28.0.50; enable-theme shows an empty list Stefan Monnier
2021-03-27  1:50 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-27  1:57   ` Stefan Monnier
2021-03-27  2:40     ` Stefan Monnier
2021-03-27  6:10     ` Eli Zaretskii
2021-04-04  0:14     ` Stefan Kangas [this message]
2021-04-04  7:28       ` Eli Zaretskii
2021-04-04  9:05         ` Stefan Kangas
2021-04-04 11:47           ` Eli Zaretskii
2021-04-04 13:17             ` Stefan Kangas
2021-04-04 13:44               ` Eli Zaretskii
2022-06-27  8:36                 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmnZZbmuzE3irWXQDLFM7seLPgaipOg7dh6iuHFxSSNziQ@mail.gmail.com \
    --to=stefan@marxist.se \
    --cc=47424@debbugs.gnu.org \
    --cc=mardani29@yahoo.es \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).