* bug#42874: [PATCH] Mark XEmacs compat alias user-original-login-name obsolete
@ 2020-08-15 3:10 Stefan Kangas
2020-08-16 10:17 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Kangas @ 2020-08-15 3:10 UTC (permalink / raw)
To: 42874
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
The XEmacs compatibility alias `user-original-login-name' was declared
obsolete even in XEmacs:
https://bitbucket.org/xemacs/xemacs/src/e2ac728aa576a39ca5a7de608a1914dde5b1b083/lisp/obsolete.el#lines-461
Searching for its name on github gives 1383 code matches, most of which
seem to be copies of Emacs itself.
Are there any objections to marking it obsolete?
Best regards,
Stefan Kangas
[-- Attachment #2: 0001-Mark-XEmacs-compat-alias-as-obsolete.patch --]
[-- Type: text/x-diff, Size: 887 bytes --]
From 287bda37d839ab9f81f59b12be04db6a6961919f Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Sat, 15 Aug 2020 04:55:35 +0200
Subject: [PATCH] Mark XEmacs compat alias as obsolete
* lisp/subr.el (user-original-login-name): Mark as obsolete. This
XEmacs compat alias was obsoleted even by XEmacs, so there should be
no point in keeping it around.
---
lisp/subr.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/subr.el b/lisp/subr.el
index 8eb4cf452d..0bd09c6556 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -1649,7 +1649,8 @@ 'mkdir
(defalias 'point-at-eol 'line-end-position)
(defalias 'point-at-bol 'line-beginning-position)
-(defalias 'user-original-login-name 'user-login-name)
+(define-obsolete-function-alias 'user-original-login-name
+ 'user-login-name "28.1")
\f
;;;; Hook manipulation functions.
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#42874: [PATCH] Mark XEmacs compat alias user-original-login-name obsolete
2020-08-15 3:10 bug#42874: [PATCH] Mark XEmacs compat alias user-original-login-name obsolete Stefan Kangas
@ 2020-08-16 10:17 ` Lars Ingebrigtsen
2020-08-16 13:41 ` Stefan Kangas
0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2020-08-16 10:17 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 42874
Stefan Kangas <stefan@marxist.se> writes:
> -(defalias 'user-original-login-name 'user-login-name)
> +(define-obsolete-function-alias 'user-original-login-name
> + 'user-login-name "28.1")
Sounds good to me.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#42874: [PATCH] Mark XEmacs compat alias user-original-login-name obsolete
2020-08-16 10:17 ` Lars Ingebrigtsen
@ 2020-08-16 13:41 ` Stefan Kangas
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Kangas @ 2020-08-16 13:41 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 42874
close 42874 28.1
thanks
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Sounds good to me.
Thanks. So I pushed it to master as commit b06ef8d5e9.
If anyone disagrees, feel free to revert.
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-16 13:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-15 3:10 bug#42874: [PATCH] Mark XEmacs compat alias user-original-login-name obsolete Stefan Kangas
2020-08-16 10:17 ` Lars Ingebrigtsen
2020-08-16 13:41 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).