* bug#59062: esh-var-test/alias test failures on Ubuntu 22.10
@ 2022-11-05 21:44 Paul Eggert
2022-11-05 22:36 ` Jim Porter
0 siblings, 1 reply; 3+ messages in thread
From: Paul Eggert @ 2022-11-05 21:44 UTC (permalink / raw)
To: 59062; +Cc: Jim Porter
[-- Attachment #1: Type: text/plain, Size: 511 bytes --]
This is on Ubuntu 22.10 x86-64, with current Emacs master (commit
8a49a888532c955ae81855636a65b446508cb361 dated today). "make check"
fails in some of the esh-var-test/alias tests. Some esh expertise (which
I don't have) would be of use in debugging this so I'm taking the
liberty of cc'ing Jim.
I'm attaching a copy of the build log (created with ./autogen.sh;
configure; make; make check) and of the test failure logged in
test/lisp/eshell/esh-var-tests.log. The build log is the same as in
Bug#59061.
[-- Attachment #2: build-log.gz --]
[-- Type: application/gzip, Size: 31397 bytes --]
[-- Attachment #3: esh-var-tests.log --]
[-- Type: text/x-log, Size: 9875 bytes --]
Running 85 tests (2022-11-05 12:09:26-0700, selector ‘(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))’)
Loading em-alias...
Loading em-banner...
Loading em-basic...
Loading em-cmpl...
Loading em-extpipe...
Loading em-glob...
Loading em-hist...
Loading em-ls...
Loading em-prompt...
Loading em-script...
Loading em-term...
Loading em-unix...
passed 1/85 esh-var-test/alias/export (0.017479 sec)
Test esh-var-test/alias/function backtrace:
signal(ert-test-failed (((should (eshell-match-output regexp)) :form
ert-fail(((should (eshell-match-output regexp)) :form (eshell-match-
(if (unwind-protect (setq value-2 (apply fn-0 args-1)) (setq form-de
(let (form-description-4) (if (unwind-protect (setq value-2 (apply f
(let ((value-2 'ert-form-evaluation-aborted-3)) (let (form-descripti
(let* ((fn-0 #'eshell-match-output) (args-1 (condition-case err (let
eshell-match-command-output("set ALIAS hello" "Variable `ALIAS' is n
#f(compiled-function () #<bytecode 0x1790e7e3ca4f140e>)()
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name esh-var-test/alias/function :document
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/eshell/esh-var-tests
command-line()
normal-top-level()
Test esh-var-test/alias/function condition:
(ert-test-failed
((should
(eshell-match-output regexp))
:form
(eshell-match-output "Variable `ALIAS' is not settable\n")
:value nil :explanation
(mismatched-output
(command "set ALIAS hello\n")
(output "Variable ‘ALIAS’ is not settable\n")
(regexp "Variable `ALIAS' is not settable\n"))))
FAILED 2/85 esh-var-test/alias/function (0.001406 sec) at lisp/eshell/esh-var-tests.el:498
passed 3/85 esh-var-test/alias/function-pair (0.001408 sec)
passed 4/85 esh-var-test/alias/local-variables (0.001848 sec)
passed 5/85 esh-var-test/alias/string (0.001257 sec)
passed 6/85 esh-var-test/alias/string/prefer-lisp (0.001166 sec)
passed 7/85 esh-var-test/alias/symbol (0.001204 sec)
Test esh-var-test/alias/symbol-pair backtrace:
signal(ert-test-failed (((should (eshell-match-output regexp)) :form
ert-fail(((should (eshell-match-output regexp)) :form (eshell-match-
(if (unwind-protect (setq value-2 (apply fn-0 args-1)) (setq form-de
(let (form-description-4) (if (unwind-protect (setq value-2 (apply f
(let ((value-2 'ert-form-evaluation-aborted-3)) (let (form-descripti
(let* ((fn-0 #'eshell-match-output) (args-1 (condition-case err (let
eshell-match-command-output("set ALIAS hello" "Variable `ALIAS' is n
#f(compiled-function () #<bytecode 0x15e131b20744b6ce>)()
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name esh-var-test/alias/symbol-pair :docum
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/eshell/esh-var-tests
command-line()
normal-top-level()
Test esh-var-test/alias/symbol-pair condition:
(ert-test-failed
((should
(eshell-match-output regexp))
:form
(eshell-match-output "Variable `ALIAS' is not settable\n")
:value nil :explanation
(mismatched-output
(command "set ALIAS hello\n")
(output "Variable ‘ALIAS’ is not settable\n")
(regexp "Variable `ALIAS' is not settable\n"))))
FAILED 8/85 esh-var-test/alias/symbol-pair (0.001254 sec) at lisp/eshell/esh-var-tests.el:556
passed 9/85 esh-var-test/columns-var (0.000616 sec)
passed 10/85 esh-var-test/export (0.000808 sec)
passed 11/85 esh-var-test/inside-emacs-var (0.002582 sec)
passed 12/85 esh-var-test/inside-emacs-var-split-indices (0.001403 sec)
passed 13/85 esh-var-test/interp-cmd (0.002026 sec)
passed 14/85 esh-var-test/interp-cmd-external (0.102139 sec)
passed 15/85 esh-var-test/interp-cmd-external-indices (0.102238 sec)
passed 16/85 esh-var-test/interp-cmd-indices (0.001348 sec)
passed 17/85 esh-var-test/interp-concat-cmd (0.156509 sec)
passed 18/85 esh-var-test/interp-concat-cmd-external (0.102518 sec)
passed 19/85 esh-var-test/interp-concat-cmd2 (0.002290 sec)
passed 20/85 esh-var-test/interp-concat-lisp (0.000913 sec)
passed 21/85 esh-var-test/interp-concat-lisp2 (0.000896 sec)
passed 22/85 esh-var-test/interp-convert-cmd-multiline (0.002379 sec)
passed 23/85 esh-var-test/interp-convert-cmd-number (0.000844 sec)
passed 24/85 esh-var-test/interp-convert-cmd-split-indices (0.001783 sec)
passed 25/85 esh-var-test/interp-convert-cmd-string-newline (0.000765 sec)
passed 26/85 esh-var-test/interp-convert-quoted-var-number (0.002527 sec)
passed 27/85 esh-var-test/interp-convert-quoted-var-split-indices (0.001305 sec)
passed 28/85 esh-var-test/interp-convert-var-number (0.000889 sec)
passed 29/85 esh-var-test/interp-convert-var-split-indices (0.002149 sec)
passed 30/85 esh-var-test/interp-lisp (0.000868 sec)
passed 31/85 esh-var-test/interp-lisp-indices (0.000873 sec)
passed 32/85 esh-var-test/interp-quoted-var (0.001059 sec)
passed 33/85 esh-var-test/interp-quoted-var-concat (0.001095 sec)
passed 34/85 esh-var-test/interp-temp-cmd (0.003082 sec)
passed 35/85 esh-var-test/interp-var (0.000633 sec)
passed 36/85 esh-var-test/interp-var-assoc (0.001136 sec)
passed 37/85 esh-var-test/interp-var-indices (0.001567 sec)
passed 38/85 esh-var-test/interp-var-length-alist (0.001074 sec)
passed 39/85 esh-var-test/interp-var-length-list (0.001518 sec)
passed 40/85 esh-var-test/interp-var-length-string (0.000520 sec)
passed 41/85 esh-var-test/interp-var-regexp-split-indices (0.018394 sec)
passed 42/85 esh-var-test/interp-var-split-indices (0.001621 sec)
passed 43/85 esh-var-test/interp-var-string-split-indices (0.002244 sec)
passed 44/85 esh-var-test/last-arg-var (0.001750 sec)
passed 45/85 esh-var-test/last-arg-var-indices (0.003319 sec)
passed 46/85 esh-var-test/last-arg-var-split-indices (0.003537 sec)
passed 47/85 esh-var-test/last-result-var (0.002030 sec)
passed 48/85 esh-var-test/last-result-var-ext-cmd (0.205256 sec)
passed 49/85 esh-var-test/last-result-var-split-indices (0.003941 sec)
passed 50/85 esh-var-test/last-result-var-twice (0.001869 sec)
passed 51/85 esh-var-test/last-status-var-ext-cmd (0.204866 sec)
passed 52/85 esh-var-test/last-status-var-lisp-command (0.003518 sec)
passed 53/85 esh-var-test/last-status-var-lisp-form (0.001730 sec)
passed 54/85 esh-var-test/last-status-var-lisp-form-2 (0.001778 sec)
passed 55/85 esh-var-test/lines-var (0.000552 sec)
passed 56/85 esh-var-test/local-variables (0.001727 sec)
passed 57/85 esh-var-test/path-var/local-directory (0.000951 sec)
Tramp: Sending command ‘exec sh -i’
Tramp: Found remote shell prompt on ‘wing’
passed 58/85 esh-var-test/path-var/preserve-across-hosts (0.041571 sec)
passed 59/85 esh-var-test/path-var/remote-directory (0.003993 sec)
passed 60/85 esh-var-test/path-var/set (0.001340 sec)
passed 61/85 esh-var-test/path-var/set-locally (0.002811 sec)
passed 62/85 esh-var-test/quoted-interp-concat-cmd (0.001027 sec)
passed 63/85 esh-var-test/quoted-interp-convert-cmd-multiline (0.000978 sec)
passed 64/85 esh-var-test/quoted-interp-convert-cmd-number (0.000934 sec)
passed 65/85 esh-var-test/quoted-interp-convert-cmd-split-indices (0.001073 sec)
passed 66/85 esh-var-test/quoted-interp-convert-cmd-string-newline (0.001830 sec)
passed 67/85 esh-var-test/quoted-interp-convert-quoted-var-number (0.002146 sec)
passed 68/85 esh-var-test/quoted-interp-convert-quoted-var-split-indices (0.001616 sec)
passed 69/85 esh-var-test/quoted-interp-convert-var-number (0.001060 sec)
passed 70/85 esh-var-test/quoted-interp-convert-var-split-indices (0.001638 sec)
passed 71/85 esh-var-test/quoted-interp-quoted-var (0.001471 sec)
passed 72/85 esh-var-test/quoted-interp-var (0.000987 sec)
passed 73/85 esh-var-test/quoted-interp-var-assoc (0.001496 sec)
passed 74/85 esh-var-test/quoted-interp-var-indices (0.002284 sec)
passed 75/85 esh-var-test/quoted-interp-var-length-alist (0.001229 sec)
passed 76/85 esh-var-test/quoted-interp-var-length-list (0.001953 sec)
passed 77/85 esh-var-test/quoted-interp-var-length-string (0.000624 sec)
passed 78/85 esh-var-test/quoted-interp-var-regexp-split-indices (0.003363 sec)
passed 79/85 esh-var-test/quoted-interp-var-split-indices (0.001457 sec)
passed 80/85 esh-var-test/quoted-interp-var-string-split-indices (0.003559 sec)
passed 81/85 esh-var-test/set/env-var (0.001295 sec)
passed 82/85 esh-var-test/set/symbol (0.000613 sec)
passed 83/85 esh-var-test/setq (0.000590 sec)
passed 84/85 esh-var-test/unset/env-var (0.000786 sec)
passed 85/85 esh-var-test/unset/symbol (0.000515 sec)
Ran 85 tests, 83 results as expected, 2 unexpected (2022-11-05 12:09:27-0700, 1.183612 sec)
2 unexpected results:
FAILED esh-var-test/alias/function
FAILED esh-var-test/alias/symbol-pair
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#59062: esh-var-test/alias test failures on Ubuntu 22.10
2022-11-05 21:44 bug#59062: esh-var-test/alias test failures on Ubuntu 22.10 Paul Eggert
@ 2022-11-05 22:36 ` Jim Porter
2022-11-06 14:53 ` Stefan Kangas
0 siblings, 1 reply; 3+ messages in thread
From: Jim Porter @ 2022-11-05 22:36 UTC (permalink / raw)
To: Paul Eggert, 59062
On 11/5/2022 2:44 PM, Paul Eggert wrote:
> This is on Ubuntu 22.10 x86-64, with current Emacs master (commit
> 8a49a888532c955ae81855636a65b446508cb361 dated today). "make check"
> fails in some of the esh-var-test/alias tests. Some esh expertise (which
> I don't have) would be of use in debugging this so I'm taking the
> liberty of cc'ing Jim.
This is the relevant bit:
(ert-test-failed
((should
(eshell-match-output regexp))
:form
(eshell-match-output "Variable `ALIAS' is not settable\n")
:value nil :explanation
(mismatched-output
(command "set ALIAS hello\n")
(output "Variable ‘ALIAS’ is not settable\n")
(regexp "Variable `ALIAS' is not settable\n"))))
It says the output has curved ‘’ quotes, but the regexp used to match
the output uses `' quotes. I've never seen that fail locally, though I
usually run "make -C test check-lisp-eshell". Maybe some setting (or
other test) is messing with the way `' quotes get printed, which
confuses the Eshell tests?
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#59062: esh-var-test/alias test failures on Ubuntu 22.10
2022-11-05 22:36 ` Jim Porter
@ 2022-11-06 14:53 ` Stefan Kangas
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Kangas @ 2022-11-06 14:53 UTC (permalink / raw)
To: Jim Porter, Paul Eggert, 59062-done
Jim Porter <jporterbugs@gmail.com> writes:
> This is the relevant bit:
>
> (ert-test-failed
> ((should
> (eshell-match-output regexp))
> :form
> (eshell-match-output "Variable `ALIAS' is not settable\n")
> :value nil :explanation
> (mismatched-output
> (command "set ALIAS hello\n")
> (output "Variable ‘ALIAS’ is not settable\n")
> (regexp "Variable `ALIAS' is not settable\n"))))
>
> It says the output has curved ‘’ quotes, but the regexp used to match
> the output uses `' quotes. I've never seen that fail locally, though I
> usually run "make -C test check-lisp-eshell". Maybe some setting (or
> other test) is messing with the way `' quotes get printed, which
> confuses the Eshell tests?
This should now be fixed on master (commit 2ea9f69f07), so I'm closing
the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-06 14:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-05 21:44 bug#59062: esh-var-test/alias test failures on Ubuntu 22.10 Paul Eggert
2022-11-05 22:36 ` Jim Porter
2022-11-06 14:53 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).