From: Stefan Kangas <stefan@marxist.se>
To: stardiviner <numbchild@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 29533@debbugs.gnu.org
Subject: bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list
Date: Thu, 14 May 2020 07:40:54 -0700 [thread overview]
Message-ID: <CADwFkm=CaeCi-1bi+hxwmhdQZ3QO9yS+9U2TjU3va_dtxv4=RA@mail.gmail.com> (raw)
In-Reply-To: <8736839odz.fsf@gmail.com>
stardiviner <numbchild@gmail.com> writes:
> + (mapcar 'car erc-join-channels-alist))
> lisp/erc/erc.el:4048: indent with spaces.
> + erc-join-channels-alist)))))
> ```
>
> I didi an google search, but still don't know how to set this. Shouldn't it be
> space-indented?
Yes, you should prefer indenting with spaces for the most part.
Maybe there is something in your local git configuration that is causing
this?
> And here is my patch diff. How should I submit this patch to Emacs/erc ?
You should ideally send the patch as an attached file produced by:
git format-patch -1 HEAD
Also, we have some requirements for contributions, such as including a
ChangeLog entry. This is described in the CONTRIBUTE file, and you can
also see examples in the git log. (You can use `C-x 4 a' so you don't
have to type as much.)
Are there any changes that needs doing in the manual? Should this be
announced in etc/NEWS?
Best regards,
Stefan Kangas
next prev parent reply other threads:[~2020-05-14 14:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <e987db8a-fcf6-da73-d914-1deb358b08d3@gmail.com>
2017-12-02 5:44 ` bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list stardiviner
2019-10-23 9:21 ` Lars Ingebrigtsen
2020-05-04 12:07 ` Stefan Kangas
2020-05-04 12:38 ` stardiviner
2020-05-04 13:12 ` Stefan Kangas
2020-05-12 5:36 ` stardiviner
2020-05-12 12:48 ` Stefan Kangas
2020-05-13 8:41 ` stardiviner
2020-05-13 11:37 ` stardiviner
2020-05-13 12:32 ` Stefan Kangas
2020-05-14 3:38 ` stardiviner
2020-05-14 14:40 ` Stefan Kangas [this message]
2020-05-18 12:21 ` stardiviner
2020-05-19 0:15 ` Stefan Kangas
2020-08-03 8:51 ` Lars Ingebrigtsen
2020-08-03 13:47 ` bug#29533: [CLOSED] " numbchild
2020-08-04 8:48 ` Lars Ingebrigtsen
2020-05-13 14:29 ` Noam Postavsky
2020-05-14 3:32 ` stardiviner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=CaeCi-1bi+hxwmhdQZ3QO9yS+9U2TjU3va_dtxv4=RA@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=29533@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=numbchild@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).