From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list Date: Thu, 14 May 2020 07:40:54 -0700 Message-ID: References: <87eez3kebf.fsf@gnus.org> <87v9lbykbp.fsf@stefankangas.se> <87tv0veuyh.fsf@gmail.com> <87eerzyhbi.fsf@stefankangas.se> <87r1vpogto.fsf@gmail.com> <87ftc4ukv1.fsf@gmail.com> <8736839odz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="60607"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 29533@debbugs.gnu.org To: stardiviner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 14 17:05:37 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jZFQV-000FdF-QA for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 May 2020 17:05:35 +0200 Original-Received: from localhost ([::1]:47732 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZFQU-0002EY-Pm for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 May 2020 11:05:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42424) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZF3i-0007YD-Df for bug-gnu-emacs@gnu.org; Thu, 14 May 2020 10:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51070) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZF3i-0002Tw-2J for bug-gnu-emacs@gnu.org; Thu, 14 May 2020 10:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jZF3i-0005sF-02 for bug-gnu-emacs@gnu.org; Thu, 14 May 2020 10:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 May 2020 14:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29533 X-GNU-PR-Package: emacs Original-Received: via spool by 29533-submit@debbugs.gnu.org id=B29533.158946726222492 (code B ref 29533); Thu, 14 May 2020 14:42:01 +0000 Original-Received: (at 29533) by debbugs.gnu.org; 14 May 2020 14:41:02 +0000 Original-Received: from localhost ([127.0.0.1]:34381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZF2j-0005qY-Uj for submit@debbugs.gnu.org; Thu, 14 May 2020 10:41:02 -0400 Original-Received: from mail-yb1-f174.google.com ([209.85.219.174]:36440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZF2i-0005q6-Hm for 29533@debbugs.gnu.org; Thu, 14 May 2020 10:41:00 -0400 Original-Received: by mail-yb1-f174.google.com with SMTP id a10so1667089ybc.3 for <29533@debbugs.gnu.org>; Thu, 14 May 2020 07:41:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=eAC4pn+hwicuJpUWNA6ubce4k7Yq8rqrniaSyUOJzA4=; b=GrhfDT0hm/kSOf2PH8yNp7lmL6MYICN56BPC1J/M4mb8ikubdfXfDI1+Td01yiqImG +ALxt+3OgTIf4CwQ+UtDUeku32qsP4JIqHwNPNcg3tUFwjKfB9n4O+qYSRweFb8h4Imm iXUZEvDAhsCr3pWi2fktU2ABITaSqBcs561bUAOEYnK6yGJ4sX5pPWSowh/u2uLY+Czr 0Hys9qCkOrTGy1fXbmHzMbomJlOkj24ueaWRoEOcRrNLUDbo0xKmBuJdJRHyVwktAoAg zHVjEL/9QdQmquFAcTeUNcgO3gBndNUXXyr+l+O28B2TBCtUsF/3bCRImst7zxm3KPE4 p3VA== X-Gm-Message-State: AOAM532f0YcOC1hl3RJ+ppIxeUt0niDQlA7OBveFQJgEOgkEJlUo4jyY JjlTpJyfqTZqLzUlVgzJH30rph3UlEoGrytyq8I= X-Google-Smtp-Source: ABdhPJwXeC56xniOHk0diyTbteku+NpNsGnHoh242KW2X/lpPP8QhG3XfFMEwnGKfVFBM0Fbns/90v7PgrLfe8G6LS0= X-Received: by 2002:a25:bb08:: with SMTP id z8mr7730878ybg.129.1589467254967; Thu, 14 May 2020 07:40:54 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 14 May 2020 07:40:54 -0700 In-Reply-To: <8736839odz.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180214 Archived-At: stardiviner writes: > + (mapcar 'car erc-join-channels-alist)) > lisp/erc/erc.el:4048: indent with spaces. > + erc-join-channels-alist))))) > ``` > > I didi an google search, but still don't know how to set this. Shouldn't it be > space-indented? Yes, you should prefer indenting with spaces for the most part. Maybe there is something in your local git configuration that is causing this? > And here is my patch diff. How should I submit this patch to Emacs/erc ? You should ideally send the patch as an attached file produced by: git format-patch -1 HEAD Also, we have some requirements for contributions, such as including a ChangeLog entry. This is described in the CONTRIBUTE file, and you can also see examples in the git log. (You can use `C-x 4 a' so you don't have to type as much.) Are there any changes that needs doing in the manual? Should this be announced in etc/NEWS? Best regards, Stefan Kangas