unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: "André A. Gomes" <andremegafone@gmail.com>
Cc: 50852@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
Subject: bug#50852: [PATCH] Fix search of the look program.
Date: Sat, 30 Oct 2021 09:09:34 -0700	[thread overview]
Message-ID: <CADwFkm=0vbbzYBwe3_RWmmHN-+EvE-UGRfucy_FvV-fPquywYg@mail.gmail.com> (raw)
In-Reply-To: <87h7e56qil.fsf@gmail.com> ("André A. Gomes"'s message of "Tue, 28 Sep 2021 11:41:38 +0300")

André A. Gomes <andremegafone@gmail.com> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Lars Ingebrigtsen <larsi@gnus.org>
>>> Cc: Stefan Kangas <stefan@marxist.se>,  andremegafone@gmail.com,
>>>   50852@debbugs.gnu.org
>>> Date: Tue, 28 Sep 2021 08:11:18 +0200
>>>
>>> Eli Zaretskii <eliz@gnu.org> writes:
>>>
>>> > In this case, why not simply have the value as "look" with no leading
>>> > directories?  If the program is installed, it will be found when it's
>>> > invoked, and if it isn't installed, the user gets an error message at
>>> > that time.
>>>
>>> That's a good point.  And the ispell-look-p variable is itself rather
>>> odd -- why have both ispell-look-command and that variable (with a
>>> non-standard name)?
>>
>> Right.  The existence of "look" should IMO be tested as part of
>> ispell-lookup-words, not when the package loads.  Then the command
>> could decide whether to use "look" or Grep at that time, and the need
>> for the ispell-look-p variable would disappear.
>
> You're both right.  I was actually silly.  I can prepare a patch
> following these ideas.

It seems like we are still waiting for this patch.  So here's a friendly
reminder to take a look at this when you find some time.  :-)

Thanks in advance.





  parent reply	other threads:[~2021-10-30 16:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 18:45 bug#50852: [PATCH] Fix search of the look program André A. Gomes
2021-09-27 23:56 ` Stefan Kangas
2021-09-28  6:07   ` Eli Zaretskii
2021-09-28  6:11     ` Lars Ingebrigtsen
2021-09-28  7:15       ` Eli Zaretskii
2021-09-28  8:41         ` André A. Gomes
2021-09-28  9:15           ` Eli Zaretskii
2021-10-30 16:09           ` Stefan Kangas [this message]
2021-09-28  8:32   ` André A. Gomes
2021-09-28 11:06     ` Stefan Kangas
2022-09-02 11:35       ` Lars Ingebrigtsen
2021-09-28  5:54 ` Lars Ingebrigtsen
2021-09-28  9:02   ` André A. Gomes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=0vbbzYBwe3_RWmmHN-+EvE-UGRfucy_FvV-fPquywYg@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=50852@debbugs.gnu.org \
    --cc=andremegafone@gmail.com \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).