From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#50852: [PATCH] Fix search of the look program. Date: Sat, 30 Oct 2021 09:09:34 -0700 Message-ID: References: <87wnn17t85.fsf@gmail.com> <8335ppkzc1.fsf@gnu.org> <87ilylfcvt.fsf@gnus.org> <83v92ljhmt.fsf@gnu.org> <87h7e56qil.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13123"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 50852@debbugs.gnu.org, Lars Ingebrigtsen To: =?UTF-8?Q?Andr=C3=A9?= A. Gomes Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 30 18:10:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mgqw4-0003De-Uy for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Oct 2021 18:10:24 +0200 Original-Received: from localhost ([::1]:39750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgqw3-0002aM-CG for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Oct 2021 12:10:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgqvi-0002UA-FA for bug-gnu-emacs@gnu.org; Sat, 30 Oct 2021 12:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46718) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mgqvi-0003no-6r for bug-gnu-emacs@gnu.org; Sat, 30 Oct 2021 12:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mgqvh-0002NM-Sd for bug-gnu-emacs@gnu.org; Sat, 30 Oct 2021 12:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Oct 2021 16:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50852 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch moreinfo Original-Received: via spool by 50852-submit@debbugs.gnu.org id=B50852.16356101849096 (code B ref 50852); Sat, 30 Oct 2021 16:10:01 +0000 Original-Received: (at 50852) by debbugs.gnu.org; 30 Oct 2021 16:09:44 +0000 Original-Received: from localhost ([127.0.0.1]:58264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgqvP-0002Me-UG for submit@debbugs.gnu.org; Sat, 30 Oct 2021 12:09:44 -0400 Original-Received: from mail-pg1-f182.google.com ([209.85.215.182]:39927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgqvM-0002ML-Ew for 50852@debbugs.gnu.org; Sat, 30 Oct 2021 12:09:41 -0400 Original-Received: by mail-pg1-f182.google.com with SMTP id g184so12875273pgc.6 for <50852@debbugs.gnu.org>; Sat, 30 Oct 2021 09:09:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc :content-transfer-encoding; bh=5k7cIUfPl9B26ftD37E1Kl7hhEy5xiX2/Rkr9PyWglw=; b=cwC+V5cvHAZhLwVt6opm+HI2FcYhI/kv5sU9LFLgwAy/psoqej9d1mVivTJQVx0b5P 9IW0d4d80vE7VHI/mlxoCHcEipVHovqOAHtpdD//bHHCdRiWV+xsVEShAjtPMU34tSTh RfyYNtxkxZ1CO4v6SLdS8bp1OsBLF1LeKLB5ELIRmA3KYwFcAHmomehwDC7oYm74lUw+ 1HJT/lDRw7FPgdTlMn0fMIYEpnsSLTd2JgDJEx5JtF7R+wFnrp8bP0oyWW7JdIb/5d9F /JMj0X2Mku6oAN0rF9zmfvtFPzGreUSS2ivdKU7F/S3xQwk23bQbzI3oPryw2GJJQe1r razA== X-Gm-Message-State: AOAM53196fjE4G/CI9NDiZJaC9WMwhoHHHlNNk4FfdrRWbV3I6AdGSo4 gz5R4vKnqukv/VusHYctnKCQTT6Wc8PnUZ95pRs= X-Google-Smtp-Source: ABdhPJyaKZhTmKw9I94sUoHLtdjsqNjoXgJdaGcisi0+hBAooCyyvut+8Bltzh4WI2D5O7JCmpT1Egjxe28sGaD74J4= X-Received: by 2002:a63:330f:: with SMTP id z15mr13523591pgz.42.1635610174922; Sat, 30 Oct 2021 09:09:34 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 30 Oct 2021 09:09:34 -0700 In-Reply-To: <87h7e56qil.fsf@gmail.com> ("=?UTF-8?Q?Andr=C3=A9?= A. Gomes"'s message of "Tue, 28 Sep 2021 11:41:38 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218624 Archived-At: Andr=C3=A9 A. Gomes writes: > Eli Zaretskii writes: > >>> From: Lars Ingebrigtsen >>> Cc: Stefan Kangas , andremegafone@gmail.com, >>> 50852@debbugs.gnu.org >>> Date: Tue, 28 Sep 2021 08:11:18 +0200 >>> >>> Eli Zaretskii writes: >>> >>> > In this case, why not simply have the value as "look" with no leading >>> > directories? If the program is installed, it will be found when it's >>> > invoked, and if it isn't installed, the user gets an error message at >>> > that time. >>> >>> That's a good point. And the ispell-look-p variable is itself rather >>> odd -- why have both ispell-look-command and that variable (with a >>> non-standard name)? >> >> Right. The existence of "look" should IMO be tested as part of >> ispell-lookup-words, not when the package loads. Then the command >> could decide whether to use "look" or Grep at that time, and the need >> for the ispell-look-p variable would disappear. > > You're both right. I was actually silly. I can prepare a patch > following these ideas. It seems like we are still waiting for this patch. So here's a friendly reminder to take a look at this when you find some time. :-) Thanks in advance.