* bug#11167: trunk; term.el inserts newline when erasing-to-eol [PATCH]
@ 2012-04-04 6:06 Geoff Jacobsen
2012-11-30 7:48 ` Chong Yidong
0 siblings, 1 reply; 3+ messages in thread
From: Geoff Jacobsen @ 2012-04-04 6:06 UTC (permalink / raw)
To: 11167
[-- Attachment #1: Type: text/plain, Size: 704 bytes --]
When term.el receives a "^[[K" erase-end-of-line the term-erase-in-line
function inserts a new line.
When variable term-scroll-show-maximum-output is set to t this can result
in a blank line at the bottom of the buffer.
This breaks programs such as less which won't display the top line.
I can't see the purpose for the new-line. The following patch removes it.
=== modified file 'lisp/term.el'
--- lisp/term.el 2012-01-26 02:32:56 +0000
+++ lisp/term.el 2012-04-04 05:26:53 +0000
@@ -3751,7 +3751,6 @@
;; extra space when wrapped is false.
(when wrapped
(insert ? ))
- (insert ?\n)
(put-text-property saved-point (point) 'face 'default)
(goto-char saved-point))))
[-- Attachment #2: Type: text/html, Size: 1163 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* bug#11167: trunk; term.el inserts newline when erasing-to-eol [PATCH]
2012-04-04 6:06 bug#11167: trunk; term.el inserts newline when erasing-to-eol [PATCH] Geoff Jacobsen
@ 2012-11-30 7:48 ` Chong Yidong
2012-12-05 23:36 ` Geoff Jacobsen
0 siblings, 1 reply; 3+ messages in thread
From: Chong Yidong @ 2012-11-30 7:48 UTC (permalink / raw)
To: Geoff Jacobsen; +Cc: 11167
Geoff Jacobsen <geoffjacobsen@gmail.com> writes:
> When term.el receives a "^[[K" erase-end-of-line the
> term-erase-in-line function inserts a new line.
>
> When variable term-scroll-show-maximum-output is set to t this can
> result in a blank line at the bottom of the buffer.
>
> This breaks programs such as less which won't display the top line.
>
> I can't see the purpose for the new-line. The following patch removes
> it.
Sorry for the late response. Do you have a simple recipe demonstrating
the problem? I can't reproduce any problem with "less", which seems to
display fine (including the top line) under term mode.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#11167: trunk; term.el inserts newline when erasing-to-eol [PATCH]
2012-11-30 7:48 ` Chong Yidong
@ 2012-12-05 23:36 ` Geoff Jacobsen
0 siblings, 0 replies; 3+ messages in thread
From: Geoff Jacobsen @ 2012-12-05 23:36 UTC (permalink / raw)
To: Chong Yidong; +Cc: 11167
[-- Attachment #1: Type: text/plain, Size: 909 bytes --]
On 30 November 2012 20:48, Chong Yidong <cyd@gnu.org> wrote:
> Geoff Jacobsen <geoffjacobsen@gmail.com> writes:
>
> > When term.el receives a "^[[K" erase-end-of-line the
> > term-erase-in-line function inserts a new line.
> >
> > When variable term-scroll-show-maximum-output is set to t this can
> > result in a blank line at the bottom of the buffer.
> >
> > This breaks programs such as less which won't display the top line.
> >
> > I can't see the purpose for the new-line. The following patch removes
> > it.
>
> Sorry for the late response. Do you have a simple recipe demonstrating
> the problem? I can't reproduce any problem with "less", which seems to
> display fine (including the top line) under term mode.
>
I can't reproduce the problem now either; I am running a later version of
emacs (24.1.1) than when I reported the bug.
Please close the bug report.
Thank you
Kind regards
Geoff
[-- Attachment #2: Type: text/html, Size: 1442 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-05 23:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-04 6:06 bug#11167: trunk; term.el inserts newline when erasing-to-eol [PATCH] Geoff Jacobsen
2012-11-30 7:48 ` Chong Yidong
2012-12-05 23:36 ` Geoff Jacobsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).