* bug#48594: FYI Djvu package extension with svg annotations
@ 2021-05-22 22:27 dalanicolai
2022-07-15 10:18 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: dalanicolai @ 2021-05-22 22:27 UTC (permalink / raw)
To: 48594
[-- Attachment #1: Type: text/plain, Size: 1981 bytes --]
I have tried to inform you about this before by replying to an old
bug-report, but it seems that that did not work out well.
I will paste the text of that message below (with some updates)
Hi Roland,
I have made a small modification to the djvu-image function so that it
displays annotations. The code can be found here
<https://github.com/dalanicolai/djvu3/blob/main/djvu.el> (a small comment
follows)
Although I had extended djvu.el already with some nice extra features in
djvu2 <https://github.com/dalanicolai/djvu2.el>, those extensions mainly
relied on the usage of the external imagemagick command.
This time however, I have used Emacs capability of drawing svg files. I
have simply embedded the ppm in an svg image and subsequently we can use
svg.el to draw annotations.
To test it you can just load the file after you loaded the original djvu.el
and then open some djvu with annotations.
I think the annotation part is quite clean code, and it is really just a
small modification.
Additionally in the section *Keyboard annotation functionality* I have
added a quite fancy function to make highlights with the keyboard.
You can test it after loading the file by using the command
*djvu-keyboard-annot*.
It is up to you if you also like to implement that. If you like to
implement any of this in djvu.el, then I could make a patch.
Or you can just copy the code and do with it whatever you like.
Additionally I have a small question (to anyone receiving this mail)
I wanted to keep the annotation draw functionality in a separate function
outside of the djvu-image function, but then I had to pass all the local
variabels,
Do you happen to know some (closure like?) trick to pass the local
variables while defining the function outside of the djvu-image function
(so without passing the variables explicitly as arguments)?
I forgot to mention that that keyboard annotation function is meant to be
handy for annotating directly from djvu-image-mode...
Thanks again!
[-- Attachment #2: Type: text/html, Size: 2437 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#48594: FYI Djvu package extension with svg annotations
2021-05-22 22:27 bug#48594: FYI Djvu package extension with svg annotations dalanicolai
@ 2022-07-15 10:18 ` Lars Ingebrigtsen
2022-07-15 10:45 ` Visuwesh
0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2022-07-15 10:18 UTC (permalink / raw)
To: dalanicolai; +Cc: 48594
dalanicolai <dalanicolai@gmail.com> writes:
> I have made a small modification to the djvu-image function so that it
> displays annotations. The code can be found here (a small comment
> follows)
(I'm going through old bug reports that unfortunately weren't resolved
at the time.)
This pointed to
https://github.com/dalanicolai/djvu3/blob/main/djvu.el
which no longer exists. Has the code moved somewhere else, or is this
no longer relevant?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#48594: FYI Djvu package extension with svg annotations
2022-07-15 10:18 ` Lars Ingebrigtsen
@ 2022-07-15 10:45 ` Visuwesh
2022-07-15 11:11 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Visuwesh @ 2022-07-15 10:45 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: dalanicolai, 48594
[வெள்ளி ஜூலை 15, 2022] Lars Ingebrigtsen wrote:
> dalanicolai <dalanicolai@gmail.com> writes:
>
>> I have made a small modification to the djvu-image function so that it
>> displays annotations. The code can be found here (a small comment
>> follows)
>
> (I'm going through old bug reports that unfortunately weren't resolved
> at the time.)
>
> This pointed to
>
> https://github.com/dalanicolai/djvu3/blob/main/djvu.el
>
> which no longer exists. Has the code moved somewhere else, or is this
> no longer relevant?
Looks like it was renamed to djvu3.el in that same repo. See commit
https://github.com/dalanicolai/djvu3/commit/03e601f28b2e4e6bec06050fa79c05f77b8b339d.
So the new link is
https://github.com/dalanicolai/djvu3/blob/main/djvu3.el
I think?
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#48594: FYI Djvu package extension with svg annotations
2022-07-15 10:45 ` Visuwesh
@ 2022-07-15 11:11 ` Lars Ingebrigtsen
2022-07-15 23:28 ` Roland Winkler
0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2022-07-15 11:11 UTC (permalink / raw)
To: Visuwesh; +Cc: dalanicolai, 48594, Roland Winkler
Visuwesh <visuweshm@gmail.com> writes:
> Looks like it was renamed to djvu3.el in that same repo. See commit
> https://github.com/dalanicolai/djvu3/commit/03e601f28b2e4e6bec06050fa79c05f77b8b339d.
>
> So the new link is
>
> https://github.com/dalanicolai/djvu3/blob/main/djvu3.el
Thanks. Perhaps Roland has some comments; added to the CCs.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#48594: FYI Djvu package extension with svg annotations
2022-07-15 11:11 ` Lars Ingebrigtsen
@ 2022-07-15 23:28 ` Roland Winkler
2022-07-16 9:59 ` dalanicolai
0 siblings, 1 reply; 6+ messages in thread
From: Roland Winkler @ 2022-07-15 23:28 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: dalanicolai, 48594, Visuwesh
On Fri, Jul 15 2022, Lars Ingebrigtsen wrote:
> Visuwesh <visuweshm@gmail.com> writes:
>
>> Looks like it was renamed to djvu3.el in that same repo. See commit
>> https://github.com/dalanicolai/djvu3/commit/03e601f28b2e4e6bec06050fa79c05f77b8b339d.
>>
>> So the new link is
>>
>> https://github.com/dalanicolai/djvu3/blob/main/djvu3.el
>
> Thanks. Perhaps Roland has some comments; added to the CCs.
I am not sure about this bug report. What bug is it about? What is the
goal?
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#48594: FYI Djvu package extension with svg annotations
2022-07-15 23:28 ` Roland Winkler
@ 2022-07-16 9:59 ` dalanicolai
0 siblings, 0 replies; 6+ messages in thread
From: dalanicolai @ 2022-07-16 9:59 UTC (permalink / raw)
To: Roland Winkler; +Cc: Lars Ingebrigtsen, 48594, Visuwesh
[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]
It was about this message
<https://lists.gnu.org/archive/html/bug-gnu-emacs/2021-05/msg01755.html>.
It was really only a notification about some additions I made to djvu.el,
so that it also renders annotations. I've made it available via djvu3.el
<https://github.com/dalanicolai/djvu3>. Although it would still be a nice
addition to djvu.el, it is not so relevant anymore as I am working on a
better reader <https://github.com/dalanicolai/emacs-papyrus> (as an updated
alternative to doc-view).
On Sat, 16 Jul 2022 at 01:29, Roland Winkler <winkler@gnu.org> wrote:
> On Fri, Jul 15 2022, Lars Ingebrigtsen wrote:
> > Visuwesh <visuweshm@gmail.com> writes:
> >
> >> Looks like it was renamed to djvu3.el in that same repo. See commit
> >>
> https://github.com/dalanicolai/djvu3/commit/03e601f28b2e4e6bec06050fa79c05f77b8b339d
> .
> >>
> >> So the new link is
> >>
> >> https://github.com/dalanicolai/djvu3/blob/main/djvu3.el
> >
> > Thanks. Perhaps Roland has some comments; added to the CCs.
>
> I am not sure about this bug report. What bug is it about? What is the
> goal?
>
[-- Attachment #2: Type: text/html, Size: 1871 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-16 9:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-22 22:27 bug#48594: FYI Djvu package extension with svg annotations dalanicolai
2022-07-15 10:18 ` Lars Ingebrigtsen
2022-07-15 10:45 ` Visuwesh
2022-07-15 11:11 ` Lars Ingebrigtsen
2022-07-15 23:28 ` Roland Winkler
2022-07-16 9:59 ` dalanicolai
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).