From: dalanicolai <dalanicolai@gmail.com>
To: martin rudalics <rudalics@gmx.at>
Cc: Michael Heerdegen <michael_heerdegen@web.de>, 54438@debbugs.gnu.org
Subject: bug#54438: 27.2; inconsistent-behavior-global-vs-local-hook
Date: Fri, 18 Mar 2022 10:12:48 +0100 [thread overview]
Message-ID: <CACJP=3n7wh++4spv082ivayWC9F=rJgnAo799Lqj5r116dCrDw@mail.gmail.com> (raw)
In-Reply-To: <CACJP=3=VtJGMt6L-C00Nxmebv61519D6j-ofuW0WHZMjBuSMTA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1847 bytes --]
And, moreover, the behavior for the global vs local hook is inconsistent...
On Fri, 18 Mar 2022 at 10:11, dalanicolai <dalanicolai@gmail.com> wrote:
> Thank you for the reply. Ah, sorry I forgot to remove the parens to
> include the `pop-to-buffer` within the defun.
>
> About the 'restoring mechanism'; the global hook seems not to restore the
> window selected before running the hook.
>
> So here are the two separated test cases (they both use the 'pop-up'
> function)
>
> (defun pop-up ()
> (pop-to-buffer "pop-up"))
>
> (defun test ()
> (interactive)
> (with-current-buffer (get-buffer-create "test")
> (add-hook 'window-configuration-change-hook #'pop-up)
> (pop-to-buffer "test")))
>
> ;; evaluate code to remove the (global) hook
> (remove-hook 'window-configuration-change-hook #'pop-up)
>
> (defun test ()
> (interactive)
> (with-current-buffer (get-buffer-create "test")
> (add-hook 'window-configuration-change-hook #'pop-up nil t)
> (pop-to-buffer "test")))
>
>
> So the 'restoring mechanism' works like you explained for the local hook
> but not for the global hook
> (where after calling 'test', the pop-up buffer will be selected).
>
> Also, I would expect that a hook just calls the hook function, and it
> would not 'restore the window
> selected before the hook'. I would say the restoring is undesired
> behavior.
>
>
>
> On Fri, 18 Mar 2022 at 09:37, martin rudalics <rudalics@gmx.at> wrote:
>
>> > I think it's a bad idea to do something that changes the window
>> > configuration in `window-configuration-change-hook'. It's not
>> > unexpected to get an infinite recursion or any other unpredictable
>> > behavior.
>>
>> People should avoid it in packages because they could easily step on
>> each other's toes. Written carefully, it could be useful in private
>> code.
>>
>> martin
>>
>
[-- Attachment #2: Type: text/html, Size: 2778 bytes --]
next prev parent reply other threads:[~2022-03-18 9:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 17:52 bug#54438: 27.2; inconsistent-behavior-global-vs-local-hook dalanicolai
2022-03-18 0:42 ` Michael Heerdegen
2022-03-18 8:37 ` martin rudalics
2022-03-18 9:11 ` dalanicolai
2022-03-18 9:12 ` dalanicolai [this message]
2022-03-18 9:58 ` martin rudalics
2022-03-18 12:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-18 17:03 ` dalanicolai
2022-03-18 8:36 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACJP=3n7wh++4spv082ivayWC9F=rJgnAo799Lqj5r116dCrDw@mail.gmail.com' \
--to=dalanicolai@gmail.com \
--cc=54438@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).