From: dalanicolai <dalanicolai@gmail.com>
To: Stefan Kangas <stefan@marxist.se>
Cc: 51371@debbugs.gnu.org
Subject: bug#51371: 28.0.50; [PATCH] Make list-colors-display sorting support general
Date: Mon, 25 Oct 2021 23:46:20 +0200 [thread overview]
Message-ID: <CACJP=3m5gnx6YKhpQmXFOP+q-xO9F5PBNctyyZsKsBWmLc=_Mw@mail.gmail.com> (raw)
In-Reply-To: <CADwFkmmCVG4jEF_ye8JjmNjgWkGWtnCG==L6+FPpSydT_DboJA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]
I see, it is called when setting the face foreground/background via the
customize menu.
I've tested it, and it works still perfectly fine (as expected...
predicting the expected
effects/implications in this case seems quite straightforward to me).
On Mon, 25 Oct 2021 at 00:08, Stefan Kangas <stefan@marxist.se> wrote:
> dalanicolai <dalanicolai@gmail.com> writes:
>
> > (@stefan Did not notice it was a group message)
> >
> > Not really, I think. But if so then I guess we could just call it with
> > list-colors-sort set to nil:
> > ```
> > (let ((list-colors-sort 'nil))
> ^ no need to quote nil, BTW.
> > (list-colors-display (mapcar #'car shr-color-html-colors-alist)
> > nil))
> > ```
>
> Do we have any data from e.g. GNU ELPA, MELPA, GitHub or something to
> back that up?
>
> I checked, and we have only one call to `list-colors-display' in the
> Emacs tree: in `widget-color--choose-action'. Does that function still
> work as it should with your patch?
>
[-- Attachment #2: Type: text/html, Size: 1530 bytes --]
next prev parent reply other threads:[~2021-10-25 21:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-24 9:35 bug#51371: 28.0.50; [PATCH] Make list-colors-display sorting support general dalanicolai
2021-10-24 12:47 ` Stefan Kangas
2021-10-24 13:16 ` dalanicolai
2021-10-24 13:18 ` dalanicolai
2021-10-24 22:08 ` Stefan Kangas
2021-10-25 21:46 ` dalanicolai [this message]
2021-10-30 15:40 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACJP=3m5gnx6YKhpQmXFOP+q-xO9F5PBNctyyZsKsBWmLc=_Mw@mail.gmail.com' \
--to=dalanicolai@gmail.com \
--cc=51371@debbugs.gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).