From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: dalanicolai Newsgroups: gmane.emacs.bugs Subject: bug#51371: 28.0.50; [PATCH] Make list-colors-display sorting support general Date: Mon, 25 Oct 2021 23:46:20 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000046e57405cf344ba9" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36240"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51371@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 25 23:47:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mf7oM-0009BP-1t for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Oct 2021 23:47:18 +0200 Original-Received: from localhost ([::1]:57470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mf7oK-0004iY-HE for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Oct 2021 17:47:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mf7o8-0004iN-SN for bug-gnu-emacs@gnu.org; Mon, 25 Oct 2021 17:47:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32969) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mf7o6-0000kw-8F for bug-gnu-emacs@gnu.org; Mon, 25 Oct 2021 17:47:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mf7o6-0003xL-6f for bug-gnu-emacs@gnu.org; Mon, 25 Oct 2021 17:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: dalanicolai Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Oct 2021 21:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51371 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51371-submit@debbugs.gnu.org id=B51371.163519839915174 (code B ref 51371); Mon, 25 Oct 2021 21:47:02 +0000 Original-Received: (at 51371) by debbugs.gnu.org; 25 Oct 2021 21:46:39 +0000 Original-Received: from localhost ([127.0.0.1]:44515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mf7nj-0003wf-0c for submit@debbugs.gnu.org; Mon, 25 Oct 2021 17:46:39 -0400 Original-Received: from mail-ua1-f51.google.com ([209.85.222.51]:46767) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mf7nh-0003wS-A1 for 51371@debbugs.gnu.org; Mon, 25 Oct 2021 17:46:37 -0400 Original-Received: by mail-ua1-f51.google.com with SMTP id x3so5885560uar.13 for <51371@debbugs.gnu.org>; Mon, 25 Oct 2021 14:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FutOsKUtKhOwgGZAvdQtV6V6n+1nBIra8JNyRC9eA7U=; b=Lx24GDt+hkZdRRN9Ho/D5M20MVoNdTPuxdXdOHwTWjFoKcF7ckNi142dB3aYQZCJMS JD6WbnqKnUIj4IQ6yshEsNl2vJpjvhKCGu7rCWC+f40gHF7RG3x67Ux0WLM590/ZuZk+ Hwys9QagRW2WSdd8DBjnbQmLKZO9QnmSTet8q0gG1TAxlY0D/PgoPBSUqZ3ZzdzVgebz gIL3OnJCiCH/eokPXSBcoZ85HWTLOumFFoRa+HD5VH7td1iQlcqK9i0qLCIQfEr2FUxP BA+IQvKuVnjc4SeZa67/xiUVE3ko1qUMRtFtkiUfjMYoDrxdEm5E0bFNcR0QS9urT3B4 We1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FutOsKUtKhOwgGZAvdQtV6V6n+1nBIra8JNyRC9eA7U=; b=iPBUDRuSZ9DTjdA/IrSbTMMmHS/GwHuCP08OkV8wjTuRj7xRpbUWFZDU7pAeyhqWNP HYJyvuoABY/aCXkcbpxZae6vobGBOMCr/RYT/aBpG3WFVKhyViaZNy5fqMjG3V4GXNtC 5JAub1FgT5GhbW/bnQRTUSmEdYQ/7raEDtHSWdwlZ7Y9jLOUCE0ktqH88Imn1KkLlTFr FRD9bugjlYEmDeRq/BJSFCP2muHIrRf6np7dg2MQhjTiu2AGswfWcryoOTWUOrn9EmkS xeDGDOdi/XieWnDPjmftyeqaoUZ8i+9pei7lUN2HDmIVVIQpbhdQSx1FgH4n8S8gYwIh +Z4Q== X-Gm-Message-State: AOAM530/YVIG+LnF2YEPyQRisdsJTU5inofpXVzAhZpwY9F13v3ZHlTz 5J2cCp/tExMR4QtNj+7/RxQCM2YanYnANg9LeaKeObss4hY= X-Google-Smtp-Source: ABdhPJwWXlRZDUluKh9N8XPsBFY634OFa/wSm/cMs86US12MZ6ckwwR7attWdL18BdTH/oVZGUimleSArhjLlGwj3GI= X-Received: by 2002:ab0:6e8a:: with SMTP id b10mr11023895uav.134.1635198391738; Mon, 25 Oct 2021 14:46:31 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218348 Archived-At: --00000000000046e57405cf344ba9 Content-Type: text/plain; charset="UTF-8" I see, it is called when setting the face foreground/background via the customize menu. I've tested it, and it works still perfectly fine (as expected... predicting the expected effects/implications in this case seems quite straightforward to me). On Mon, 25 Oct 2021 at 00:08, Stefan Kangas wrote: > dalanicolai writes: > > > (@stefan Did not notice it was a group message) > > > > Not really, I think. But if so then I guess we could just call it with > > list-colors-sort set to nil: > > ``` > > (let ((list-colors-sort 'nil)) > ^ no need to quote nil, BTW. > > (list-colors-display (mapcar #'car shr-color-html-colors-alist) > > nil)) > > ``` > > Do we have any data from e.g. GNU ELPA, MELPA, GitHub or something to > back that up? > > I checked, and we have only one call to `list-colors-display' in the > Emacs tree: in `widget-color--choose-action'. Does that function still > work as it should with your patch? > --00000000000046e57405cf344ba9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I see, it is called when setting the face foreground/= background via the customize menu.
I've tested it, and it wor= ks still perfectly fine (as expected... predicting the expected
e= ffects/implications in this case seems quite straightforward to me).

On Mon, 25 Oct 2021 at 00:08, Stefan Kangas <stefan@marxist.se> wrote:
dalanicolai <dalanicolai@gmail.com> writes:

> (@stefan Did not notice it was a group message)
>
> Not really, I think. But if so then I guess we could just call it with=
> list-colors-sort set to nil:
> ```
> (let ((list-colors-sort 'nil))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 ^ no need to quote nil, BTW.
>=C2=A0 =C2=A0(list-colors-display (mapcar #'car shr-color-html-colo= rs-alist)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 nil))
> ```

Do we have any data from e.g. GNU ELPA, MELPA, GitHub or something to
back that up?

I checked, and we have only one call to `list-colors-display' in the Emacs tree: in `widget-color--choose-action'.=C2=A0 Does that function = still
work as it should with your patch?
--00000000000046e57405cf344ba9--