unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#21301: 25.0.50; Emacs Trunk:  Fringe bitmaps confuse foreground/background colors.
@ 2015-08-19 20:31 Keith David Bershatsky
  2015-08-21 13:47 ` Eli Zaretskii
                   ` (8 more replies)
  0 siblings, 9 replies; 20+ messages in thread
From: Keith David Bershatsky @ 2015-08-19 20:31 UTC (permalink / raw)
  To: 21301

The fringe bitmaps in Emacs Trunk seem to confuse the foreground/background colors -- the foreground is the 'default color no matter what, and the background takes on the color of what should have been the foreground.

For example, a particular fringe bitmap should have a yellow foreground and nothing set for the background -- the result is a yellow background and a 'default foreground (which in my case is white).

Thanks,

Keith

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

In GNU Emacs 25.0.50.1 (x86_64-apple-darwin10.8.0, NS appkit-1038.36 Version 10.6.8 (Build 10K549))
 of 2015-08-19 on server.local
Repository revision: ae7cfd0baf24fda984ff4c0631bcaa477ea11b7f
Windowing system distributor `Apple', version 10.3.1038
Configured using:
 `configure --with-ns --without-imagemagick'

Configured features:
DBUS ACL LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS

Important settings:
  locale-coding-system: utf-8-unix

Major mode: ELISP

Minor modes in effect:
  tb-mode: t
  sb-mode: t
  ml-mode: t
  fl-mode: t
  ds-mode: t
  sd-mode: t
  bc-mode: t
  +-mode: t
  buffer-read-only: t

Recent messages:
.0.emacs/.0.mail/msgdb/imap/mail.lawlist.com/lawlist/inbox/.wl-summary-cache
.0.emacs/.0.mail/msgdb/imap/mail.lawlist.com/lawlist/inbox/.wl-summary-line-format
.0.emacs/.0.mail/msgdb/imap/mail.lawlist.com/lawlist/inbox/.wl-summary-view
.0.emacs/.0.mail/msgdb/imap/mail.lawlist.com/lawlist/inbox/entity-75
.0.emacs/.0.mail/msgdb/imap/mail.lawlist.com/lawlist/inbox/entity-76
.
0.emacs/.0.mail/msgdb/imap/mail.lawlist.com/lawlist/inbox/flag
.0.emacs/.0.mail/msgdb/imap/mail.lawlist.com/lawlist/inbox/flag-table
.0.emacs/.0.mail/msgdb/imap/mail.lawlist.com/lawlist/inbox/killed
.0.emacs/.0.mail/msgdb/imap/mail.lawlist.com/lawlist/inbox/msgid

Load-path shadows:
None found.

Features:
(shadow emacsbug url-cache sort tabify network-stream nsm starttls
ps-mode ps-mule crm sendmail pp lawlist-ztree lawlist-yas lawlist-ws
lawlist-wl elmo-imap4 elmo-localdir modb-standard modb-legacy
elmo-internal elmo-flag mmelmo-imap mmelmo-buffer elsp-generic mel-u
ps-print ps-def lpr parse-time enriched lawlist-w3m browse-url
doc-view image-mode ccl lawlist-vl lawlist-view lawlist-undo
lawlist-txt lawlist-tm lawlist-tex compare-w lawlist-tabbar
lawlist-speedbar lawlist-shell info esh-groups ehelp ange-ftp
lawlist-sgml lawlist-sb lawlist-saveplace lawlist-ruler
lawlist-replace lawlist-rectangle lawlist-re-builder lawlist-python
skeleton lawlist-profiler lawlist-print lawlist-php lawlist-perl
lawlist-parens lawlist-org lawlist-calendar org-agenda org org-macro
org-footnote org-pcomplete org-list org-faces org-entities org-version
ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src
ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs
holidays hol-loaddefs cal-menu calendar cal-loaddefs lawlist-neotree
lawlist-movement lawlist-mouse lawlist-ml lawlist-minibuffer
lawlist-misc lawlist-messages lawlist-mc rect lawlist-markdown
noutline outline lawlist-lorem lawlist-ln lawlist-keymap lawlist-js
lawlist-ispell lawlist-isearch lawlist-imenu lawlist-ibuffer
lawlist-hl lawlist-grep lawlist-git ido eieio-compat view vc-git vc
vc-dispatcher url-http tls url url-proxy url-privacy url-expand
url-methods url-history mailcap url-auth url-cookie url-domsuf url-gw
thingatpt time-stamp server log-view log-edit message mml mml-sec
mm-decode mm-bodies mm-encode gmm-utils mailheader pcvs-util add-log
lawlist-help quail json grep compile find-lisp ediff-merg ediff-wind
ediff-diff ediff-mult ediff-help ediff-init ediff-util ediff ert
find-func ewoc eieio-base diff-mode conf-mode autorevert filenotify
lawlist-frame lawlist-frame-bufs lawlist-font-lock lawlist-fm
lawlist-env lawlist-elscreen lawlist-elisp lawlist-dv jka-compr
lawlist-image lawlist-files zeroconf url-util url-parse auth-source
eieio byte-opt bytecomp byte-compile cconv eieio-core password-cache
url-vars dbus xml lawlist-ds lawlist-dired epa epg epg-config
format-spec cl-seq edmacro kmacro dired lawlist-desktop frameset
lawlist-debug lawlist-window debug lawlist-css smie lawlist-compile rx
lawlist-color lawlist-cm lawlist-cc cl-extra seq cc-langs cc-mode
cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine
cc-vars cc-defs cc-bytecomp lawlist-calc lawlist-calccomp
lawlist-calcalg3 lawlist-calcalg2 lawlist-calc+ lawlist-bk lawlist-bc
lawlist-bbdb gnus gnus-ems nnheader gnus-util mail-utils wid-edit
mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mm-util help-fns
help-mode easymenu mail-prsvr mailabbrev mail-extr rfc822 cl timezone
lawlist-as lawlist-archive cl-macs gv cl-loaddefs pcase cl-lib
lawlist-+ disp-table easy-mmode derived advice shell pcomplete comint
ansi-color ring savehist time-date mule-util tooltip eldoc electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win
term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese
eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic
indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook
help simple abbrev minibuffer cl-preloaded nadvice loaddefs button
faces cus-face macroexp files text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote dbusbind cocoa ns multi-tty make-network-process emacs)

Memory information:
((conses 16 2220812 231898)
 (symbols 48 117908 62)
 (miscs 40 600 278)
 (strings 32 281603 93497)
 (string-bytes 1 10085414)
 (vectors 16 62862)
 (vector-slots 8 1980185 93488)
 (floats 8 3158 683)
 (intervals 56 2524 184)
 (buffers 976 33))





^ permalink raw reply	[flat|nested] 20+ messages in thread

* bug#21301: 25.0.50; Emacs Trunk:  Fringe bitmaps confuse foreground/background colors.
  2015-08-19 20:31 bug#21301: 25.0.50; Emacs Trunk: Fringe bitmaps confuse foreground/background colors Keith David Bershatsky
@ 2015-08-21 13:47 ` Eli Zaretskii
  2015-08-22 23:45 ` Keith David Bershatsky
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 20+ messages in thread
From: Eli Zaretskii @ 2015-08-21 13:47 UTC (permalink / raw)
  To: Keith David Bershatsky; +Cc: 21301

> Date: Wed, 19 Aug 2015 13:31:49 -0700
> From: Keith David Bershatsky <esq@lawlist.com>
> 
> The fringe bitmaps in Emacs Trunk seem to confuse the foreground/background colors -- the foreground is the 'default color no matter what, and the background takes on the color of what should have been the foreground.
> 
> For example, a particular fringe bitmap should have a yellow foreground and nothing set for the background -- the result is a yellow background and a 'default foreground (which in my case is white).

I cannot reproduce this with today's master (but I'm not on Darwin).
E.g., evaluating the following in the *scratch* buffer

  (add-text-properties 141 142 '(display (left-fringe left-arrow warning)))

puts a light-red left-arrow on the left fringe near the beginning of
the 3rd line; light-red is the _foreground_ color of the 'warning'
face.  The background color of the fringe stays the same as the
default.

Do you see something different in the above recipe from "emacs -Q"?

If you see the problem in some different recipe, please show it.

Thanks.





^ permalink raw reply	[flat|nested] 20+ messages in thread

* bug#21301: 25.0.50; Emacs Trunk:  Fringe bitmaps confuse foreground/background colors.
  2015-08-19 20:31 bug#21301: 25.0.50; Emacs Trunk: Fringe bitmaps confuse foreground/background colors Keith David Bershatsky
  2015-08-21 13:47 ` Eli Zaretskii
@ 2015-08-22 23:45 ` Keith David Bershatsky
  2015-08-23  2:43   ` Eli Zaretskii
  2015-08-23 17:07 ` Keith David Bershatsky
                   ` (6 subsequent siblings)
  8 siblings, 1 reply; 20+ messages in thread
From: Keith David Bershatsky @ 2015-08-22 23:45 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 21301

I see the opposite -- the bitmap has a red background and the arrow itself is white.  The background of the buffer in this test is the standard white with "emacs -Q".  The test was performed with a fresh build from today.

Keith

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

In GNU Emacs 25.0.50.1 (x86_64-apple-darwin10.8.0, NS appkit-1038.36 Version 10.6.8 (Build 10K549))
 of 2015-08-22 on server.local
Repository revision: 0a3ed5f70c6025fbc2a7e3ca53f11770e4fabe61
Windowing system distributor `Apple', version 10.3.1038
Configured using:
 `configure --with-ns --without-imagemagick'

Configured features:
DBUS ACL LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS

Important settings:
  locale-coding-system: utf-8-unix


;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

At Fri, 21 Aug 2015 16:47:41 +0300,
Eli Zaretskii wrote:

> I cannot reproduce this with today's master (but I'm not on Darwin).
> E.g., evaluating the following in the *scratch* buffer
> 
>   (add-text-properties 141 142 '(display (left-fringe left-arrow warning)))
> 
> puts a light-red left-arrow on the left fringe near the beginning of
> the 3rd line; light-red is the _foreground_ color of the 'warning'
> face.  The background color of the fringe stays the same as the
> default.
> 
> Do you see something different in the above recipe from "emacs -Q"?
> 
> If you see the problem in some different recipe, please show it.
> 
> Thanks.





^ permalink raw reply	[flat|nested] 20+ messages in thread

* bug#21301: 25.0.50; Emacs Trunk:  Fringe bitmaps confuse foreground/background colors.
  2015-08-22 23:45 ` Keith David Bershatsky
@ 2015-08-23  2:43   ` Eli Zaretskii
  2015-08-23 14:05     ` Eli Zaretskii
  0 siblings, 1 reply; 20+ messages in thread
From: Eli Zaretskii @ 2015-08-23  2:43 UTC (permalink / raw)
  To: Keith David Bershatsky; +Cc: 21301

> Date:  Sat, 22 Aug 2015 16:45:10 -0700
> From:  Keith David Bershatsky <esq@lawlist.com>
> Cc:  21301@debbugs.gnu.org
> 
> I see the opposite -- the bitmap has a red background and the arrow itself is white.  The background of the buffer in this test is the standard white with "emacs -Q".  The test was performed with a fresh build from today.

Then I guess this is a Darwin-specific issue.





^ permalink raw reply	[flat|nested] 20+ messages in thread

* bug#21301: 25.0.50; Emacs Trunk:  Fringe bitmaps confuse foreground/background colors.
  2015-08-23  2:43   ` Eli Zaretskii
@ 2015-08-23 14:05     ` Eli Zaretskii
  0 siblings, 0 replies; 20+ messages in thread
From: Eli Zaretskii @ 2015-08-23 14:05 UTC (permalink / raw)
  To: esq; +Cc: 21301

> Date: Sun, 23 Aug 2015 05:43:05 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 21301@debbugs.gnu.org
> 
> > Date:  Sat, 22 Aug 2015 16:45:10 -0700
> > From:  Keith David Bershatsky <esq@lawlist.com>
> > Cc:  21301@debbugs.gnu.org
> > 
> > I see the opposite -- the bitmap has a red background and the arrow itself is white.  The background of the buffer in this test is the standard white with "emacs -Q".  The test was performed with a fresh build from today.
> 
> Then I guess this is a Darwin-specific issue.

I looked in nsterm.m at ns_draw_fringe_bitmap and didn't see anything
clearly wrong.  But then I don't really understand that code.  Could
you perhaps step with a debugger through that function, and see what's
wrong there?

Thanks.





^ permalink raw reply	[flat|nested] 20+ messages in thread

* bug#21301: 25.0.50; Emacs Trunk:  Fringe bitmaps confuse foreground/background colors.
  2015-08-19 20:31 bug#21301: 25.0.50; Emacs Trunk: Fringe bitmaps confuse foreground/background colors Keith David Bershatsky
  2015-08-21 13:47 ` Eli Zaretskii
  2015-08-22 23:45 ` Keith David Bershatsky
@ 2015-08-23 17:07 ` Keith David Bershatsky
  2015-08-23 17:11   ` Eli Zaretskii
  2015-08-29  4:41 ` Keith David Bershatsky
                   ` (5 subsequent siblings)
  8 siblings, 1 reply; 20+ messages in thread
From: Keith David Bershatsky @ 2015-08-23 17:07 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 21301, Jan D.

I would need to learn how to use the debugger in that particular context, but have no experience in that regard.

I carbon copied Jan D. with this email because Jan has been the OSX/Emacs expert in the past on various unrelated issues.

Keith

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

At Sun, 23 Aug 2015 17:05:17 +0300,
Eli Zaretskii wrote:
> 
> ***
> 
> I looked in nsterm.m at ns_draw_fringe_bitmap and didn't see anything
> clearly wrong.  But then I don't really understand that code.  Could
> you perhaps step with a debugger through that function, and see what's
> wrong there?
> 
> Thanks.





^ permalink raw reply	[flat|nested] 20+ messages in thread

* bug#21301: 25.0.50; Emacs Trunk:  Fringe bitmaps confuse foreground/background colors.
  2015-08-23 17:07 ` Keith David Bershatsky
@ 2015-08-23 17:11   ` Eli Zaretskii
  2015-08-23 23:41     ` Glenn Morris
  0 siblings, 1 reply; 20+ messages in thread
From: Eli Zaretskii @ 2015-08-23 17:11 UTC (permalink / raw)
  To: Keith David Bershatsky; +Cc: 21301

> Date:  Sun, 23 Aug 2015 10:07:34 -0700
> From:  Keith David Bershatsky <esq@lawlist.com>
> Cc:  21301@debbugs.gnu.org,"Jan D." <jan.h.d@swipnet.se>
> 
> I would need to learn how to use the debugger in that particular context, but have no experience in that regard.

Thanks in advance.

> I carbon copied Jan D. with this email because Jan has been the OSX/Emacs expert in the past on various unrelated issues.

Alas, Jan no longer works on Emacs development.





^ permalink raw reply	[flat|nested] 20+ messages in thread

* bug#21301: 25.0.50; Emacs Trunk:  Fringe bitmaps confuse foreground/background colors.
  2015-08-23 17:11   ` Eli Zaretskii
@ 2015-08-23 23:41     ` Glenn Morris
  0 siblings, 0 replies; 20+ messages in thread
From: Glenn Morris @ 2015-08-23 23:41 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 21301, Keith David Bershatsky

Eli Zaretskii wrote:

> Alas, Jan no longer works on Emacs development.

I hadn't heard about that.
It's a big loss for Gtk/OS X support, and much else. :(





^ permalink raw reply	[flat|nested] 20+ messages in thread

* bug#21301: 25.0.50; Emacs Trunk:  Fringe bitmaps confuse foreground/background colors.
  2015-08-19 20:31 bug#21301: 25.0.50; Emacs Trunk: Fringe bitmaps confuse foreground/background colors Keith David Bershatsky
                   ` (2 preceding siblings ...)
  2015-08-23 17:07 ` Keith David Bershatsky
@ 2015-08-29  4:41 ` Keith David Bershatsky
  2015-08-29  7:48   ` Eli Zaretskii
  2015-08-29 16:15 ` Keith David Bershatsky
                   ` (4 subsequent siblings)
  8 siblings, 1 reply; 20+ messages in thread
From: Keith David Bershatsky @ 2015-08-29  4:41 UTC (permalink / raw)
  To: Glenn Morris, Eli Zaretskii; +Cc: 21301

I have progress to report in terms of tracking down this bug . . .

Using the layman's method of pinpointing the date that a bug first appeared (i.e., by downloading and try various nightly builds), I determined that bug #21301 started on May 16, 2015.

The bug is NOT present in the build on May 15, 2015 or prior to that date:

Emacs-2015-05-15_01-40-46-ca6a777-universal.app

The bug begins on May 16, 2015 and continues to the present date:

Emacs-2015-05-16_01-40-57-e85053f-universal.app

I also noticed tonight that the wrong direction arrow also appears as a result of the bug -- i.e., instead of a left-arrow with a foreground of red and a white background; it is a right-arrow with a background of red and a white foreground using the test devised by Eli:

(add-text-properties 141 142 '(display (left-fringe left-arrow warning)))

I am so happy we have pinpointed the exact date the bug first appeared.

Thanks,

Keith





^ permalink raw reply	[flat|nested] 20+ messages in thread

* bug#21301: 25.0.50; Emacs Trunk:  Fringe bitmaps confuse foreground/background colors.
  2015-08-29  4:41 ` Keith David Bershatsky
@ 2015-08-29  7:48   ` Eli Zaretskii
  0 siblings, 0 replies; 20+ messages in thread
From: Eli Zaretskii @ 2015-08-29  7:48 UTC (permalink / raw)
  To: Keith David Bershatsky; +Cc: 21301

> Date:  Fri, 28 Aug 2015 21:41:25 -0700
> From:  Keith David Bershatsky <esq@lawlist.com>
> Cc:  21301@debbugs.gnu.org
> 
> The bug is NOT present in the build on May 15, 2015 or prior to that date:
> 
> Emacs-2015-05-15_01-40-46-ca6a777-universal.app
> 
> The bug begins on May 16, 2015 and continues to the present date:
> 
> Emacs-2015-05-16_01-40-57-e85053f-universal.app
> 
> I also noticed tonight that the wrong direction arrow also appears as a result of the bug -- i.e., instead of a left-arrow with a foreground of red and a white background; it is a right-arrow with a background of red and a white foreground using the test devised by Eli:
> 
> (add-text-properties 141 142 '(display (left-fringe left-arrow warning)))

Thanks.  The only relevant commit between May 15th and May 16th is
67a878f.  Could you try building Emacs with the changes in that commit
reverted?  If that doesn't help, try reverting also b00168e and
e0e0753.





^ permalink raw reply	[flat|nested] 20+ messages in thread

* bug#21301: 25.0.50; Emacs Trunk:  Fringe bitmaps confuse foreground/background colors.
  2015-08-19 20:31 bug#21301: 25.0.50; Emacs Trunk: Fringe bitmaps confuse foreground/background colors Keith David Bershatsky
                   ` (3 preceding siblings ...)
  2015-08-29  4:41 ` Keith David Bershatsky
@ 2015-08-29 16:15 ` Keith David Bershatsky
  2015-08-29 16:34   ` Eli Zaretskii
  2015-08-29 19:51 ` Keith David Bershatsky
                   ` (3 subsequent siblings)
  8 siblings, 1 reply; 20+ messages in thread
From: Keith David Bershatsky @ 2015-08-29 16:15 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 21301

I reverted 67a878f, but was unable to build due to the following error:

***

fontset.c: In function 'Finternal_char_font':
fontset.c:1878: warning: comparison is always true due to limited range of data type
fontset.c:1878: warning: comparison is always true due to limited range of data type
fontset.c:1878: warning: comparison is always true due to limited range of data type
fontset.c:1878: warning: comparison is always true due to limited range of data type
  CC       fringe.o
  CC       image.o
  CC       nsterm.o
  CC       nsfns.o
  CC       nsmenu.o
  CC       nsselect.o
  CC       nsimage.o
nsimage.m: In function '-[EmacsImage initFromSkipXBM:width:height:flip:length:]':
nsimage.m:244: error: 'bpr' undeclared (first use in this function)
nsimage.m:244: error: (Each undeclared identifier is reported only once
nsimage.m:244: error: for each function it appears in.)
make[1]: *** [nsimage.o] Error 1
make: *** [src] Error 2

Keith.

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

At Sat, 29 Aug 2015 10:48:50 +0300,
Eli Zaretskii wrote:
> > 
> Thanks.  The only relevant commit between May 15th and May 16th is
> 67a878f.  Could you try building Emacs with the changes in that commit
> reverted?  If that doesn't help, try reverting also b00168e and
> e0e0753.





^ permalink raw reply	[flat|nested] 20+ messages in thread

* bug#21301: 25.0.50; Emacs Trunk:  Fringe bitmaps confuse foreground/background colors.
  2015-08-29 16:15 ` Keith David Bershatsky
@ 2015-08-29 16:34   ` Eli Zaretskii
  0 siblings, 0 replies; 20+ messages in thread
From: Eli Zaretskii @ 2015-08-29 16:34 UTC (permalink / raw)
  To: Keith David Bershatsky; +Cc: 21301

> Date:  Sat, 29 Aug 2015 09:15:02 -0700
> From:  Keith David Bershatsky <esq@lawlist.com>
> Cc:  21301@debbugs.gnu.org
> 
> I reverted 67a878f, but was unable to build due to the following error:
> 
> ***
> 
> fontset.c: In function 'Finternal_char_font':
> fontset.c:1878: warning: comparison is always true due to limited range of data type
> fontset.c:1878: warning: comparison is always true due to limited range of data type
> fontset.c:1878: warning: comparison is always true due to limited range of data type
> fontset.c:1878: warning: comparison is always true due to limited range of data type
>   CC       fringe.o
>   CC       image.o
>   CC       nsterm.o
>   CC       nsfns.o
>   CC       nsmenu.o
>   CC       nsselect.o
>   CC       nsimage.o
> nsimage.m: In function '-[EmacsImage initFromSkipXBM:width:height:flip:length:]':
> nsimage.m:244: error: 'bpr' undeclared (first use in this function)
> nsimage.m:244: error: (Each undeclared identifier is reported only once
> nsimage.m:244: error: for each function it appears in.)
> make[1]: *** [nsimage.o] Error 1
> make: *** [src] Error 2

Can you build Emacs for the last commit before 67a878f, and see if the
problem exists?  If it doesn't, then build the tree as it was after
67a878f was committed; if the problem reappears, we will then know
this is the culprit.

Alternatively, "git bisect" between the last commit on May 14th and
the first commit on May 17th, and see which commit introduced the
problem.

Thanks.





^ permalink raw reply	[flat|nested] 20+ messages in thread

* bug#21301: 25.0.50; Emacs Trunk:  Fringe bitmaps confuse foreground/background colors.
  2015-08-19 20:31 bug#21301: 25.0.50; Emacs Trunk: Fringe bitmaps confuse foreground/background colors Keith David Bershatsky
                   ` (4 preceding siblings ...)
  2015-08-29 16:15 ` Keith David Bershatsky
@ 2015-08-29 19:51 ` Keith David Bershatsky
  2015-08-29 20:18   ` Eli Zaretskii
  2015-08-29 21:52 ` Keith David Bershatsky
                   ` (2 subsequent siblings)
  8 siblings, 1 reply; 20+ messages in thread
From: Keith David Bershatsky @ 2015-08-29 19:51 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 21301

I rolled back to the commit "SHA 67a878f78f879ce534232408c34dd11f42dd802b" [May 15, 2015 at 2:31 a.m.], then built Emacs, and bug#21301 WAS present.

I rolled back to the commit "SHA b1c23fb94072cca7f08ea5f50430916b9ea168e6" [May 15, 2015 at 2:17 a.m.], then built Emacs, and bug#21301 was NOT present -- i.e., everything was working as it should.

Keith

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

At Sat, 29 Aug 2015 19:34:47 +0300,
Eli Zaretskii wrote:
> 
> ***
> 
> Can you build Emacs for the last commit before 67a878f, and see if the
> problem exists?  If it doesn't, then build the tree as it was after
> 67a878f was committed; if the problem reappears, we will then know
> this is the culprit.
> 
> Alternatively, "git bisect" between the last commit on May 14th and
> the first commit on May 17th, and see which commit introduced the
> problem.
> 
> Thanks.





^ permalink raw reply	[flat|nested] 20+ messages in thread

* bug#21301: 25.0.50; Emacs Trunk:  Fringe bitmaps confuse foreground/background colors.
  2015-08-29 19:51 ` Keith David Bershatsky
@ 2015-08-29 20:18   ` Eli Zaretskii
  0 siblings, 0 replies; 20+ messages in thread
From: Eli Zaretskii @ 2015-08-29 20:18 UTC (permalink / raw)
  To: Keith David Bershatsky; +Cc: 21301

> Date:  Sat, 29 Aug 2015 12:51:11 -0700
> From:  Keith David Bershatsky <esq@lawlist.com>
> Cc:  21301@debbugs.gnu.org
> 
> I rolled back to the commit "SHA 67a878f78f879ce534232408c34dd11f42dd802b" [May 15, 2015 at 2:31 a.m.], then built Emacs, and bug#21301 WAS present.
> 
> I rolled back to the commit "SHA b1c23fb94072cca7f08ea5f50430916b9ea168e6" [May 15, 2015 at 2:17 a.m.], then built Emacs, and bug#21301 was NOT present -- i.e., everything was working as it should.
> 

Great, thanks.  So we now know for sure that 67a878f _was_ the
culprit.

I hope someone knowledgeable about NS and OS X will be able to tell
what's wrong with that change, and how to fix it.





^ permalink raw reply	[flat|nested] 20+ messages in thread

* bug#21301: 25.0.50; Emacs Trunk:  Fringe bitmaps confuse foreground/background colors.
  2015-08-19 20:31 bug#21301: 25.0.50; Emacs Trunk: Fringe bitmaps confuse foreground/background colors Keith David Bershatsky
                   ` (5 preceding siblings ...)
  2015-08-29 19:51 ` Keith David Bershatsky
@ 2015-08-29 21:52 ` Keith David Bershatsky
  2015-10-08 21:26 ` Mustafa Kocaturk
  2015-11-04  6:13 ` bug#21301: Fixed bug 21301 Anders Lindgren
  8 siblings, 0 replies; 20+ messages in thread
From: Keith David Bershatsky @ 2015-08-29 21:52 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 21301

Here is the workaround until a fix is found:

Step number 1:  Revert b00168e833ccca1b5c0eebe56688ec44e0efabe7

Step number 2:  Revert 67a878f78f879ce534232408c34dd11f42dd802b

Using the above-steps, I am able to build Emacs to completion and bug#21301 is gone.

Thank you for all your help -- greatly appreciated!  :)

Keith

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

At Sat, 29 Aug 2015 23:18:12 +0300,
Eli Zaretskii wrote:
> 
> ***
>
> Great, thanks.  So we now know for sure that 67a878f _was_ the
> culprit.
> 
> I hope someone knowledgeable about NS and OS X will be able to tell
> what's wrong with that change, and how to fix it.





^ permalink raw reply	[flat|nested] 20+ messages in thread

* bug#21301: 25.0.50; Emacs Trunk:  Fringe bitmaps confuse foreground/background colors.
  2015-08-19 20:31 bug#21301: 25.0.50; Emacs Trunk: Fringe bitmaps confuse foreground/background colors Keith David Bershatsky
                   ` (6 preceding siblings ...)
  2015-08-29 21:52 ` Keith David Bershatsky
@ 2015-10-08 21:26 ` Mustafa Kocaturk
  2015-11-04  6:13 ` bug#21301: Fixed bug 21301 Anders Lindgren
  8 siblings, 0 replies; 20+ messages in thread
From: Mustafa Kocaturk @ 2015-10-08 21:26 UTC (permalink / raw)
  To: 21301

[-- Attachment #1: Type: text/plain, Size: 2933 bytes --]

Hi,

The fringe bitmap is not only displayed in inverse video, but also as a mirror image of the original.

Both issues are fixed in initFromXBM as follows:

1. Flip the bit shift direction: Put most significant bit first. Fixes the mirrored image back to normal.
2. Swap background and foreground color.

The resulting display makes better sense and looks as original as I can tell.

————— Patch follows:

*** Temp/ediff7256bpj	Wed Oct  7 19:22:04 2015
--- src/nsimage.m	Wed Oct  7 18:50:41 2015
***************
*** 253,272 ****
            for (k = 0; i < w && k < 8; ++k, ++i)
              {
                *alpha++ = 0xff;
!               if (c & 1)
!                 {
!                   *rr++ = fgr;
!                   *gg++ = fgg;
!                   *bb++ = fgb;
!                 }
!               else
                  {
                    *rr++ = bgr;
                    *gg++ = bgg;
                    *bb++ = bgb;
                  }
                idx++;
!               c >>= 1;
              }
          }
    }
--- 253,272 ----
            for (k = 0; i < w && k < 8; ++k, ++i)
              {
                *alpha++ = 0xff;
!               if (c & 0x80)
                  {
                    *rr++ = bgr;
                    *gg++ = bgg;
                    *bb++ = bgb;
                  }
+               else
+                 {
+                   *rr++ = fgr;
+                   *gg++ = fgg;
+                   *bb++ = fgb;
+                 }
                idx++;
!               c <<= 1;
              }
          }
    }


> > Date:  Sat, 29 Aug 2015 12:51:11 -0700
> > From:  Keith David Bershatsky <address@hidden>
> > Cc:  address@hidden
> > 
> > I rolled back to the commit "SHA 67a878f78f879ce534232408c34dd11f42dd802b" 
> > [May 15, 2015 at 2:31 a.m.], then built Emacs, and bug#21301 WAS present.
> > 
> > I rolled back to the commit "SHA b1c23fb94072cca7f08ea5f50430916b9ea168e6" 
> > [May 15, 2015 at 2:17 a.m.], then built Emacs, and bug#21301 was NOT present 
> > -- i.e., everything was working as it should.
> > 
> Great, thanks.  So we now know for sure that 67a878f _was_ the
> culprit.
> 
> I hope someone knowledgeable about NS and OS X will be able to tell
> what's wrong with that change, and how to fix it.
Just the two reversals mentioned above, which were obvious from the way bitmaps appear on screen.
Not much else was needed in the way of OS X or NS knowledge, luckily for me :).

Another annoying display issue remains, though: 
Visible bell no longer displays solid black, but distorted pieces of bitmap from another part of the screen, and leaves a stubborn garbled rectangle behind, hiding the original text. 
I’m not sure if this has been reported as a bug, but suspecting it involves ns_ring_bell in nsterm.m and around the same time frame.

Best regards,
Mustafa

[-- Attachment #2: Type: text/html, Size: 6666 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* bug#21301: Fixed bug 21301
  2015-08-19 20:31 bug#21301: 25.0.50; Emacs Trunk: Fringe bitmaps confuse foreground/background colors Keith David Bershatsky
                   ` (7 preceding siblings ...)
  2015-10-08 21:26 ` Mustafa Kocaturk
@ 2015-11-04  6:13 ` Anders Lindgren
  2015-11-04 16:40   ` Glenn Morris
  2015-11-04 16:53   ` bug#21301: Fwd: " Anders Lindgren
  8 siblings, 2 replies; 20+ messages in thread
From: Anders Lindgren @ 2015-11-04  6:13 UTC (permalink / raw)
  To: 21301

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

I just pushed a fix for this, see
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=411b516d65b4e3b88e7b268dac7a32668e8d39c7
for details.

    -- Anders Lindgren

[-- Attachment #2: Type: text/html, Size: 339 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* bug#21301: Fixed bug 21301
  2015-11-04  6:13 ` bug#21301: Fixed bug 21301 Anders Lindgren
@ 2015-11-04 16:40   ` Glenn Morris
  2015-11-04 16:51     ` Anders Lindgren
  2015-11-04 16:53   ` bug#21301: Fwd: " Anders Lindgren
  1 sibling, 1 reply; 20+ messages in thread
From: Glenn Morris @ 2015-11-04 16:40 UTC (permalink / raw)
  To: Anders Lindgren; +Cc: 21301

Anders Lindgren wrote:

> I just pushed a fix for this, see

Then please close the bug report, eg by mailing 21301-done@debbugs.





^ permalink raw reply	[flat|nested] 20+ messages in thread

* bug#21301: Fixed bug 21301
  2015-11-04 16:40   ` Glenn Morris
@ 2015-11-04 16:51     ` Anders Lindgren
  0 siblings, 0 replies; 20+ messages in thread
From: Anders Lindgren @ 2015-11-04 16:51 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 21301

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

Thanks,

I didn't know how that was being done!  I will do it immediately.

Sincerely,
    Anders Lindgren

On Wed, Nov 4, 2015 at 5:40 PM, Glenn Morris <rgm@gnu.org> wrote:

> Anders Lindgren wrote:
>
> > I just pushed a fix for this, see
>
> Then please close the bug report, eg by mailing 21301-done@debbugs.
>

[-- Attachment #2: Type: text/html, Size: 683 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* bug#21301: Fwd: Fixed bug 21301
  2015-11-04  6:13 ` bug#21301: Fixed bug 21301 Anders Lindgren
  2015-11-04 16:40   ` Glenn Morris
@ 2015-11-04 16:53   ` Anders Lindgren
  1 sibling, 0 replies; 20+ messages in thread
From: Anders Lindgren @ 2015-11-04 16:53 UTC (permalink / raw)
  To: 21301-done

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

Hi,

I just pushed a fix for this, see
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=411b516d65b4e3b88e7b268dac7a32668e8d39c7
for details.

    -- Anders Lindgren

[-- Attachment #2: Type: text/html, Size: 508 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2015-11-04 16:53 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-19 20:31 bug#21301: 25.0.50; Emacs Trunk: Fringe bitmaps confuse foreground/background colors Keith David Bershatsky
2015-08-21 13:47 ` Eli Zaretskii
2015-08-22 23:45 ` Keith David Bershatsky
2015-08-23  2:43   ` Eli Zaretskii
2015-08-23 14:05     ` Eli Zaretskii
2015-08-23 17:07 ` Keith David Bershatsky
2015-08-23 17:11   ` Eli Zaretskii
2015-08-23 23:41     ` Glenn Morris
2015-08-29  4:41 ` Keith David Bershatsky
2015-08-29  7:48   ` Eli Zaretskii
2015-08-29 16:15 ` Keith David Bershatsky
2015-08-29 16:34   ` Eli Zaretskii
2015-08-29 19:51 ` Keith David Bershatsky
2015-08-29 20:18   ` Eli Zaretskii
2015-08-29 21:52 ` Keith David Bershatsky
2015-10-08 21:26 ` Mustafa Kocaturk
2015-11-04  6:13 ` bug#21301: Fixed bug 21301 Anders Lindgren
2015-11-04 16:40   ` Glenn Morris
2015-11-04 16:51     ` Anders Lindgren
2015-11-04 16:53   ` bug#21301: Fwd: " Anders Lindgren

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).